From 25cd151276458dc49f50d8876d5082a498c5c86b Mon Sep 17 00:00:00 2001 From: TRaSH Date: Sat, 24 Jun 2023 16:31:10 +0200 Subject: [PATCH 1/2] fix(starr): change must warning to choice **Purpose** Fix #1370 **Approach** Several Quality profiles have a demanding MUST must warning for several CF that should be used, change warning/description to choice. **Requirements** Check all boxes as they are completed - [ ] Change x265 (no HDR/DV) must to choice - [x] Change SDR must to choice - [ ] Test changes in local test setup - [x] These changes meet the standards for [contributing](https://github.com/TRaSH-/Guides/blob/master/.github/CONTRIBUTING.md). - [x] I have read the [code of conduct](https://github.com/TRaSH-/Guides/blob/master/.github/CODE_OF_CONDUCT.md). --- includes/cf/radarr-optional-uhd.md | 2 -- includes/cf/sonarr-optional-uhd.md | 2 -- includes/sqp/1-4k-cf-scoring-sqp1.md | 2 +- includes/sqp/1-4k-cf-scoring.md | 2 +- includes/sqp/uhd-radarr-optional.md | 4 ++-- 5 files changed, 4 insertions(+), 8 deletions(-) diff --git a/includes/cf/radarr-optional-uhd.md b/includes/cf/radarr-optional-uhd.md index a4d8add0e..d3986a3b7 100644 --- a/includes/cf/radarr-optional-uhd.md +++ b/includes/cf/radarr-optional-uhd.md @@ -1,7 +1,5 @@ ??? abstract "Optional UHD - [CLICK TO EXPAND]" - !!! danger "**The `SDR` is a MUST for this Quality Profile** :warning:" - | Custom Format | Score | Trash ID | | ------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------- | ------------------------------------------------- | | [{{ radarr['cf']['sdr']['name'] }}](/Radarr/Radarr-collection-of-custom-formats/#sdr) | {{ radarr['cf']['sdr']['trash_score'] }} | {{ radarr['cf']['sdr']['trash_id'] }} | diff --git a/includes/cf/sonarr-optional-uhd.md b/includes/cf/sonarr-optional-uhd.md index 963c78cb7..d2158294b 100644 --- a/includes/cf/sonarr-optional-uhd.md +++ b/includes/cf/sonarr-optional-uhd.md @@ -1,7 +1,5 @@ ??? abstract "Optional UHD - [CLICK TO EXPAND]" - !!! danger "**The `SDR` is a MUST for this Quality Profile** :warning:" - | Custom Format | Score | Trash ID | | ------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------- | ------------------------------------------------- | | [{{ sonarr['cf']['sdr']['name'] }}](/Sonarr/sonarr-collection-of-custom-formats/#sdr) | {{ sonarr['cf']['sdr']['trash_score'] }} | {{ sonarr['cf']['sdr']['trash_id'] }} | diff --git a/includes/sqp/1-4k-cf-scoring-sqp1.md b/includes/sqp/1-4k-cf-scoring-sqp1.md index f6cef7d56..39bc4191b 100644 --- a/includes/sqp/1-4k-cf-scoring-sqp1.md +++ b/includes/sqp/1-4k-cf-scoring-sqp1.md @@ -81,7 +81,7 @@ ??? abstract "Optional - [CLICK TO EXPAND]" !!! danger "**The `x265 (no HDR/DV)` is a MUST for this SQP** :warning:" - !!! danger "**The `SDR` is a MUST for this SQP** :warning:" + !!! tip "**I recommend to use the `SDR`,
This will help to prevent to grab UHD/4k releases without HDR Formats**" | Custom Format | Score | Trash ID | | ------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------- | ------------------------------------------------- | diff --git a/includes/sqp/1-4k-cf-scoring.md b/includes/sqp/1-4k-cf-scoring.md index 192cf14dd..289868597 100644 --- a/includes/sqp/1-4k-cf-scoring.md +++ b/includes/sqp/1-4k-cf-scoring.md @@ -81,7 +81,7 @@ ??? abstract "Optional - [CLICK TO EXPAND]" !!! danger "**The `x265 (no HDR/DV)` is a MUST for this SQP** :warning:" - !!! danger "**The `SDR` is a MUST for this SQP** :warning:" + !!! tip "**I recommend to use the `SDR`,
This will help to prevent to grab UHD/4k releases without HDR Formats**" | Custom Format | Score | Trash ID | | ------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------- | ------------------------------------------------- | diff --git a/includes/sqp/uhd-radarr-optional.md b/includes/sqp/uhd-radarr-optional.md index f8b04e818..070b30041 100644 --- a/includes/sqp/uhd-radarr-optional.md +++ b/includes/sqp/uhd-radarr-optional.md @@ -1,8 +1,8 @@ ??? abstract "Optional - [CLICK TO EXPAND]" !!! danger "**The `x265 (no HDR/DV)` is a MUST for this SQP** :warning:" - !!! danger "**The `SDR` is a MUST for this SQP** :warning:" - !!! tip "The `DV (FEL)` is recommended for SQP2 and 3" + !!! tip "**I recommend to use the `SDR`,
This will help to prevent to grab UHD/4k releases without HDR Formats**" + !!! tip "The `DV (FEL)` is recommended for SQP2 and 3 or any other Profile doing 4k/UHD Remuxes" | Custom Format | Score | Trash ID | | ------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------- | ------------------------------------------------- | From 18b01911fb12370df80b1b76b4d7f778244bff6c Mon Sep 17 00:00:00 2001 From: TRaSH Date: Sat, 24 Jun 2023 17:50:40 +0200 Subject: [PATCH 2/2] Fix: Change x265 (no HDR/DV) must to suggestion --- includes/sqp/1-4k-cf-scoring-sqp1.md | 4 ++-- includes/sqp/1-4k-cf-scoring.md | 4 ++-- includes/sqp/uhd-radarr-optional.md | 5 ++--- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/includes/sqp/1-4k-cf-scoring-sqp1.md b/includes/sqp/1-4k-cf-scoring-sqp1.md index 39bc4191b..d9d01878f 100644 --- a/includes/sqp/1-4k-cf-scoring-sqp1.md +++ b/includes/sqp/1-4k-cf-scoring-sqp1.md @@ -76,11 +76,11 @@ {! include-markdown "../../includes/cf/radarr-misc.md" !} -{! include-markdown "../../includes/sqp/radarr-unwanted-uhd.md" !} +{! include-markdown "../../includes/cf/radarr-unwanted-uhd.md" !} ??? abstract "Optional - [CLICK TO EXPAND]" - !!! danger "**The `x265 (no HDR/DV)` is a MUST for this SQP** :warning:" + !!! tip "**I recommend to use the `x265 (no HDR/DV)` over the `x265 (HD)`, Read the Why below and don't forget to read the warning, :warning: Only ever include one of them :warning:**" !!! tip "**I recommend to use the `SDR`,
This will help to prevent to grab UHD/4k releases without HDR Formats**" | Custom Format | Score | Trash ID | diff --git a/includes/sqp/1-4k-cf-scoring.md b/includes/sqp/1-4k-cf-scoring.md index 289868597..b7759f83e 100644 --- a/includes/sqp/1-4k-cf-scoring.md +++ b/includes/sqp/1-4k-cf-scoring.md @@ -76,11 +76,11 @@ {! include-markdown "../../includes/cf/radarr-misc.md" !} -{! include-markdown "../../includes/sqp/radarr-unwanted-uhd.md" !} +{! include-markdown "../../includes/cf/radarr-unwanted-uhd.md" !} ??? abstract "Optional - [CLICK TO EXPAND]" - !!! danger "**The `x265 (no HDR/DV)` is a MUST for this SQP** :warning:" + !!! tip "**I recommend to use the `x265 (no HDR/DV)` over the `x265 (HD)`, Read the Why below and don't forget to read the warning, :warning: Only ever include one of them :warning:**" !!! tip "**I recommend to use the `SDR`,
This will help to prevent to grab UHD/4k releases without HDR Formats**" | Custom Format | Score | Trash ID | diff --git a/includes/sqp/uhd-radarr-optional.md b/includes/sqp/uhd-radarr-optional.md index 070b30041..d8ef534c3 100644 --- a/includes/sqp/uhd-radarr-optional.md +++ b/includes/sqp/uhd-radarr-optional.md @@ -1,8 +1,7 @@ ??? abstract "Optional - [CLICK TO EXPAND]" - !!! danger "**The `x265 (no HDR/DV)` is a MUST for this SQP** :warning:" + !!! tip "**I recommend to use the `x265 (no HDR/DV)` over the `x265 (HD)`, Read the Why below and don't forget to read the warning, :warning: Only ever include one of them :warning:**" !!! tip "**I recommend to use the `SDR`,
This will help to prevent to grab UHD/4k releases without HDR Formats**" - !!! tip "The `DV (FEL)` is recommended for SQP2 and 3 or any other Profile doing 4k/UHD Remuxes" | Custom Format | Score | Trash ID | | ------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------- | ------------------------------------------------- | @@ -38,7 +37,7 @@ - If you only watch your movies on a setup that completely supports Dolby Vision from start to end then give it a score of `0` or just don't add it. - If you (or family members you share your collection with) have a setup that doesn't support Dolby Vision then you should add this with a score of `{{ radarr['cf']['dv-webdl']['trash_score'] }}`. - - **{{ radarr['cf']['hdr10plus-boost']['name'] }}:** [*Optional*] (use this one only if you have a (Samsung) TV that supports HDR10+ and you don't have a Setup that supports DV or you prefer HDR10+ + - **{{ radarr['cf']['hdr10plus-boost']['name'] }}:** [*Optional*] (use this one only if you have a (Samsung) TV that supports HDR10+ and you don't have a Setup that supports DV or you prefer HDR10+) - **{{ radarr['cf']['evo-no-webdl']['name'] }}:** This group is often banned for the low quality Blu-ray releases, but their WEB-DL are okay. - **{{ radarr['cf']['no-rlsgroup']['name'] }}:** [*Optional*] Some indexers strip out the release group what could result in LQ groups getting a higher score. For example a lot of EVO releases end up stripping the group name, so they appear as "upgrades", and they end up getting a decent score if other things match. - **{{ radarr['cf']['obfuscated']['name'] }}:** [*Optional*] (use these only if you dislike renamed releases)