From 565fb53d3b438a92ff5c09e6020df050e0360fc8 Mon Sep 17 00:00:00 2001 From: Oleksii Holub <1935960+Tyrrrz@users.noreply.github.com> Date: Thu, 30 Jun 2022 18:13:14 +0300 Subject: [PATCH] Cleanup tests --- .../Specs/HtmlWriting/ContentSpecs.cs | 15 -------------- .../Specs/HtmlWriting/EmbedSpecs.cs | 20 ++++++++++++++++--- .../Specs/HtmlWriting/StickerSpecs.cs | 2 +- 3 files changed, 18 insertions(+), 19 deletions(-) diff --git a/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/ContentSpecs.cs b/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/ContentSpecs.cs index f9dfb46..803dd8f 100644 --- a/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/ContentSpecs.cs +++ b/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/ContentSpecs.cs @@ -3,7 +3,6 @@ using System.Threading.Tasks; using AngleSharp.Dom; using DiscordChatExporter.Cli.Tests.Fixtures; using DiscordChatExporter.Cli.Tests.TestData; -using DiscordChatExporter.Core.Discord; using FluentAssertions; using Xunit; @@ -47,18 +46,4 @@ public class ContentSpecs : IClassFixture "Yeet" ); } - - [Fact] - public async Task Message_content_is_hidden_if_it_only_contains_a_link_to_an_image() - { - // Act - var message = await _exportWrapper.GetMessageAsHtmlAsync( - ChannelIds.EmbedTestCases, - Snowflake.Parse("991768701126852638") - ); - - // Assert - var content = message.QuerySelector(".chatlog__content")?.Text(); - content.Should().BeNullOrEmpty(); - } } \ No newline at end of file diff --git a/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/EmbedSpecs.cs b/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/EmbedSpecs.cs index 3851247..45c5dd7 100644 --- a/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/EmbedSpecs.cs +++ b/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/EmbedSpecs.cs @@ -40,7 +40,7 @@ public class EmbedSpecs : IClassFixture } [Fact] - public async Task Message_with_a_link_to_an_image_contains_an_embed_of_that_image() + public async Task Message_containing_an_image_link_is_rendered_with_an_image_embed() { // Act var message = await _exportWrapper.GetMessageAsHtmlAsync( @@ -57,7 +57,21 @@ public class EmbedSpecs : IClassFixture } [Fact] - public async Task Message_with_a_Spotify_track_is_rendered_using_an_iframe() + public async Task Message_containing_an_image_link_and_nothing_else_is_rendered_without_text_content() + { + // Act + var message = await _exportWrapper.GetMessageAsHtmlAsync( + ChannelIds.EmbedTestCases, + Snowflake.Parse("991768701126852638") + ); + + // Assert + var content = message.QuerySelector(".chatlog__content")?.Text(); + content.Should().BeNullOrEmpty(); + } + + [Fact] + public async Task Message_containing_a_Spotify_track_link_is_rendered_with_a_track_embed() { // Act var message = await _exportWrapper.GetMessageAsHtmlAsync( @@ -71,7 +85,7 @@ public class EmbedSpecs : IClassFixture } [Fact] - public async Task Message_with_a_YouTube_video_is_rendered_using_an_iframe() + public async Task Message_containing_a_YouTube_video_link_is_rendered_with_a_video_embed() { // Act var message = await _exportWrapper.GetMessageAsHtmlAsync( diff --git a/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/StickerSpecs.cs b/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/StickerSpecs.cs index 7c6544f..a950a87 100644 --- a/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/StickerSpecs.cs +++ b/DiscordChatExporter.Cli.Tests/Specs/HtmlWriting/StickerSpecs.cs @@ -40,7 +40,7 @@ public class StickerSpecs : IClassFixture ); // Assert - var stickerUrl = message.QuerySelector("[title='Yikes'] div[data-source]")?.GetAttribute("data-source"); + var stickerUrl = message.QuerySelector("[title='Yikes'] [data-source]")?.GetAttribute("data-source"); stickerUrl.Should().Be("https://discord.com/stickers/816087132447178774.json"); } } \ No newline at end of file