+
@@ -495,26 +470,27 @@ class ArtistDetails extends Component {
{
!isFetching && episodesError &&
-
Loading episodes failed
+
Loading albums failed
}
{
!isFetching && trackFilesError &&
-
Loading episode files failed
+
Loading track files failed
}
{
- isPopulated && !!albumTypes.length &&
+ isPopulated && !!primaryAlbumTypes.length &&
{
- albumTypes.slice(0).map((season) => {
+ primaryAlbumTypes.slice(0).map((albumType) => {
return (
);
@@ -570,6 +546,7 @@ ArtistDetails.propTypes = {
links: PropTypes.arrayOf(PropTypes.object).isRequired,
images: PropTypes.arrayOf(PropTypes.object).isRequired,
albums: PropTypes.arrayOf(PropTypes.object).isRequired,
+ primaryAlbumTypes: PropTypes.arrayOf(PropTypes.string).isRequired,
alternateTitles: PropTypes.arrayOf(PropTypes.string).isRequired,
tags: PropTypes.arrayOf(PropTypes.number).isRequired,
isRefreshing: PropTypes.bool.isRequired,
diff --git a/frontend/src/Artist/Index/Overview/ArtistIndexOverview.css b/frontend/src/Artist/Index/Overview/ArtistIndexOverview.css
index cb1b3c0fb..c407524b9 100644
--- a/frontend/src/Artist/Index/Overview/ArtistIndexOverview.css
+++ b/frontend/src/Artist/Index/Overview/ArtistIndexOverview.css
@@ -47,7 +47,9 @@ $hoverScale: 1.05;
}
.info {
+ display: flex;
flex: 1 0 1px;
+ flex-direction: column;
overflow: hidden;
padding-left: 10px;
}
@@ -75,6 +77,7 @@ $hoverScale: 1.05;
.details {
display: flex;
justify-content: space-between;
+ flex: 1 0 auto;
}
.overview {
@@ -82,6 +85,7 @@ $hoverScale: 1.05;
flex: 0 1 1000px;
overflow: hidden;
+ min-height: 0;
}
@media only screen and (max-width: $breakpointSmall) {
diff --git a/frontend/src/Artist/Index/Overview/ArtistIndexOverview.js b/frontend/src/Artist/Index/Overview/ArtistIndexOverview.js
index b1567fcff..692f59760 100644
--- a/frontend/src/Artist/Index/Overview/ArtistIndexOverview.js
+++ b/frontend/src/Artist/Index/Overview/ArtistIndexOverview.js
@@ -1,6 +1,6 @@
import PropTypes from 'prop-types';
import React, { Component } from 'react';
-import Truncate from 'react-truncate';
+import TextTruncate from 'react-text-truncate';
import { icons } from 'Helpers/Props';
import dimensions from 'Styles/Variables/dimensions';
import fonts from 'Styles/Variables/fonts';
@@ -176,16 +176,15 @@ class ArtistIndexOverview extends Component {
+
-
- {overview}
-
+
{children}
@@ -180,6 +182,7 @@ class Modal extends Component {
Modal.propTypes = {
className: PropTypes.string,
+ style: PropTypes.object,
backdropClassName: PropTypes.string,
size: PropTypes.oneOf(sizes.all),
children: PropTypes.node,
diff --git a/frontend/src/Components/Modal/ModalBody.css b/frontend/src/Components/Modal/ModalBody.css
index 2e55a91cb..ebeef29de 100644
--- a/frontend/src/Components/Modal/ModalBody.css
+++ b/frontend/src/Components/Modal/ModalBody.css
@@ -1,5 +1,3 @@
-$modalBodyPadding: 30px;
-
.modalBody {
flex: 1 0 1px;
padding: $modalBodyPadding;
diff --git a/frontend/src/Components/Page/Header/PageHeader.js b/frontend/src/Components/Page/Header/PageHeader.js
index 2d6b3dbd6..02ad59887 100644
--- a/frontend/src/Components/Page/Header/PageHeader.js
+++ b/frontend/src/Components/Page/Header/PageHeader.js
@@ -23,13 +23,13 @@ class PageHeader extends Component {
}
componentDidMount() {
- this.props.bindShortcut(shortcuts.OPEN_KEYBOARD_SHORTCUTS_MODAL.key, this.openKeyboardShortcutsModal);
+ this.props.bindShortcut(shortcuts.OPEN_KEYBOARD_SHORTCUTS_MODAL.key, this.onOpenKeyboardShortcutsModal);
}
//
// Control
- openKeyboardShortcutsModal = () => {
+ onOpenKeyboardShortcutsModal = () => {
this.setState({ isKeyboardShortcutsModalOpen: true });
}
@@ -76,7 +76,9 @@ class PageHeader extends Component {
name={icons.HEART}
to="https://lidarr.audio/donate.html"
/>
-
+