From 6372764f61fa0e5997dab2e56f8fa18c1ed81818 Mon Sep 17 00:00:00 2001 From: Bogdan Date: Tue, 25 Jul 2023 21:56:23 +0300 Subject: [PATCH] Rename formatPreferredWordScore to formatCustomFormatScore Closes #3930 --- .../src/Activity/History/Details/HistoryDetails.js | 8 ++++---- frontend/src/Activity/History/HistoryRow.js | 4 ++-- frontend/src/Activity/Queue/QueueRow.js | 4 ++-- frontend/src/Album/Details/TrackRow.js | 4 ++-- frontend/src/Artist/History/ArtistHistoryRow.js | 4 ++-- frontend/src/InteractiveSearch/InteractiveSearchRow.js | 4 ++-- ...referredWordScore.js => formatCustomFormatScore.ts} | 10 ++++++---- 7 files changed, 20 insertions(+), 18 deletions(-) rename frontend/src/Utilities/Number/{formatPreferredWordScore.js => formatCustomFormatScore.ts} (50%) diff --git a/frontend/src/Activity/History/Details/HistoryDetails.js b/frontend/src/Activity/History/Details/HistoryDetails.js index 2c8b97060..cc0e69fd5 100644 --- a/frontend/src/Activity/History/Details/HistoryDetails.js +++ b/frontend/src/Activity/History/Details/HistoryDetails.js @@ -9,7 +9,7 @@ import Link from 'Components/Link/Link'; import { icons } from 'Helpers/Props'; import formatDateTime from 'Utilities/Date/formatDateTime'; import formatAge from 'Utilities/Number/formatAge'; -import formatPreferredWordScore from 'Utilities/Number/formatPreferredWordScore'; +import formatCustomFormatScore from 'Utilities/Number/formatCustomFormatScore'; import translate from 'Utilities/String/translate'; import styles from './HistoryDetails.css'; @@ -110,7 +110,7 @@ function HistoryDetails(props) { customFormatScore && customFormatScore !== '0' ? : null } @@ -227,7 +227,7 @@ function HistoryDetails(props) { customFormatScore && customFormatScore !== '0' ? : null } @@ -273,7 +273,7 @@ function HistoryDetails(props) { customFormatScore && customFormatScore !== '0' ? : null } diff --git a/frontend/src/Activity/History/HistoryRow.js b/frontend/src/Activity/History/HistoryRow.js index 98925f6db..23dea5416 100644 --- a/frontend/src/Activity/History/HistoryRow.js +++ b/frontend/src/Activity/History/HistoryRow.js @@ -10,7 +10,7 @@ import TableRowCell from 'Components/Table/Cells/TableRowCell'; import TableRow from 'Components/Table/TableRow'; import Tooltip from 'Components/Tooltip/Tooltip'; import { icons, tooltipPositions } from 'Helpers/Props'; -import formatPreferredWordScore from 'Utilities/Number/formatPreferredWordScore'; +import formatCustomFormatScore from 'Utilities/Number/formatCustomFormatScore'; import HistoryDetailsModal from './Details/HistoryDetailsModal'; import HistoryEventTypeCell from './HistoryEventTypeCell'; import styles from './HistoryRow.css'; @@ -189,7 +189,7 @@ class HistoryRow extends Component { className={styles.customFormatScore} > } position={tooltipPositions.BOTTOM} diff --git a/frontend/src/Utilities/Number/formatPreferredWordScore.js b/frontend/src/Utilities/Number/formatCustomFormatScore.ts similarity index 50% rename from frontend/src/Utilities/Number/formatPreferredWordScore.js rename to frontend/src/Utilities/Number/formatCustomFormatScore.ts index 5869f0052..b4da3a2cd 100644 --- a/frontend/src/Utilities/Number/formatPreferredWordScore.js +++ b/frontend/src/Utilities/Number/formatCustomFormatScore.ts @@ -1,5 +1,7 @@ - -function formatPreferredWordScore(input, customFormatsLength = 0) { +function formatCustomFormatScore( + input?: number, + customFormatsLength = 0 +): string { const score = Number(input); if (score > 0) { @@ -7,10 +9,10 @@ function formatPreferredWordScore(input, customFormatsLength = 0) { } if (score < 0) { - return score; + return `${score}`; } return customFormatsLength > 0 ? '+0' : ''; } -export default formatPreferredWordScore; +export default formatCustomFormatScore;