From 9d00a17adef7a382787902a85359370edaa4f4b7 Mon Sep 17 00:00:00 2001 From: Tynan CR Date: Sun, 17 Dec 2017 00:49:47 -0500 Subject: [PATCH] Fixed eslint errors and re-enabled build.sh check (#150) * Fixed eslint errors and re-enabled build.sh check * Corrected typo * Corrected typo * Disabled max-params on files with warnings * Fixes for PR comments * Fixes for PR comments * Fixes for PR comments * Fixes for PR comments * Fixes for PR comments * Fixes for PR comments --- build.sh | 2 +- frontend/.eslintrc | 4 +- .../Activity/Blacklist/BlacklistConnector.js | 2 +- frontend/src/Activity/Queue/Queue.js | 2 +- frontend/src/Activity/Queue/QueueRow.js | 1 - .../Import/ImportArtistConnector.js | 1 + frontend/src/Album/Summary/EpisodeAiring.js | 7 +--- .../Album/Summary/EpisodeAiringConnector.js | 3 +- frontend/src/Album/Summary/EpisodeSummary.js | 5 +-- .../Album/Summary/EpisodeSummaryConnector.js | 5 ++- frontend/src/AlbumStudio/AlbumStudioAlbum.js | 1 - frontend/src/Artist/Details/AlbumRow.js | 1 - .../src/Artist/Details/AlbumRowConnector.js | 5 +-- frontend/src/Artist/Details/ArtistDetails.js | 2 - .../Artist/Details/ArtistDetailsConnector.js | 1 + .../src/Artist/Details/ArtistDetailsLinks.js | 2 +- .../src/Artist/Details/ArtistDetailsSeason.js | 19 ++------- .../Details/ArtistDetailsSeasonConnector.js | 20 +--------- frontend/src/Artist/Editor/ArtistEditorRow.js | 1 - .../src/Artist/Index/ArtistIndexConnector.js | 1 + .../Artist/Index/ArtistIndexItemConnector.js | 1 + .../Index/Overview/ArtistIndexOverviewInfo.js | 1 + .../Index/Posters/ArtistIndexPosters.js | 2 +- frontend/src/Calendar/Agenda/AgendaEvent.js | 1 - frontend/src/Calendar/Day/CalendarDay.js | 3 +- frontend/src/Calendar/Events/CalendarEvent.js | 2 - .../src/Calendar/Header/CalendarHeader.js | 1 + .../src/Components/Page/Header/PageHeader.js | 1 - frontend/src/Components/Page/PageConnector.js | 1 + .../Components/Table/Cells/TableSelectCell.js | 1 + .../TableOptionsColumnDragPreview.js | 2 + .../TableOptionsColumnDragSource.js | 2 + .../Table/TableOptions/TableOptionsModal.js | 2 + frontend/src/Components/Tooltip/Tooltip.js | 2 +- .../Track/SelectTrackModalContentConnector.js | 12 +++--- .../OrganizePreviewModalContentConnector.js | 2 +- .../MetadataProvider/MetadataProvider.js | 40 +++++++++---------- .../Profiles/Delay/DelayProfileDragPreview.js | 3 ++ .../Profiles/Delay/DelayProfileDragSource.js | 2 + .../LanguageProfileItemDragPreview.js | 2 + .../Language/LanguageProfileItemDragSource.js | 2 + frontend/src/Settings/Profiles/Profiles.js | 3 +- .../Quality/QualityProfileItemDragPreview.js | 2 + .../Quality/QualityProfileItemDragSource.js | 3 ++ .../createToggleAlbumMonitoredHandler.js | 2 +- frontend/src/Store/connectSection.js | 1 + .../TrackFileEditorModalContentConnector.js | 2 +- .../TrackFile/Editor/TrackFileEditorRow.js | 1 - frontend/src/Utilities/Album/updateAlbums.js | 1 + .../src/Utilities/Table/toggleSelected.js | 1 + frontend/src/Wanted/Missing/MissingRow.js | 1 - 51 files changed, 84 insertions(+), 103 deletions(-) diff --git a/build.sh b/build.sh index c104e34cd..7a4e6bd7f 100755 --- a/build.sh +++ b/build.sh @@ -87,7 +87,7 @@ ProgressEnd() LintUI() { ProgressStart 'ESLint' -# CheckExitCode yarn eslint + CheckExitCode yarn eslint ProgressEnd 'ESLint' ProgressStart 'Stylelint' diff --git a/frontend/.eslintrc b/frontend/.eslintrc index 5208e3ad6..466bb0e8c 100644 --- a/frontend/.eslintrc +++ b/frontend/.eslintrc @@ -177,7 +177,7 @@ "no-undef": "error", "no-undef-init": "off", "no-undefined": "off", - "no-unused-vars": ["error", { "args": "none" }], + "no-unused-vars": ["warn", { "args": "none" }], "no-use-before-define": "error", # Node.js and CommonJS @@ -209,7 +209,7 @@ "lines-around-comment": ["error", { "beforeBlockComment": true, "afterBlockComment": false }], "max-depth": ["error", {"maximum": 5}], "max-nested-callbacks": ["error", 4], - "max-params": ["error", 4], + "max-params": ["warn", 4], "max-statements": "off", "max-statements-per-line": ["error", { "max": 1 }], "new-cap": ["error", {"capIsNewExceptions": ["$.Deferred"]}], diff --git a/frontend/src/Activity/Blacklist/BlacklistConnector.js b/frontend/src/Activity/Blacklist/BlacklistConnector.js index 82c0d7ba4..0528dffaa 100644 --- a/frontend/src/Activity/Blacklist/BlacklistConnector.js +++ b/frontend/src/Activity/Blacklist/BlacklistConnector.js @@ -36,7 +36,7 @@ class BlacklistConnector extends Component { // Lifecycle componentDidMount() { - registerPagePopulator(this.repopulate); + registerPagePopulator(this.repopulate); this.props.gotoBlacklistFirstPage(); } diff --git a/frontend/src/Activity/Queue/Queue.js b/frontend/src/Activity/Queue/Queue.js index 8cfa4c77d..f3144bb0a 100644 --- a/frontend/src/Activity/Queue/Queue.js +++ b/frontend/src/Activity/Queue/Queue.js @@ -137,7 +137,7 @@ class Queue extends Component { isPendingSelected } = this.state; - const isRefreshing = isFetching || isAlbumsFetching || isCheckForFinishedDownloadExecuting; + const isRefreshing = isFetching || isAlbumsFetching || isCheckForFinishedDownloadExecuting; const isAllPopulated = isPopulated && (isAlbumsPopulated || !items.length); const hasError = error || episodesError; const selectedCount = this.getSelectedIds().length; diff --git a/frontend/src/Activity/Queue/QueueRow.js b/frontend/src/Activity/Queue/QueueRow.js index fcb13a9f8..3123b1fb6 100644 --- a/frontend/src/Activity/Queue/QueueRow.js +++ b/frontend/src/Activity/Queue/QueueRow.js @@ -10,7 +10,6 @@ import TableSelectCell from 'Components/Table/Cells/TableSelectCell'; import ProtocolLabel from 'Activity/Queue/ProtocolLabel'; import EpisodeTitleLink from 'Album/EpisodeTitleLink'; import EpisodeQuality from 'Album/EpisodeQuality'; -import SeasonEpisodeNumber from 'Album/SeasonEpisodeNumber'; import InteractiveImportModal from 'InteractiveImport/InteractiveImportModal'; import ArtistNameLink from 'Artist/ArtistNameLink'; import QueueStatusCell from './QueueStatusCell'; diff --git a/frontend/src/AddArtist/ImportArtist/Import/ImportArtistConnector.js b/frontend/src/AddArtist/ImportArtist/Import/ImportArtistConnector.js index df7a9173a..1464ef557 100644 --- a/frontend/src/AddArtist/ImportArtist/Import/ImportArtistConnector.js +++ b/frontend/src/AddArtist/ImportArtist/Import/ImportArtistConnector.js @@ -1,3 +1,4 @@ +/* eslint max-params: 0 */ import _ from 'lodash'; import PropTypes from 'prop-types'; import React, { Component } from 'react'; diff --git a/frontend/src/Album/Summary/EpisodeAiring.js b/frontend/src/Album/Summary/EpisodeAiring.js index 4d3e10137..f80398a08 100644 --- a/frontend/src/Album/Summary/EpisodeAiring.js +++ b/frontend/src/Album/Summary/EpisodeAiring.js @@ -1,7 +1,6 @@ import moment from 'moment'; import PropTypes from 'prop-types'; import React from 'react'; -import formatTime from 'Utilities/Date/formatTime'; import isInNextWeek from 'Utilities/Date/isInNextWeek'; import isToday from 'Utilities/Date/isToday'; import isTomorrow from 'Utilities/Date/isTomorrow'; @@ -13,8 +12,7 @@ function EpisodeAiring(props) { releaseDate, albumLabel, shortDateFormat, - showRelativeDates, - timeFormat + showRelativeDates } = props; const networkLabel = ( @@ -77,8 +75,7 @@ EpisodeAiring.propTypes = { releaseDate: PropTypes.string.isRequired, albumLabel: PropTypes.arrayOf(PropTypes.string).isRequired, shortDateFormat: PropTypes.string.isRequired, - showRelativeDates: PropTypes.bool.isRequired, - timeFormat: PropTypes.string.isRequired + showRelativeDates: PropTypes.bool.isRequired }; export default EpisodeAiring; diff --git a/frontend/src/Album/Summary/EpisodeAiringConnector.js b/frontend/src/Album/Summary/EpisodeAiringConnector.js index 508467efb..4a731ced8 100644 --- a/frontend/src/Album/Summary/EpisodeAiringConnector.js +++ b/frontend/src/Album/Summary/EpisodeAiringConnector.js @@ -10,8 +10,7 @@ function createMapStateToProps() { (uiSettings) => { return _.pick(uiSettings, [ 'shortDateFormat', - 'showRelativeDates', - 'timeFormat' + 'showRelativeDates' ]); } ); diff --git a/frontend/src/Album/Summary/EpisodeSummary.js b/frontend/src/Album/Summary/EpisodeSummary.js index 4b82ec4af..28bcb45ae 100644 --- a/frontend/src/Album/Summary/EpisodeSummary.js +++ b/frontend/src/Album/Summary/EpisodeSummary.js @@ -1,12 +1,9 @@ import PropTypes from 'prop-types'; import React, { Component } from 'react'; -import formatBytes from 'Utilities/Number/formatBytes'; -import { icons, kinds, sizes } from 'Helpers/Props'; -import IconButton from 'Components/Link/IconButton'; +import { kinds, sizes } from 'Helpers/Props'; import ConfirmModal from 'Components/Modal/ConfirmModal'; import Label from 'Components/Label'; import QualityProfileNameConnector from 'Settings/Profiles/Quality/QualityProfileNameConnector'; -import EpisodeQuality from 'Album/EpisodeQuality'; import Table from 'Components/Table/Table'; import TableBody from 'Components/Table/TableBody'; import EpisodeAiringConnector from './EpisodeAiringConnector'; diff --git a/frontend/src/Album/Summary/EpisodeSummaryConnector.js b/frontend/src/Album/Summary/EpisodeSummaryConnector.js index eca8d0704..d2b95b047 100644 --- a/frontend/src/Album/Summary/EpisodeSummaryConnector.js +++ b/frontend/src/Album/Summary/EpisodeSummaryConnector.js @@ -14,14 +14,15 @@ function createMapStateToProps() { createEpisodeSelector(), createCommandsSelector(), createDimensionsSelector(), - (tracks, episode, commands, dimensions) => { + createArtistSelector(), + (tracks, episode, commands, dimensions, artist) => { const filteredItems = _.filter(tracks.items, { albumId: episode.id }); const mediumSortedItems = _.orderBy(filteredItems, 'absoluteTrackNumber'); const items = _.orderBy(mediumSortedItems, 'mediumNumber'); return { network: episode.label, - qualityProfileId: episode.profileId, + qualityProfileId: artist.qualityProfileId, releaseDate: episode.releaseDate, overview: episode.overview, items, diff --git a/frontend/src/AlbumStudio/AlbumStudioAlbum.js b/frontend/src/AlbumStudio/AlbumStudioAlbum.js index d1c9e393d..a1e96a4a2 100644 --- a/frontend/src/AlbumStudio/AlbumStudioAlbum.js +++ b/frontend/src/AlbumStudio/AlbumStudioAlbum.js @@ -1,7 +1,6 @@ import PropTypes from 'prop-types'; import React, { Component } from 'react'; import classNames from 'classnames'; -import padNumber from 'Utilities/Number/padNumber'; import MonitorToggleButton from 'Components/MonitorToggleButton'; import styles from './AlbumStudioAlbum.css'; diff --git a/frontend/src/Artist/Details/AlbumRow.js b/frontend/src/Artist/Details/AlbumRow.js index 8f27f9ed2..8f3a8df71 100644 --- a/frontend/src/Artist/Details/AlbumRow.js +++ b/frontend/src/Artist/Details/AlbumRow.js @@ -211,7 +211,6 @@ AlbumRow.propTypes = { artistMonitored: PropTypes.bool.isRequired, statistics: PropTypes.object.isRequired, mediaInfo: PropTypes.object, - alternateTitles: PropTypes.arrayOf(PropTypes.object).isRequired, columns: PropTypes.arrayOf(PropTypes.object).isRequired, onMonitorAlbumPress: PropTypes.func.isRequired }; diff --git a/frontend/src/Artist/Details/AlbumRowConnector.js b/frontend/src/Artist/Details/AlbumRowConnector.js index cff75e50f..c2260e773 100644 --- a/frontend/src/Artist/Details/AlbumRowConnector.js +++ b/frontend/src/Artist/Details/AlbumRowConnector.js @@ -14,13 +14,10 @@ function createMapStateToProps() { createTrackFileSelector(), createCommandsSelector(), (id, sceneSeasonNumber, artist, trackFile, commands) => { - const alternateTitles = sceneSeasonNumber ? _.filter(artist.alternateTitles, { sceneSeasonNumber }) : []; - return { artistMonitored: artist.monitored, trackFilePath: trackFile ? trackFile.path : null, - trackFileRelativePath: trackFile ? trackFile.relativePath : null, - alternateTitles + trackFileRelativePath: trackFile ? trackFile.relativePath : null }; } ); diff --git a/frontend/src/Artist/Details/ArtistDetails.js b/frontend/src/Artist/Details/ArtistDetails.js index d35b068ef..4c74532e2 100644 --- a/frontend/src/Artist/Details/ArtistDetails.js +++ b/frontend/src/Artist/Details/ArtistDetails.js @@ -187,7 +187,6 @@ class ArtistDetails extends Component { overview, links, images, - albums, alternateTitles, tags, isRefreshing, @@ -595,7 +594,6 @@ ArtistDetails.propTypes = { overview: PropTypes.string.isRequired, links: PropTypes.arrayOf(PropTypes.object).isRequired, images: PropTypes.arrayOf(PropTypes.object).isRequired, - albums: PropTypes.arrayOf(PropTypes.object).isRequired, alternateTitles: PropTypes.arrayOf(PropTypes.string).isRequired, tags: PropTypes.arrayOf(PropTypes.number).isRequired, isRefreshing: PropTypes.bool.isRequired, diff --git a/frontend/src/Artist/Details/ArtistDetailsConnector.js b/frontend/src/Artist/Details/ArtistDetailsConnector.js index 29efad73d..5a0c15a78 100644 --- a/frontend/src/Artist/Details/ArtistDetailsConnector.js +++ b/frontend/src/Artist/Details/ArtistDetailsConnector.js @@ -1,3 +1,4 @@ +/* eslint max-params: 0 */ import _ from 'lodash'; import PropTypes from 'prop-types'; import React, { Component } from 'react'; diff --git a/frontend/src/Artist/Details/ArtistDetailsLinks.js b/frontend/src/Artist/Details/ArtistDetailsLinks.js index 655b6b294..23941d06b 100644 --- a/frontend/src/Artist/Details/ArtistDetailsLinks.js +++ b/frontend/src/Artist/Details/ArtistDetailsLinks.js @@ -43,7 +43,7 @@ function ArtistDetailsLinks(props) { {(index > 0 && index % 5 === 0) && -

+
} diff --git a/frontend/src/Artist/Details/ArtistDetailsSeason.js b/frontend/src/Artist/Details/ArtistDetailsSeason.js index 1d4a762b3..c8f37dae6 100644 --- a/frontend/src/Artist/Details/ArtistDetailsSeason.js +++ b/frontend/src/Artist/Details/ArtistDetailsSeason.js @@ -2,18 +2,11 @@ import _ from 'lodash'; import PropTypes from 'prop-types'; import React, { Component } from 'react'; import isAfter from 'Utilities/Date/isAfter'; -import isBefore from 'Utilities/Date/isBefore'; import getToggledRange from 'Utilities/Table/getToggledRange'; -import { align, icons, kinds, sizes } from 'Helpers/Props'; +import { icons } from 'Helpers/Props'; import Icon from 'Components/Icon'; import IconButton from 'Components/Link/IconButton'; import Link from 'Components/Link/Link'; -import SpinnerIcon from 'Components/SpinnerIcon'; -import SpinnerIconButton from 'Components/Link/SpinnerIconButton'; -import Menu from 'Components/Menu/Menu'; -import MenuButton from 'Components/Menu/MenuButton'; -import MenuContent from 'Components/Menu/MenuContent'; -import MenuItem from 'Components/Menu/MenuItem'; import Table from 'Components/Table/Table'; import TableBody from 'Components/Table/TableBody'; import TrackFileEditorModal from 'TrackFile/Editor/TrackFileEditorModal'; @@ -119,13 +112,10 @@ class ArtistDetailsSeason extends Component { label, items, columns, - isSaving, isExpanded, - isSearching, artistMonitored, isSmallScreen, - onTableOptionChange, - onSearchPress + onTableOptionChange } = this.props; const { @@ -237,15 +227,12 @@ ArtistDetailsSeason.propTypes = { label: PropTypes.string.isRequired, items: PropTypes.arrayOf(PropTypes.object).isRequired, columns: PropTypes.arrayOf(PropTypes.object).isRequired, - isSaving: PropTypes.bool, isExpanded: PropTypes.bool, - isSearching: PropTypes.bool.isRequired, artistMonitored: PropTypes.bool.isRequired, isSmallScreen: PropTypes.bool.isRequired, onTableOptionChange: PropTypes.func.isRequired, onExpandPress: PropTypes.func.isRequired, - onMonitorAlbumPress: PropTypes.func.isRequired, - onSearchPress: PropTypes.func.isRequired + onMonitorAlbumPress: PropTypes.func.isRequired }; export default ArtistDetailsSeason; diff --git a/frontend/src/Artist/Details/ArtistDetailsSeasonConnector.js b/frontend/src/Artist/Details/ArtistDetailsSeasonConnector.js index df705b405..bc2bbd508 100644 --- a/frontend/src/Artist/Details/ArtistDetailsSeasonConnector.js +++ b/frontend/src/Artist/Details/ArtistDetailsSeasonConnector.js @@ -1,3 +1,4 @@ +/* eslint max-params: 0 */ import _ from 'lodash'; import PropTypes from 'prop-types'; import React, { Component } from 'react'; @@ -20,11 +21,6 @@ function createMapStateToProps() { createCommandsSelector(), createDimensionsSelector(), (label, episodes, artist, commands, dimensions) => { - const isSearching = !!findCommand(commands, { - name: commandNames.SEASON_SEARCH, - artistId: artist.id, - label - }); const episodesInSeason = _.filter(episodes.items, { albumType: label }); const sortedEpisodes = _.orderBy(episodesInSeason, 'releaseDate', 'desc'); @@ -32,7 +28,6 @@ function createMapStateToProps() { return { items: sortedEpisodes, columns: episodes.columns, - isSearching, artistMonitored: artist.monitored, isSmallScreen: dimensions.isSmallScreen }; @@ -55,17 +50,6 @@ class ArtistDetailsSeasonConnector extends Component { this.props.setEpisodesTableOption(payload); } - onSearchPress = () => { - const { - artistId - } = this.props; - - this.props.executeCommand({ - name: commandNames.SEASON_SEARCH, - artistId - }); - } - onMonitorAlbumPress = (albumIds, monitored) => { this.props.toggleEpisodesMonitored({ albumIds, @@ -81,8 +65,6 @@ class ArtistDetailsSeasonConnector extends Component { ); diff --git a/frontend/src/Artist/Editor/ArtistEditorRow.js b/frontend/src/Artist/Editor/ArtistEditorRow.js index b543e9600..278802e40 100644 --- a/frontend/src/Artist/Editor/ArtistEditorRow.js +++ b/frontend/src/Artist/Editor/ArtistEditorRow.js @@ -1,7 +1,6 @@ import _ from 'lodash'; import PropTypes from 'prop-types'; import React, { Component } from 'react'; -import titleCase from 'Utilities/String/titleCase'; import TagListConnector from 'Components/TagListConnector'; import CheckInput from 'Components/Form/CheckInput'; import TableRow from 'Components/Table/TableRow'; diff --git a/frontend/src/Artist/Index/ArtistIndexConnector.js b/frontend/src/Artist/Index/ArtistIndexConnector.js index 688852942..fecc0b4da 100644 --- a/frontend/src/Artist/Index/ArtistIndexConnector.js +++ b/frontend/src/Artist/Index/ArtistIndexConnector.js @@ -1,3 +1,4 @@ +/* eslint max-params: 0 */ import PropTypes from 'prop-types'; import React, { Component } from 'react'; import { connect } from 'react-redux'; diff --git a/frontend/src/Artist/Index/ArtistIndexItemConnector.js b/frontend/src/Artist/Index/ArtistIndexItemConnector.js index 2e60088fe..f0dc116b4 100644 --- a/frontend/src/Artist/Index/ArtistIndexItemConnector.js +++ b/frontend/src/Artist/Index/ArtistIndexItemConnector.js @@ -1,3 +1,4 @@ +/* eslint max-params: 0 */ import _ from 'lodash'; import PropTypes from 'prop-types'; import React, { Component } from 'react'; diff --git a/frontend/src/Artist/Index/Overview/ArtistIndexOverviewInfo.js b/frontend/src/Artist/Index/Overview/ArtistIndexOverviewInfo.js index 31a114e70..4f7ce8ec9 100644 --- a/frontend/src/Artist/Index/Overview/ArtistIndexOverviewInfo.js +++ b/frontend/src/Artist/Index/Overview/ArtistIndexOverviewInfo.js @@ -1,3 +1,4 @@ +/* eslint max-params: 0 */ import PropTypes from 'prop-types'; import React from 'react'; import getRelativeDate from 'Utilities/Date/getRelativeDate'; diff --git a/frontend/src/Artist/Index/Posters/ArtistIndexPosters.js b/frontend/src/Artist/Index/Posters/ArtistIndexPosters.js index 9f870a55b..2b9f59846 100644 --- a/frontend/src/Artist/Index/Posters/ArtistIndexPosters.js +++ b/frontend/src/Artist/Index/Posters/ArtistIndexPosters.js @@ -300,7 +300,7 @@ class ArtistIndexPosters extends Component { /> ); } - } + } ); diff --git a/frontend/src/Calendar/Agenda/AgendaEvent.js b/frontend/src/Calendar/Agenda/AgendaEvent.js index 44fac0a88..4743f44df 100644 --- a/frontend/src/Calendar/Agenda/AgendaEvent.js +++ b/frontend/src/Calendar/Agenda/AgendaEvent.js @@ -3,7 +3,6 @@ import PropTypes from 'prop-types'; import React, { Component } from 'react'; import classNames from 'classnames'; import formatTime from 'Utilities/Date/formatTime'; -import padNumber from 'Utilities/Number/padNumber'; import { icons } from 'Helpers/Props'; import getStatusStyle from 'Calendar/getStatusStyle'; import Icon from 'Components/Icon'; diff --git a/frontend/src/Calendar/Day/CalendarDay.js b/frontend/src/Calendar/Day/CalendarDay.js index 214c13ba5..bd196cc5d 100644 --- a/frontend/src/Calendar/Day/CalendarDay.js +++ b/frontend/src/Calendar/Day/CalendarDay.js @@ -28,7 +28,8 @@ function CalendarDay(props) { styles.dayOfMonth, isTodaysDate && styles.isToday, !moment(date).isSame(moment(time), 'month') && styles.isDifferentMonth - )}> + )} + > {moment(date).date()} } diff --git a/frontend/src/Calendar/Events/CalendarEvent.js b/frontend/src/Calendar/Events/CalendarEvent.js index 8e914cc0d..a9bfda8de 100644 --- a/frontend/src/Calendar/Events/CalendarEvent.js +++ b/frontend/src/Calendar/Events/CalendarEvent.js @@ -3,8 +3,6 @@ import PropTypes from 'prop-types'; import React, { Component } from 'react'; import classNames from 'classnames'; import { icons } from 'Helpers/Props'; -import formatTime from 'Utilities/Date/formatTime'; -import padNumber from 'Utilities/Number/padNumber'; import getStatusStyle from 'Calendar/getStatusStyle'; import episodeEntities from 'Album/episodeEntities'; import Icon from 'Components/Icon'; diff --git a/frontend/src/Calendar/Header/CalendarHeader.js b/frontend/src/Calendar/Header/CalendarHeader.js index 4fea8356d..a87938639 100644 --- a/frontend/src/Calendar/Header/CalendarHeader.js +++ b/frontend/src/Calendar/Header/CalendarHeader.js @@ -1,3 +1,4 @@ +/* eslint max-params: 0 */ import moment from 'moment'; import PropTypes from 'prop-types'; import React, { Component } from 'react'; diff --git a/frontend/src/Components/Page/Header/PageHeader.js b/frontend/src/Components/Page/Header/PageHeader.js index 02ad59887..a8bceda5c 100644 --- a/frontend/src/Components/Page/Header/PageHeader.js +++ b/frontend/src/Components/Page/Header/PageHeader.js @@ -59,7 +59,6 @@ class PageHeader extends Component { -
{ - advancedSettings && -
- - Metadata Source + advancedSettings && +
+ + Metadata Source - - -
+ + +
} } diff --git a/frontend/src/Settings/Profiles/Delay/DelayProfileDragPreview.js b/frontend/src/Settings/Profiles/Delay/DelayProfileDragPreview.js index 402ddcc13..0cc47c7e4 100644 --- a/frontend/src/Settings/Profiles/Delay/DelayProfileDragPreview.js +++ b/frontend/src/Settings/Profiles/Delay/DelayProfileDragPreview.js @@ -75,4 +75,7 @@ DelayProfileDragPreview.propTypes = { }) }; +/* eslint-disable new-cap */ export default DragLayer(collectDragLayer)(DelayProfileDragPreview); +/* eslint-enable new-cap */ + diff --git a/frontend/src/Settings/Profiles/Delay/DelayProfileDragSource.js b/frontend/src/Settings/Profiles/Delay/DelayProfileDragSource.js index 5c1c565e0..4661cb5a1 100644 --- a/frontend/src/Settings/Profiles/Delay/DelayProfileDragSource.js +++ b/frontend/src/Settings/Profiles/Delay/DelayProfileDragSource.js @@ -137,6 +137,7 @@ DelayProfileDragSource.propTypes = { onDelayProfileDragEnd: PropTypes.func.isRequired }; +/* eslint-disable new-cap */ export default DropTarget( DELAY_PROFILE, delayProfileDropTarget, @@ -146,3 +147,4 @@ export default DropTarget( delayProfileDragSource, collectDragSource )(DelayProfileDragSource)); +/* eslint-enable new-cap */ diff --git a/frontend/src/Settings/Profiles/Language/LanguageProfileItemDragPreview.js b/frontend/src/Settings/Profiles/Language/LanguageProfileItemDragPreview.js index ded14b39d..b7a08d89b 100644 --- a/frontend/src/Settings/Profiles/Language/LanguageProfileItemDragPreview.js +++ b/frontend/src/Settings/Profiles/Language/LanguageProfileItemDragPreview.js @@ -85,4 +85,6 @@ LanguageProfileItemDragPreview.propTypes = { }) }; +/* eslint-disable new-cap */ export default DragLayer(collectDragLayer)(LanguageProfileItemDragPreview); +/* eslint-enable new-cap */ diff --git a/frontend/src/Settings/Profiles/Language/LanguageProfileItemDragSource.js b/frontend/src/Settings/Profiles/Language/LanguageProfileItemDragSource.js index 304363726..c154960a8 100644 --- a/frontend/src/Settings/Profiles/Language/LanguageProfileItemDragSource.js +++ b/frontend/src/Settings/Profiles/Language/LanguageProfileItemDragSource.js @@ -146,6 +146,7 @@ LanguageProfileItemDragSource.propTypes = { onLanguageProfileItemDragEnd: PropTypes.func.isRequired }; +/* eslint-disable new-cap */ export default DropTarget( QUALITY_PROFILE_ITEM, languageProfileItemDropTarget, @@ -155,3 +156,4 @@ export default DropTarget( languageProfileItemDragSource, collectDragSource )(LanguageProfileItemDragSource)); +/* eslint-enable new-cap */ diff --git a/frontend/src/Settings/Profiles/Profiles.js b/frontend/src/Settings/Profiles/Profiles.js index 1534d7a15..d89f0b449 100644 --- a/frontend/src/Settings/Profiles/Profiles.js +++ b/frontend/src/Settings/Profiles/Profiles.js @@ -34,5 +34,6 @@ class Profiles extends Component { // Only a single DragDropContext can exist so it's done here to allow editing // quality profiles and reordering delay profiles to work. - +/* eslint-disable new-cap */ export default DragDropContext(HTML5Backend)(Profiles); +/* eslint-enable new-cap */ diff --git a/frontend/src/Settings/Profiles/Quality/QualityProfileItemDragPreview.js b/frontend/src/Settings/Profiles/Quality/QualityProfileItemDragPreview.js index e0c6e8e8c..ac1b3ab80 100644 --- a/frontend/src/Settings/Profiles/Quality/QualityProfileItemDragPreview.js +++ b/frontend/src/Settings/Profiles/Quality/QualityProfileItemDragPreview.js @@ -89,4 +89,6 @@ QualityProfileItemDragPreview.propTypes = { }) }; +/* eslint-disable new-cap */ export default DragLayer(collectDragLayer)(QualityProfileItemDragPreview); +/* eslint-enable new-cap */ diff --git a/frontend/src/Settings/Profiles/Quality/QualityProfileItemDragSource.js b/frontend/src/Settings/Profiles/Quality/QualityProfileItemDragSource.js index 0e1838eb3..a775ab427 100644 --- a/frontend/src/Settings/Profiles/Quality/QualityProfileItemDragSource.js +++ b/frontend/src/Settings/Profiles/Quality/QualityProfileItemDragSource.js @@ -230,6 +230,7 @@ QualityProfileItemDragSource.propTypes = { onQualityProfileItemDragEnd: PropTypes.func.isRequired }; +/* eslint-disable new-cap */ export default DropTarget( QUALITY_PROFILE_ITEM, qualityProfileItemDropTarget, @@ -239,3 +240,5 @@ export default DropTarget( qualityProfileItemDragSource, collectDragSource )(QualityProfileItemDragSource)); +/* eslint-enable new-cap */ + diff --git a/frontend/src/Store/Actions/Creators/createToggleAlbumMonitoredHandler.js b/frontend/src/Store/Actions/Creators/createToggleAlbumMonitoredHandler.js index 79e6326ca..309aec0aa 100644 --- a/frontend/src/Store/Actions/Creators/createToggleAlbumMonitoredHandler.js +++ b/frontend/src/Store/Actions/Creators/createToggleAlbumMonitoredHandler.js @@ -11,7 +11,7 @@ function createToggleAlbumMonitoredHandler(section) { } = payload; const state = getSectionState(getState(), section, true); - + updateAlbums(dispatch, section, state.items, [albumId], { isSaving: true }); diff --git a/frontend/src/Store/connectSection.js b/frontend/src/Store/connectSection.js index 5d309cc5e..0158cc4de 100644 --- a/frontend/src/Store/connectSection.js +++ b/frontend/src/Store/connectSection.js @@ -1,3 +1,4 @@ +/* eslint max-params: 0 */ import React, { Component } from 'react'; import { connect } from 'react-redux'; import getDisplayName from 'Helpers/getDisplayName'; diff --git a/frontend/src/TrackFile/Editor/TrackFileEditorModalContentConnector.js b/frontend/src/TrackFile/Editor/TrackFileEditorModalContentConnector.js index e60ac423f..0adf154e8 100644 --- a/frontend/src/TrackFile/Editor/TrackFileEditorModalContentConnector.js +++ b/frontend/src/TrackFile/Editor/TrackFileEditorModalContentConnector.js @@ -54,7 +54,7 @@ function createMapStateToProps() { const languages = _.map(languageProfilesSchema.languages, 'language'); const qualities = getQualities(qualityProfileSchema.items); - + return { items, artistType: artist.artistType, diff --git a/frontend/src/TrackFile/Editor/TrackFileEditorRow.js b/frontend/src/TrackFile/Editor/TrackFileEditorRow.js index 4683735ee..19628a2f8 100644 --- a/frontend/src/TrackFile/Editor/TrackFileEditorRow.js +++ b/frontend/src/TrackFile/Editor/TrackFileEditorRow.js @@ -2,7 +2,6 @@ import PropTypes from 'prop-types'; import React from 'react'; import padNumber from 'Utilities/Number/padNumber'; import Label from 'Components/Label'; -import RelativeDateCellConnector from 'Components/Table/Cells/RelativeDateCellConnector'; import TableRow from 'Components/Table/TableRow'; import TableRowCell from 'Components/Table/Cells/TableRowCell'; import TableSelectCell from 'Components/Table/Cells/TableSelectCell'; diff --git a/frontend/src/Utilities/Album/updateAlbums.js b/frontend/src/Utilities/Album/updateAlbums.js index 16d800de9..d850a0485 100644 --- a/frontend/src/Utilities/Album/updateAlbums.js +++ b/frontend/src/Utilities/Album/updateAlbums.js @@ -1,3 +1,4 @@ +/* eslint max-params: 0 */ import _ from 'lodash'; import { update } from 'Store/Actions/baseActions'; diff --git a/frontend/src/Utilities/Table/toggleSelected.js b/frontend/src/Utilities/Table/toggleSelected.js index 4b19dc268..8b263120d 100644 --- a/frontend/src/Utilities/Table/toggleSelected.js +++ b/frontend/src/Utilities/Table/toggleSelected.js @@ -1,3 +1,4 @@ +/* eslint max-params: 0 */ import areAllSelected from './areAllSelected'; import getToggledRange from './getToggledRange'; diff --git a/frontend/src/Wanted/Missing/MissingRow.js b/frontend/src/Wanted/Missing/MissingRow.js index 16c78da4e..78eb16b55 100644 --- a/frontend/src/Wanted/Missing/MissingRow.js +++ b/frontend/src/Wanted/Missing/MissingRow.js @@ -3,7 +3,6 @@ import React from 'react'; import episodeEntities from 'Album/episodeEntities'; import EpisodeTitleLink from 'Album/EpisodeTitleLink'; import EpisodeStatusConnector from 'Album/EpisodeStatusConnector'; -import SeasonEpisodeNumber from 'Album/SeasonEpisodeNumber'; import EpisodeSearchCellConnector from 'Album/EpisodeSearchCellConnector'; import ArtistNameLink from 'Artist/ArtistNameLink'; import RelativeDateCellConnector from 'Components/Table/Cells/RelativeDateCellConnector';