From 93bdac31ea7bd43d7de7030a8bf11d8880e40a0a Mon Sep 17 00:00:00 2001 From: geogolem Date: Fri, 3 Mar 2017 09:27:54 -0500 Subject: [PATCH] clean up the fetching on loading of MovieEditor and MovieIndex once and for all --- src/UI/Movies/Editor/MovieEditorLayout.js | 20 +++++++++++--------- src/UI/Movies/Index/MoviesIndexLayout.js | 3 ++- src/UI/Movies/MoviesCollectionClient.js | 6 ------ 3 files changed, 13 insertions(+), 16 deletions(-) delete mode 100644 src/UI/Movies/MoviesCollectionClient.js diff --git a/src/UI/Movies/Editor/MovieEditorLayout.js b/src/UI/Movies/Editor/MovieEditorLayout.js index 278b85399..cc78a0cce 100644 --- a/src/UI/Movies/Editor/MovieEditorLayout.js +++ b/src/UI/Movies/Editor/MovieEditorLayout.js @@ -3,7 +3,7 @@ var Marionette = require('marionette'); var Backgrid = require('backgrid'); var EmptyView = require('../Index/EmptyView'); var FullMovieCollection = require ('../FullMovieCollection'); -var MoviesCollection = require('../MoviesCollectionClient'); +var MoviesCollection = require('../MoviesCollection'); var MovieTitleCell = require('../../Cells/MovieTitleCell'); var DownloadedQualityCell = require('../../Cells/DownloadedQualityCell'); var ProfileCell = require('../../Cells/ProfileCell'); @@ -81,7 +81,8 @@ module.exports = Marionette.Layout.extend({ }, initialize : function() { - this.movieCollection = MoviesCollection; + this.movieCollection = MoviesCollection.clone(); + this.movieCollection.switchMode('client'); this.movieCollection.bindSignalR(); this.movieCollection.fullCollection.bindSignalR(); @@ -94,6 +95,7 @@ module.exports = Marionette.Layout.extend({ this._showToolbar(); this._showTable(); this._showPager(); + window.shownOnce = true; }); this.listenTo(this.movieCollection.fullCollection, 'sync', function() { @@ -156,13 +158,13 @@ module.exports = Marionette.Layout.extend({ }, onRender : function() { - this._showToolbar(); - this._showTable(); - this._showPager(); - if (window.shownOnce){ - this.movieCollection.fetch(); - } - window.shownOnce = true; + //this._showToolbar(); + //this._showTable(); + //this._showPager(); + //if (window.shownOnce){ + // this.movieCollection.fetch(); + //} + //window.shownOnce = true; }, onClose : function() { diff --git a/src/UI/Movies/Index/MoviesIndexLayout.js b/src/UI/Movies/Index/MoviesIndexLayout.js index 5583c68de..07002f0fd 100644 --- a/src/UI/Movies/Index/MoviesIndexLayout.js +++ b/src/UI/Movies/Index/MoviesIndexLayout.js @@ -292,8 +292,9 @@ module.exports = Marionette.Layout.extend({ onShow : function() { this._showToolbar(); - this._fetchCollection(); + //this._fetchCollection(); if (window.shownOnce) { + this._fetchCollection(); this._showFooter(); } window.shownOnce = true; diff --git a/src/UI/Movies/MoviesCollectionClient.js b/src/UI/Movies/MoviesCollectionClient.js deleted file mode 100644 index 5bcec70e0..000000000 --- a/src/UI/Movies/MoviesCollectionClient.js +++ /dev/null @@ -1,6 +0,0 @@ -var movieCollection = require('./MoviesCollection'); - -var ClientCollection = movieCollection.clone(); -ClientCollection.bindSignalR(); -ClientCollection.switchMode('client'); //state.pageSize = 100000; -module.exports = ClientCollection;