From d0c92fabfe2a3d15624fde8c1bf08044e682dd84 Mon Sep 17 00:00:00 2001 From: Mark McDowall Date: Sat, 20 Feb 2021 18:01:45 -0800 Subject: [PATCH] Fixed: Queue refresh closing manual import from queue if items change Fixes #2039 --- frontend/src/Activity/Queue/Queue.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/frontend/src/Activity/Queue/Queue.js b/frontend/src/Activity/Queue/Queue.js index 1a7bd1df5..c371047f9 100644 --- a/frontend/src/Activity/Queue/Queue.js +++ b/frontend/src/Activity/Queue/Queue.js @@ -44,12 +44,8 @@ class Queue extends Component { }; } - shouldComponentUpdate(nextProps) { - if (!this._shouldBlockRefresh) { - return true; - } - - if (hasDifferentItems(this.props.items, nextProps.items)) { + shouldComponentUpdate() { + if (this._shouldBlockRefresh) { return false; } @@ -122,14 +118,14 @@ class Queue extends Component { } onRemoveSelectedConfirmed = (payload) => { + this._shouldBlockRefresh = false; this.props.onRemoveSelectedPress({ ids: this.getSelectedIds(), ...payload }); this.setState({ isConfirmRemoveModalOpen: false }); - this._shouldBlockRefresh = false; } onConfirmRemoveModalClose = () => { - this.setState({ isConfirmRemoveModalOpen: false }); this._shouldBlockRefresh = false; + this.setState({ isConfirmRemoveModalOpen: false }); } //