From e31f2ad2536fd0ab868a9a22f3bf0c2c0b8a37f4 Mon Sep 17 00:00:00 2001
From: Bogdan <mynameisbogdan@users.noreply.github.com>
Date: Sun, 30 Jun 2024 05:35:37 +0300
Subject: [PATCH] Fixed: Validate metadata and quality profiles for root
 folders

Don't allow `0` as possible value for metadata and quality profiles, and permit to edit root folders with bad values in UI.
---
 .../ImportLists/Manage/ManageImportListsModalRow.tsx      | 5 +++--
 .../src/Settings/MediaManagement/RootFolder/RootFolder.js | 8 ++++----
 src/Lidarr.Api.V1/RootFolders/RootFolderController.cs     | 6 ++++--
 .../Validation/QualityProfileExistsValidator.cs           | 8 ++++----
 4 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/frontend/src/Settings/ImportLists/ImportLists/Manage/ManageImportListsModalRow.tsx b/frontend/src/Settings/ImportLists/ImportLists/Manage/ManageImportListsModalRow.tsx
index 410e626e2..095ac7c03 100644
--- a/frontend/src/Settings/ImportLists/ImportLists/Manage/ManageImportListsModalRow.tsx
+++ b/frontend/src/Settings/ImportLists/ImportLists/Manage/ManageImportListsModalRow.tsx
@@ -7,6 +7,7 @@ import TableRow from 'Components/Table/TableRow';
 import TagListConnector from 'Components/TagListConnector';
 import { createQualityProfileSelectorForHook } from 'Store/Selectors/createQualityProfileSelector';
 import { SelectStateInputProps } from 'typings/props';
+import translate from 'Utilities/String/translate';
 import styles from './ManageImportListsModalRow.css';
 
 interface ManageImportListsModalRowProps {
@@ -63,7 +64,7 @@ function ManageImportListsModalRow(props: ManageImportListsModalRowProps) {
       </TableRowCell>
 
       <TableRowCell className={styles.qualityProfileId}>
-        {qualityProfile?.name ?? 'None'}
+        {qualityProfile?.name ?? translate('None')}
       </TableRowCell>
 
       <TableRowCell className={styles.rootFolderPath}>
@@ -71,7 +72,7 @@ function ManageImportListsModalRow(props: ManageImportListsModalRowProps) {
       </TableRowCell>
 
       <TableRowCell className={styles.enableAutomaticAdd}>
-        {enableAutomaticAdd ? 'Yes' : 'No'}
+        {enableAutomaticAdd ? translate('Yes') : translate('No')}
       </TableRowCell>
 
       <TableRowCell className={styles.tags}>
diff --git a/frontend/src/Settings/MediaManagement/RootFolder/RootFolder.js b/frontend/src/Settings/MediaManagement/RootFolder/RootFolder.js
index 20cefc53f..47e5dfcf1 100644
--- a/frontend/src/Settings/MediaManagement/RootFolder/RootFolder.js
+++ b/frontend/src/Settings/MediaManagement/RootFolder/RootFolder.js
@@ -75,12 +75,12 @@ class RootFolder extends Component {
             {path}
           </Label>
 
-          <Label kind={kinds.SUCCESS}>
-            {qualityProfile.name}
+          <Label kind={qualityProfile?.name ? kinds.SUCCESS : kinds.DANGER}>
+            {qualityProfile?.name || translate('None')}
           </Label>
 
-          <Label kind={kinds.SUCCESS}>
-            {metadataProfile.name}
+          <Label kind={metadataProfile?.name ? kinds.SUCCESS : kinds.DANGER}>
+            {metadataProfile?.name || translate('None')}
           </Label>
         </div>
 
diff --git a/src/Lidarr.Api.V1/RootFolders/RootFolderController.cs b/src/Lidarr.Api.V1/RootFolders/RootFolderController.cs
index bce093c6f..1fdd9b5df 100644
--- a/src/Lidarr.Api.V1/RootFolders/RootFolderController.cs
+++ b/src/Lidarr.Api.V1/RootFolders/RootFolderController.cs
@@ -48,10 +48,12 @@ namespace Lidarr.Api.V1.RootFolders
             SharedValidator.RuleFor(c => c.Name)
                 .NotEmpty();
 
-            SharedValidator.RuleFor(c => c.DefaultMetadataProfileId)
+            SharedValidator.RuleFor(c => c.DefaultMetadataProfileId).Cascade(CascadeMode.Stop)
+                .ValidId()
                 .SetValidator(metadataProfileExistsValidator);
 
-            SharedValidator.RuleFor(c => c.DefaultQualityProfileId)
+            SharedValidator.RuleFor(c => c.DefaultQualityProfileId).Cascade(CascadeMode.Stop)
+                .ValidId()
                 .SetValidator(qualityProfileExistsValidator);
         }
 
diff --git a/src/NzbDrone.Core/Validation/QualityProfileExistsValidator.cs b/src/NzbDrone.Core/Validation/QualityProfileExistsValidator.cs
index 7505684c7..6efb72c32 100644
--- a/src/NzbDrone.Core/Validation/QualityProfileExistsValidator.cs
+++ b/src/NzbDrone.Core/Validation/QualityProfileExistsValidator.cs
@@ -5,11 +5,11 @@ namespace NzbDrone.Core.Validation
 {
     public class QualityProfileExistsValidator : PropertyValidator
     {
-        private readonly IQualityProfileService _profileService;
+        private readonly IQualityProfileService _qualityProfileService;
 
-        public QualityProfileExistsValidator(IQualityProfileService profileService)
+        public QualityProfileExistsValidator(IQualityProfileService qualityProfileService)
         {
-            _profileService = profileService;
+            _qualityProfileService = qualityProfileService;
         }
 
         protected override string GetDefaultMessageTemplate() => "Quality Profile does not exist";
@@ -21,7 +21,7 @@ namespace NzbDrone.Core.Validation
                 return true;
             }
 
-            return _profileService.Exists((int)context.PropertyValue);
+            return _qualityProfileService.Exists((int)context.PropertyValue);
         }
     }
 }