Initial quality is only setup if no other quality profiles exists.

NzbDrone.Core.Test/QualityProfileTest.cs

@@ -1,6 +1,7 @@
 // ReSharper disable RedundantUsingDirective
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using AutoMoq;
 using FizzWare.NBuilder;
 using FluentAssertions;
@@ -73,7 +74,7 @@ namespace NzbDrone.Core.Test
             var mocker = new AutoMoqer();
             var db = MockLib.GetEmptyDatabase();
             mocker.SetConstant(db);
-           
+
             var testProfile = new QualityProfile
             {
                 Name = Guid.NewGuid().ToString(),
@@ -95,7 +96,7 @@ namespace NzbDrone.Core.Test
             updated.Name.Should().Be(currentProfile.Name);
             updated.Cutoff.Should().Be(QualityTypes.Bluray720p);
             updated.AllowedString.Should().Be(currentProfile.AllowedString);
-   
+
         }
 
         [Test]
@@ -127,5 +128,47 @@ namespace NzbDrone.Core.Test
             Assert.AreEqual(profileId, result[0].QualityProfileId);
             Assert.AreEqual(testProfile.Name, profile.Name);
         }
+
+
+        [Test]
+        public void SetupInitial_should_add_two_profiles()
+        {
+            var mocker = new AutoMoqer();
+            var db = MockLib.GetEmptyDatabase();
+            mocker.SetConstant(db);
+
+            //Act
+            mocker.Resolve<QualityProvider>().SetupDefaultProfiles();
+
+            //Assert
+            var profiles = mocker.Resolve<QualityProvider>().GetAllProfiles();
+
+
+            profiles.Should().HaveCount(2);
+            profiles.Should().Contain(e => e.Name == "HD");
+            profiles.Should().Contain(e => e.Name == "SD");
+
+        }
+
+        [Test]
+        //This confirms that new profiles are added only if no other profiles exists.
+        //We don't want to keep adding them back if a user deleted them on purpose.
+        public void SetupInitial_should_skip_if_any_profile_exists()
+        {
+            var mocker = new AutoMoqer();
+            var db = MockLib.GetEmptyDatabase();
+            mocker.SetConstant(db);
+            var fakeProfile = Builder<QualityProfile>.CreateNew().Build();
+
+            //Act
+            mocker.Resolve<QualityProvider>().Add(fakeProfile);
+            mocker.Resolve<QualityProvider>().SetupDefaultProfiles();
+
+            //Assert
+            var profiles = mocker.Resolve<QualityProvider>().GetAllProfiles();
+
+
+            profiles.Should().HaveCount(1);
+        }
     }
 }

NzbDrone.Core/Providers/QualityProvider.cs

@@ -58,9 +58,10 @@ namespace NzbDrone.Core.Providers
 
         public virtual void SetupDefaultProfiles()
         {
-            Logger.Info("Setting up default quality profiles");
+            if (GetAllProfiles().Count != 0)
+                return;
 
-            var profiles = GetAllProfiles();
+            Logger.Info("Setting up default quality profiles");
 
             var sd = new QualityProfile { Name = "SD", Allowed = new List<QualityTypes> { QualityTypes.SDTV, QualityTypes.DVD }, Cutoff = QualityTypes.SDTV };
 
@@ -71,23 +72,9 @@ namespace NzbDrone.Core.Providers
                 Cutoff = QualityTypes.HDTV
             };
 
-            //Add or Update SD
-            Logger.Debug(String.Format("Checking for default QualityProfile: {0}", sd.Name));
-            var sdDb = profiles.Where(p => p.Name == sd.Name).FirstOrDefault();
-            if (sdDb == null)
-            {
-                Logger.Debug(String.Format("Adding new default QualityProfile: {0}", sd.Name));
-                Add(sd);
-            }
+            Add(sd);
+            Add(hd);
 
-            //Add or Update HD
-            Logger.Debug(String.Format("Checking for default QualityProfile: {0}", hd.Name));
-            var hdDb = profiles.Where(p => p.Name == hd.Name).FirstOrDefault();
-            if (hdDb == null)
-            {
-                Logger.Debug(String.Format("Adding new default QualityProfile: {0}", hd.Name));
-                Add(hd);
-            }
         }
     }
 }