Fixed: Regression preventing new downloads from bypassing the Download Client Back-off logic

src/NzbDrone.Core.Test/Download/DownloadServiceFixture.cs

@@ -204,18 +204,26 @@ namespace NzbDrone.Core.Test.Download
         }
 
         [Test]
-        public void should_not_attempt_download_if_client_is_disabled()
+        public void should_attempt_download_even_if_client_is_disabled()
         {
-            WithUsenetClient();
+            var mockUsenet = WithUsenetClient();
 
             Mocker.GetMock<IDownloadClientStatusService>()
-                  .Setup(v => v.IsDisabled(It.IsAny<int>()))
-                  .Returns(true);
+                    .Setup(v => v.GetBlockedProviders())
+                    .Returns(new List<DownloadClientStatus>
+                    {
+                        new DownloadClientStatus
+                        {
+                            ProviderId = _downloadClients.First().Definition.Id,
+                            DisabledTill = DateTime.UtcNow.AddHours(3)
+                        }
+                    });
 
-            Assert.Throws<DownloadClientUnavailableException>(() => Subject.DownloadReport(_parseResult));
+            Subject.DownloadReport(_parseResult);
 
-            Mocker.GetMock<IDownloadClient>().Verify(c => c.Download(It.IsAny<RemoteAlbum>()), Times.Never());
-            VerifyEventNotPublished<AlbumGrabbedEvent>();
+            Mocker.GetMock<IDownloadClientStatusService>().Verify(c => c.GetBlockedProviders(), Times.Never());
+            mockUsenet.Verify(c => c.Download(It.IsAny<RemoteAlbum>()), Times.Once());
+            VerifyEventPublished<AlbumGrabbedEvent>();
         }
 
         [Test]

src/NzbDrone.Core/Download/DownloadService.cs

@@ -55,11 +55,6 @@ namespace NzbDrone.Core.Download
                 throw new DownloadClientUnavailableException($"{remoteAlbum.Release.DownloadProtocol} Download client isn't configured yet");
             }
 
-            if (_downloadClientStatusService.IsDisabled(downloadClient.Definition.Id))
-            {
-                throw new DownloadClientUnavailableException($"{downloadClient.Name} is disabled due to recent failues");
-            }
-
             // Limit grabs to 2 per second.
             if (remoteAlbum.Release.DownloadUrl.IsNotNullOrWhiteSpace() && !remoteAlbum.Release.DownloadUrl.StartsWith("magnet:"))
             {

src/NzbDrone.Core/ThingiProvider/Status/ProviderStatusServiceBase.cs

@@ -10,7 +10,6 @@ namespace NzbDrone.Core.ThingiProvider.Status
     public interface IProviderStatusServiceBase<TModel>
         where TModel : ProviderStatusBase, new()
     {
-        bool IsDisabled(int providerId);
         List<TModel> GetBlockedProviders();
         void RecordSuccess(int providerId);
         void RecordFailure(int providerId, TimeSpan minimumBackOff = default(TimeSpan));
@@ -38,11 +37,6 @@ namespace NzbDrone.Core.ThingiProvider.Status
             _logger = logger;
         }
 
-        public bool IsDisabled(int providerId)
-        {
-            return GetProviderStatus(providerId).IsDisabled();
-        }
-
         public virtual List<TModel> GetBlockedProviders()
         {
             return _providerStatusRepository.All().Where(v => v.IsDisabled()).ToList();