From f25bfe9d28958e2e7362e607a46caa132155b801 Mon Sep 17 00:00:00 2001 From: Keivan Beigi Date: Fri, 20 Jan 2017 20:33:10 -0800 Subject: [PATCH] don't log migrations during regular DB tests --- src/NzbDrone.Core.Test/Framework/DbTest.cs | 1 - src/NzbDrone.Core.Test/Framework/MigrationTest.cs | 8 +++----- .../Migration/Framework/NzbDroneMigrationBase.cs | 1 - 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/NzbDrone.Core.Test/Framework/DbTest.cs b/src/NzbDrone.Core.Test/Framework/DbTest.cs index 342bc6bcc..7ae33e059 100644 --- a/src/NzbDrone.Core.Test/Framework/DbTest.cs +++ b/src/NzbDrone.Core.Test/Framework/DbTest.cs @@ -99,7 +99,6 @@ namespace NzbDrone.Core.Test.Framework { WithTempAsAppPath(); - Mocker.SetConstant(Mocker.Resolve()); Mocker.SetConstant(Mocker.Resolve()); Mocker.SetConstant(Mocker.Resolve()); diff --git a/src/NzbDrone.Core.Test/Framework/MigrationTest.cs b/src/NzbDrone.Core.Test/Framework/MigrationTest.cs index 1cdc43445..4e538546e 100644 --- a/src/NzbDrone.Core.Test/Framework/MigrationTest.cs +++ b/src/NzbDrone.Core.Test/Framework/MigrationTest.cs @@ -1,8 +1,8 @@ using System; using FluentMigrator; +using FluentMigrator.Runner; using NUnit.Framework; using NzbDrone.Core.Datastore.Migration.Framework; -using NzbDrone.Test.Common.AutoMoq; namespace NzbDrone.Core.Test.Framework { @@ -26,7 +26,7 @@ namespace NzbDrone.Core.Test.Framework BeforeMigration = m => { var migration = m as TMigration; - if (beforeMigration != null && migration is TMigration) + if (beforeMigration != null && migration != null) { beforeMigration(migration); } @@ -39,10 +39,8 @@ namespace NzbDrone.Core.Test.Framework [SetUp] public override void SetupDb() { + Mocker.SetConstant(Mocker.Resolve()); SetupContainer(); } - - [Obsolete("Don't use Mocker/Repositories in MigrationTests, query the DB.", true)] - public new AutoMoqer Mocker => base.Mocker; } } \ No newline at end of file diff --git a/src/NzbDrone.Core/Datastore/Migration/Framework/NzbDroneMigrationBase.cs b/src/NzbDrone.Core/Datastore/Migration/Framework/NzbDroneMigrationBase.cs index 97bfa0d77..7ebac899c 100644 --- a/src/NzbDrone.Core/Datastore/Migration/Framework/NzbDroneMigrationBase.cs +++ b/src/NzbDrone.Core/Datastore/Migration/Framework/NzbDroneMigrationBase.cs @@ -46,7 +46,6 @@ namespace NzbDrone.Core.Datastore.Migration.Framework public override void Up() { - if (Context.BeforeMigration != null) { Context.BeforeMigration(this);