From 3cc1113440394986860bd152ffb583dd09e35ee5 Mon Sep 17 00:00:00 2001 From: tidusjar Date: Wed, 29 Jun 2016 09:51:18 +0100 Subject: [PATCH] Fixed some warnings --- .../CookieHelperTests.cs | 6 +++--- .../UserRequestLimitResetterTests.cs | 1 - PlexRequests.UI.Tests/StringHelperTests.cs | 21 +++++++++---------- 3 files changed, 13 insertions(+), 15 deletions(-) diff --git a/PlexRequests.Helpers.Tests/CookieHelperTests.cs b/PlexRequests.Helpers.Tests/CookieHelperTests.cs index c9a8205fb..6acf94e85 100644 --- a/PlexRequests.Helpers.Tests/CookieHelperTests.cs +++ b/PlexRequests.Helpers.Tests/CookieHelperTests.cs @@ -43,9 +43,9 @@ namespace PlexRequests.Helpers.Tests { get { - yield return new TestCaseData(new Dictionary()).Returns(string.Empty); - yield return new TestCaseData(new Dictionary { { "_ga", "GA1.1.306549087.1464005217" } }).Returns("306549087.1464005217"); - yield return new TestCaseData(new Dictionary { {"_ga", "GA1.1.306549087" } }).Returns(string.Empty); + yield return new TestCaseData(new Dictionary()).Returns(string.Empty).SetName("Empty"); + yield return new TestCaseData(new Dictionary { { "_ga", "GA1.1.306549087.1464005217" } }).Returns("306549087.1464005217").SetName("Returns correctly"); + yield return new TestCaseData(new Dictionary { {"_ga", "GA1.1.306549087" } }).Returns(string.Empty).SetName("Invalid Cookie"); } } } diff --git a/PlexRequests.Services.Tests/UserRequestLimitResetterTests.cs b/PlexRequests.Services.Tests/UserRequestLimitResetterTests.cs index e8d60eb94..729169b7b 100644 --- a/PlexRequests.Services.Tests/UserRequestLimitResetterTests.cs +++ b/PlexRequests.Services.Tests/UserRequestLimitResetterTests.cs @@ -121,7 +121,6 @@ namespace PlexRequests.Services.Tests new TestCaseData(-3, RequestType.TvShow).SetName("-3 Day(s)"), new TestCaseData(-4, RequestType.Movie).SetName("-4 Day(s)"), new TestCaseData(-5, RequestType.TvShow).SetName("-5 Day(s)"), - new TestCaseData(-6, RequestType.Movie).SetName("-6 Day(s)"), new TestCaseData(0, RequestType.TvShow).SetName("0 Day(s)") }; diff --git a/PlexRequests.UI.Tests/StringHelperTests.cs b/PlexRequests.UI.Tests/StringHelperTests.cs index e1cbb811a..546c8ee3c 100644 --- a/PlexRequests.UI.Tests/StringHelperTests.cs +++ b/PlexRequests.UI.Tests/StringHelperTests.cs @@ -52,9 +52,9 @@ namespace PlexRequests.UI.Tests { get { - yield return new TestCaseData("abcCba").Returns("AbcCba"); - yield return new TestCaseData("").Returns(""); - yield return new TestCaseData("12DSAda").Returns("12DSAda"); + yield return new TestCaseData("abcCba").Returns("AbcCba").SetName("pascalCase"); + yield return new TestCaseData("").Returns("").SetName("Empty"); + yield return new TestCaseData("12DSAda").Returns("12DSAda").SetName("With numbers"); } } @@ -62,14 +62,13 @@ namespace PlexRequests.UI.Tests { get { - yield return new TestCaseData("abcCba").Returns("Abc Cba"); - yield return new TestCaseData("").Returns(""); - yield return new TestCaseData("JamieRees").Returns("Jamie Rees"); - yield return new TestCaseData("Jamierees").Returns("Jamierees"); - yield return new TestCaseData("ThisIsANewString").Returns("This Is A New String"); - yield return new TestCaseData("").Returns(""); - yield return new TestCaseData(IssueStatus.PendingIssue.ToString()).Returns("Pending Issue"); - yield return new TestCaseData(IssueStatus.ResolvedIssue.ToString()).Returns("Resolved Issue"); + yield return new TestCaseData("abcCba").Returns("Abc Cba").SetName("spaces"); + yield return new TestCaseData("").Returns("").SetName("empty"); + yield return new TestCaseData("JamieRees").Returns("Jamie Rees").SetName("Name"); + yield return new TestCaseData("Jamierees").Returns("Jamierees").SetName("single word"); + yield return new TestCaseData("ThisIsANewString").Returns("This Is A New String").SetName("longer string"); + yield return new TestCaseData(IssueStatus.PendingIssue.ToString()).Returns("Pending Issue").SetName("enum pending"); + yield return new TestCaseData(IssueStatus.ResolvedIssue.ToString()).Returns("Resolved Issue").SetName("enum resolved"); } } }