From 380c9b6bbd2e52f1adcad5cf8ddc530f63b0b4a1 Mon Sep 17 00:00:00 2001 From: Anojh Date: Fri, 4 May 2018 12:25:44 -0700 Subject: [PATCH 1/2] Fixed duplicate titles in Plex Newsletter --- src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs b/src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs index 6336abf6e..e48690e09 100644 --- a/src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs +++ b/src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs @@ -547,7 +547,7 @@ namespace Ombi.Schedule.Jobs.Ombi AddMediaServerUrl(sb, t.Url, banner); AddInfoTable(sb); - var title = $"{t.Title} ({t.ReleaseYear})"; + var title = $"{t.Title} ({info.premiered.Remove(4)})"; AddTitle(sb, $"https://www.imdb.com/title/{info.externals.imdb}/", title); // Group by the season number From 1f1febce2c845b831fb27f024db8cc1696e2bd3c Mon Sep 17 00:00:00 2001 From: Anojh Date: Fri, 4 May 2018 13:46:55 -0700 Subject: [PATCH 2/2] More robust check for release date --- src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs | 21 ++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs b/src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs index e48690e09..ed34a6236 100644 --- a/src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs +++ b/src/Ombi.Schedule/Jobs/Ombi/NewsletterJob.cs @@ -547,7 +547,14 @@ namespace Ombi.Schedule.Jobs.Ombi AddMediaServerUrl(sb, t.Url, banner); AddInfoTable(sb); - var title = $"{t.Title} ({info.premiered.Remove(4)})"; + var title = ""; + if (!String.IsNullOrEmpty(info.premiered) && info.premiered.Length > 4) + { + title = $"{t.Title} ({info.premiered.Remove(4)})"; + } else + { + title = $"{t.Title}"; + } AddTitle(sb, $"https://www.imdb.com/title/{info.externals.imdb}/", title); // Group by the season number @@ -702,7 +709,17 @@ namespace Ombi.Schedule.Jobs.Ombi AddPosterInsideTable(sb, banner); AddMediaServerUrl(sb, t.Url, banner); AddInfoTable(sb); - AddTitle(sb, $"https://www.imdb.com/title/{info.externals.imdb}/", $"{t.Title} ({info.premiered.Remove(4)})"); + + var title = ""; + if (!String.IsNullOrEmpty(info.premiered) && info.premiered.Length > 4) + { + title = $"{t.Title} ({info.premiered.Remove(4)})"; + } + else + { + title = $"{t.Title}"; + } + AddTitle(sb, $"https://www.imdb.com/title/{info.externals.imdb}/", title); // Group by the season number var results = t.Episodes?.GroupBy(p => p.SeasonNumber,