From 6b24ab7f834b688d5662e496fe803ea0cdea8855 Mon Sep 17 00:00:00 2001
From: "Joshua M. Boniface" <joshua@boniface.me>
Date: Sat, 12 Dec 2020 18:16:24 -0500
Subject: [PATCH] Correct tests for Jellyfin types

---
 .../Authentication/OmbiUserManagerTests.cs    |  2 +-
 src/Ombi.Helpers.Tests/EmbyHelperTests.cs     | 18 ------------
 src/Ombi.Helpers.Tests/JellyfinHelperTests.cs | 29 +++++++++++++++++++
 3 files changed, 30 insertions(+), 19 deletions(-)
 create mode 100644 src/Ombi.Helpers.Tests/JellyfinHelperTests.cs

diff --git a/src/Ombi.Core.Tests/Authentication/OmbiUserManagerTests.cs b/src/Ombi.Core.Tests/Authentication/OmbiUserManagerTests.cs
index bd6e8d5a2..f4e6f59a3 100644
--- a/src/Ombi.Core.Tests/Authentication/OmbiUserManagerTests.cs
+++ b/src/Ombi.Core.Tests/Authentication/OmbiUserManagerTests.cs
@@ -30,7 +30,7 @@ namespace Ombi.Core.Tests.Authentication
             AuthenticationSettings.Setup(x => x.GetSettingsAsync())
                 .ReturnsAsync(new AuthenticationSettings());
             _um = new OmbiUserManager(UserStore.Object, null, null, null, null, null, null, null, null,
-                PlexApi.Object, null, null, AuthenticationSettings.Object);
+                PlexApi.Object, null, null, null, null, AuthenticationSettings.Object);
         }
 
         public OmbiUserManager _um { get; set; }
diff --git a/src/Ombi.Helpers.Tests/EmbyHelperTests.cs b/src/Ombi.Helpers.Tests/EmbyHelperTests.cs
index 261ba87cc..50ac9c48f 100644
--- a/src/Ombi.Helpers.Tests/EmbyHelperTests.cs
+++ b/src/Ombi.Helpers.Tests/EmbyHelperTests.cs
@@ -15,13 +15,6 @@ namespace Ombi.Helpers.Tests
             return EmbyHelper.GetEmbyMediaUrl(mediaId, serverId, url);
         }
 
-        [TestCaseSource(nameof(JellyfinUrlData))]
-        public string TestJellyfinUrl(string mediaId, string url, string serverId)
-        {
-            // http://192.168.68.X:8097/web/index.html#!/details?id=7ffe222498445d5ebfddb31bc4fa9a6d&serverId=50cce67f0baa425093d189b3017331fb
-            return EmbyHelper.GetEmbyMediaUrl(mediaId, serverId, url, true);
-        }
-
         public static IEnumerable<TestCaseData> UrlData
         {
             get
@@ -33,16 +26,5 @@ namespace Ombi.Helpers.Tests
                 yield return new TestCaseData(mediaId.ToString(), string.Empty, "1").Returns($"https://app.emby.media/web/index.html#!/item?id={mediaId}&serverId=1").SetName("EmbyHelper_GetMediaUrl_WithOutCustomDomain");
             }
         }
-
-        public static IEnumerable<TestCaseData> JellyfinUrlData
-        {
-            get
-            {
-                var mediaId = 1;
-                yield return new TestCaseData(mediaId.ToString(), "http://google.com", "1").Returns($"http://google.com/web/index.html#!/details?id={mediaId}&serverId=1").SetName("EmbyHelperJellyfin_GetMediaUrl_WithCustomDomain_WithoutTrailingSlash");
-                yield return new TestCaseData(mediaId.ToString(), "http://google.com/", "1").Returns($"http://google.com/web/index.html#!/details?id={mediaId}&serverId=1").SetName("EmbyHelperJellyfin_GetMediaUrl_WithCustomDomain");
-                yield return new TestCaseData(mediaId.ToString(), "https://google.com/", "1").Returns($"https://google.com/web/index.html#!/details?id={mediaId}&serverId=1").SetName("EmbyHelperJellyfin_GetMediaUrl_WithCustomDomain_Https");
-            }
-        }
     }
 }
diff --git a/src/Ombi.Helpers.Tests/JellyfinHelperTests.cs b/src/Ombi.Helpers.Tests/JellyfinHelperTests.cs
new file mode 100644
index 000000000..e2c235443
--- /dev/null
+++ b/src/Ombi.Helpers.Tests/JellyfinHelperTests.cs
@@ -0,0 +1,29 @@
+using NUnit.Framework;
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Ombi.Helpers.Tests
+{
+    [TestFixture]
+    public class EmbyHelperTests
+    {
+        [TestCaseSource(nameof(UrlData))]
+        public string TestUrl(string mediaId, string url, string serverId)
+        {
+            // http://192.168.68.X:8097/web/index.html#!/details?id=7ffe222498445d5ebfddb31bc4fa9a6d&serverId=50cce67f0baa425093d189b3017331fb
+            return JellyfinHelper.GetJellyfinMediaUrl(mediaId, serverId, url);
+        }
+
+        public static IEnumerable<TestCaseData> UrlData
+        {
+            get
+            {
+                var mediaId = 1;
+                yield return new TestCaseData(mediaId.ToString(), "http://google.com", "1").Returns($"http://google.com/web/index.html#!/item?id={mediaId}&serverId=1").SetName("JellyfinHelper_GetMediaUrl_WithCustomDomain_WithoutTrailingSlash");
+                yield return new TestCaseData(mediaId.ToString(), "http://google.com/", "1").Returns($"http://google.com/web/index.html#!/item?id={mediaId}&serverId=1").SetName("JellyfinHelper_GetMediaUrl_WithCustomDomain");
+                yield return new TestCaseData(mediaId.ToString(), "https://google.com/", "1").Returns($"https://google.com/web/index.html#!/item?id={mediaId}&serverId=1").SetName("JellyfinHelper_GetMediaUrl_WithCustomDomain_Https");
+            }
+        }
+    }
+}