From 764ef1772536065c259c21d818e843e7f463b61e Mon Sep 17 00:00:00 2001 From: tidusjar Date: Tue, 3 Oct 2017 22:56:18 +0100 Subject: [PATCH] real fix --- src/Ombi.Schedule/Jobs/Ombi/OmbiAutomaticUpdater.cs | 9 ++------- src/Ombi/Controllers/JobController.cs | 9 +++++++++ 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/Ombi.Schedule/Jobs/Ombi/OmbiAutomaticUpdater.cs b/src/Ombi.Schedule/Jobs/Ombi/OmbiAutomaticUpdater.cs index 7392d2906..7e2cedb06 100644 --- a/src/Ombi.Schedule/Jobs/Ombi/OmbiAutomaticUpdater.cs +++ b/src/Ombi.Schedule/Jobs/Ombi/OmbiAutomaticUpdater.cs @@ -44,16 +44,11 @@ namespace Ombi.Schedule.Jobs.Ombi } public async Task UpdateAvailable(string branch, string currentVersion) { - try - { + var updates = await OmbiService.GetUpdates(branch); var serverVersion = updates.UpdateVersionString; return !serverVersion.Equals(currentVersion, StringComparison.CurrentCultureIgnoreCase); - } - catch (Exception e) - { - Logger.LogError(e, "Attempted to check if there was an update"); - } + } public async Task Update(PerformContext c) diff --git a/src/Ombi/Controllers/JobController.cs b/src/Ombi/Controllers/JobController.cs index 76ef4fdd4..51339344c 100644 --- a/src/Ombi/Controllers/JobController.cs +++ b/src/Ombi/Controllers/JobController.cs @@ -41,12 +41,21 @@ namespace Ombi.Controllers [HttpGet("update")] public async Task CheckForUpdate() { + try + { + + var productArray = _updater.GetVersion(); var version = productArray[0]; var branch = productArray[1]; var updateAvailable = await _updater.UpdateAvailable(branch, version); return updateAvailable; + } + catch (Exception e) + { + return false; + } } [HttpGet("updateCached")]