From 316564e3f7ab6e3744a9a1c43144808696440988 Mon Sep 17 00:00:00 2001 From: PotatoQuality Date: Wed, 29 Jul 2020 00:42:32 +0200 Subject: [PATCH 01/12] Create config.yml Creating a GitHub config file to make sure users can't overwrite the issue template and will be redirected to other places for posting feature requests or can choose alternative places for requesting help --- .github/ISSUE_TEMPLATE/config.yml | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/config.yml diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 000000000..af93bec75 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,8 @@ +blank_issues_enabled: false +contact_links: + - name: Feature Requests + url: https://ombifeatures.featureupvote.com/ + about: Share your suggestions or ideas to make Ombi better! + - name: Reddit support + url: https://www.reddit.com/r/Ombi/ + about: Ask questions and discuss Ombi From 55c716944eb1d04cd0a20631171f91b4125ba55e Mon Sep 17 00:00:00 2001 From: PotatoQuality Date: Fri, 31 Jul 2020 23:04:33 +0200 Subject: [PATCH 02/12] Update README.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update with the brand new features of v4 👍 Removed v2 --- README.md | 51 +++++++++++++++++++++++++++++---------------------- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/README.md b/README.md index 2ed6275a3..a54046c12 100644 --- a/README.md +++ b/README.md @@ -9,8 +9,16 @@ ____ [![Patreon](https://img.shields.io/badge/patreon-donate-yellow.svg)](https://patreon.com/tidusjar/Ombi) [![Paypal](https://img.shields.io/badge/paypal-donate-yellow.svg)](https://paypal.me/PlexRequestsNet) +# Feature Requests +Feature requests are handled on Feature Upvote. + +Search the existing requests to see if your suggestion has already been submitted. +(If a similar request exists, please vote, or add additional comments to the request) + +#### [![Feature Requests](https://cloud.githubusercontent.com/assets/390379/10127973/045b3a96-6560-11e5-9b20-31a2032956b2.png)](https://features.ombi.io) ___ + [![Twitter](https://img.shields.io/twitter/follow/tidusjar.svg?style=social)](https://twitter.com/intent/follow?screen_name=tidusjar) Follow me developing Ombi! @@ -57,8 +65,9 @@ Here are some of the features Ombi V3 has: We integrate with the following applications: * Plex Media Server * Emby -* Sonarr -* Radarr +* Jellyfin +* Sonarr V2 and V3 +* Radarr V2 * Lidarr * DogNzb * Couch Potato @@ -66,14 +75,16 @@ We integrate with the following applications: ### Notifications Supported notifications: +* Mobile and legacy mobile * SMTP Notifications (Email) * Discord -* Gotify * Slack * Pushbullet * Pushover * Mattermost * Telegram +* Gotify +* Twilio * Webhook ### The difference between Version 3 and 2 @@ -83,31 +94,27 @@ We have already done most of the work, but some features are still be missing in We are planning to bring back these features in V3 but for now you can find a list below with a quick comparison of features between v2 and v3. -| Service | Version 3 | Version 2 | +| Service | Version 4 (Beta) | Version 3 (Stable)| |----------|:----------:|:----------:| -| Multiple Plex/Emby Servers| Yes | No | -| Emby & Plex support | Yes | Yes | -| Mono dependency | No | Yes | -| Notifications support | Yes| Yes | -| Landing page | Yes (brand new) | Yes | +| Multiple Plex/Emby/Jellyfin Servers | Yes | Yes | +| Emby/Jellyfin & Plex support | Yes | Yes | +| Mono dependency | No | No | +| Plex OAuth support | Yes | Yes | | Login page | Yes (brand new) | Yes | -| Custom Notification Messages | Yes | No | +| Landing page | Yes (brand new) | Yes | +| Discovery page | Yes (brand new) | No | +| Request a movie collection | Yes (brand new) | No | +| Auto Delete Available Requests | Yes (brand new) | No | +| Report issues | Yes | Yes | +| Notifications support | Yes | Yes | +| Custom Notification Messages | Yes | Yes | | Sending newsletters | Yes | Yes | | Send a Mass Email | Yes | Yes | | SickRage | Yes | Yes | | CouchPotato | Yes | Yes | -| DogNzb | Yes | No | -| Issues | Yes | Yes | -| Headphones | No | Yes | -| Lidarr | Yes | No | - -# Feature Requests -Feature requests are handled on Feature Upvote. - -Search the existing requests to see if your suggestion has already been submitted. -(If a similar request exists, please vote, or add additional comments to the request) - -#### [![Feature Requests](https://cloud.githubusercontent.com/assets/390379/10127973/045b3a96-6560-11e5-9b20-31a2032956b2.png)](https://features.ombi.io) +| DogNzb | Yes | Yes | +| Headphones | Not yet | Yes | +| Lidarr | Yes | Yes | # Preview From 8c25daff568cb67a7ddde079ef8d2a3daf9c0b98 Mon Sep 17 00:00:00 2001 From: Jamie Rees Date: Mon, 3 Aug 2020 20:35:35 +0100 Subject: [PATCH 03/12] Fixed mysql migration --- .../OmbiMySql/20200731151314_RemoveEmbyConnectionid.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Ombi.Store/Migrations/OmbiMySql/20200731151314_RemoveEmbyConnectionid.cs b/src/Ombi.Store/Migrations/OmbiMySql/20200731151314_RemoveEmbyConnectionid.cs index 35fd4fa8a..c216b5eae 100644 --- a/src/Ombi.Store/Migrations/OmbiMySql/20200731151314_RemoveEmbyConnectionid.cs +++ b/src/Ombi.Store/Migrations/OmbiMySql/20200731151314_RemoveEmbyConnectionid.cs @@ -6,10 +6,10 @@ namespace Ombi.Store.Migrations.OmbiMySql { protected override void Up(MigrationBuilder migrationBuilder) { + migrationBuilder.Sql("UPDATE AspNetUsers SET UserType = 4 WHERE EmbyConnectUserId IS NOT NULL"); migrationBuilder.DropColumn( name: "EmbyConnectUserId", table: "AspNetUsers"); - migrationBuilder.Sql("UPDATE AspNetUsers SET UserType = 4 WHERE EmbyConnectUserId IS NOT NULL"); } protected override void Down(MigrationBuilder migrationBuilder) From aba00ae69827350e5da7512b273e3dfe54138099 Mon Sep 17 00:00:00 2001 From: Jamie Rees Date: Mon, 3 Aug 2020 21:23:32 +0100 Subject: [PATCH 04/12] Custom CSS is now working --- src/Ombi/ClientApp/src/app/app.component.ts | 6 ++++++ src/Ombi/ClientApp/src/app/login/login.component.html | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Ombi/ClientApp/src/app/app.component.ts b/src/Ombi/ClientApp/src/app/app.component.ts index 14899f56c..abf47b1bf 100644 --- a/src/Ombi/ClientApp/src/app/app.component.ts +++ b/src/Ombi/ClientApp/src/app/app.component.ts @@ -83,6 +83,12 @@ export class AppComponent implements OnInit { this.applicationName = this.customizationSettings.applicationName; this.document.getElementsByTagName('title')[0].innerText = this.applicationName; } + if (this.customizationSettings && this.customizationSettings.customCss) { + var dom = this.document.getElementsByTagName('head')[0]; + var css = document.createElement("style"); + css.innerHTML = this.customizationSettings.customCss; + dom.appendChild(css); + } if (this.customizationSettings.useCustomPage) { this.customPageService.getCustomPage().subscribe(c => { diff --git a/src/Ombi/ClientApp/src/app/login/login.component.html b/src/Ombi/ClientApp/src/app/login/login.component.html index 8b0972115..f2627b3f8 100644 --- a/src/Ombi/ClientApp/src/app/login/login.component.html +++ b/src/Ombi/ClientApp/src/app/login/login.component.html @@ -24,7 +24,7 @@ {{'Login.RememberMe' | translate}} - + From b5f936c03abba9c68837417617c131fccd50e6fc Mon Sep 17 00:00:00 2001 From: PotatoQuality Date: Tue, 4 Aug 2020 10:43:39 +0200 Subject: [PATCH 05/12] Update config.yml added some icons --- .github/ISSUE_TEMPLATE/config.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index af93bec75..6a68e76c3 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,8 +1,11 @@ blank_issues_enabled: false contact_links: - - name: Feature Requests + - name: 📗 Wiki + url: https://github.com/tidusjar/Ombi/wiki + about: The Ombi wiki should help guide you through installation and setup as well as help resolve common problems and answer frequently asked questions. + - name: 🌐 Reddit support + url: https://www.reddit.com/r/Ombi/ + about: Ask questions about Ombi + - name: 🚀 Feature suggestions url: https://ombifeatures.featureupvote.com/ about: Share your suggestions or ideas to make Ombi better! - - name: Reddit support - url: https://www.reddit.com/r/Ombi/ - about: Ask questions and discuss Ombi From 8ef7c99df8ae6143e047fca94de1a91ed1f6bed4 Mon Sep 17 00:00:00 2001 From: PotatoQuality Date: Tue, 4 Aug 2020 10:44:49 +0200 Subject: [PATCH 06/12] Update bug_report.md Add a nice icon to it --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 2236cc395..7936c8426 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -1,5 +1,5 @@ --- -name: Bug report +name: "\U0001F41B Bug report" about: Create a report to help us improve title: '' labels: '' From 527e7b68221bcf4bda0aed8db6a6d4252c7977c2 Mon Sep 17 00:00:00 2001 From: PotatoQuality Date: Tue, 4 Aug 2020 12:49:27 +0200 Subject: [PATCH 07/12] Update README.md Processed feedback --- README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index a54046c12..5b8dba60d 100644 --- a/README.md +++ b/README.md @@ -75,7 +75,7 @@ We integrate with the following applications: ### Notifications Supported notifications: -* Mobile and legacy mobile +* Mobile * SMTP Notifications (Email) * Discord * Slack @@ -101,7 +101,6 @@ We are planning to bring back these features in V3 but for now you can find a li | Mono dependency | No | No | | Plex OAuth support | Yes | Yes | | Login page | Yes (brand new) | Yes | -| Landing page | Yes (brand new) | Yes | | Discovery page | Yes (brand new) | No | | Request a movie collection | Yes (brand new) | No | | Auto Delete Available Requests | Yes (brand new) | No | @@ -113,7 +112,7 @@ We are planning to bring back these features in V3 but for now you can find a li | SickRage | Yes | Yes | | CouchPotato | Yes | Yes | | DogNzb | Yes | Yes | -| Headphones | Not yet | Yes | +| Headphones | No | Yes | | Lidarr | Yes | Yes | # Preview From 90c6c53727409b8dc90da5c7bef79c08b96c425c Mon Sep 17 00:00:00 2001 From: PotatoQuality Date: Tue, 4 Aug 2020 13:03:56 +0200 Subject: [PATCH 08/12] Update config.yml Fixing attempt, github doesn't load it :( --- .github/ISSUE_TEMPLATE/config.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 6a68e76c3..82f01f053 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,11 +1,11 @@ blank_issues_enabled: false contact_links: - - name: 📗 Wiki + - name: Wiki url: https://github.com/tidusjar/Ombi/wiki - about: The Ombi wiki should help guide you through installation and setup as well as help resolve common problems and answer frequently asked questions. - - name: 🌐 Reddit support - url: https://www.reddit.com/r/Ombi/ + about: The Ombi wiki should help guide you through installation and setup as well as help resolve common problems and answer frequently asked questions + - name: Reddit support + url: https://www.reddit.com/r/Ombi about: Ask questions about Ombi - - name: 🚀 Feature suggestions - url: https://ombifeatures.featureupvote.com/ + - name: Feature suggestions + url: https://ombifeatures.featureupvote.com about: Share your suggestions or ideas to make Ombi better! From 96b20d399306f1279d89d30178f791b5f2feed1f Mon Sep 17 00:00:00 2001 From: PotatoQuality Date: Tue, 4 Aug 2020 23:06:02 +0200 Subject: [PATCH 09/12] Update bug_report.md remove some colomn that we dont need --- .github/ISSUE_TEMPLATE/bug_report.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 7936c8426..7697affd4 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -1,9 +1,6 @@ --- name: "\U0001F41B Bug report" about: Create a report to help us improve -title: '' -labels: '' -assignees: '' --- From 91a6889bf15d9d5852ed0821b9d646627501751d Mon Sep 17 00:00:00 2001 From: Fredrik81 Date: Thu, 6 Aug 2020 17:21:08 +0200 Subject: [PATCH 10/12] Update README.md Wrong versions --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5b8dba60d..855e32dfe 100644 --- a/README.md +++ b/README.md @@ -87,7 +87,7 @@ Supported notifications: * Twilio * Webhook -### The difference between Version 3 and 2 +### The difference between Version 4 and 3 Over the last year, we focused on the main functions on Ombi, a complete rewrite while making it better, faster and more stable. We have already done most of the work, but some features are still be missing in this first version. From 2eb3ff6ce5f643473e9ac99e1f0be9024fb96c42 Mon Sep 17 00:00:00 2001 From: Fredrik81 Date: Thu, 6 Aug 2020 17:22:53 +0200 Subject: [PATCH 11/12] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 855e32dfe..fdb90a5fc 100644 --- a/README.md +++ b/README.md @@ -91,7 +91,7 @@ Supported notifications: Over the last year, we focused on the main functions on Ombi, a complete rewrite while making it better, faster and more stable. We have already done most of the work, but some features are still be missing in this first version. -We are planning to bring back these features in V3 but for now you can find a list below with a quick comparison of features between v2 and v3. +We are planning to bring back these features in V3 but for now you can find a list below with a quick comparison of features between v4 and v3. | Service | Version 4 (Beta) | Version 3 (Stable)| From 48bd8d718c3353b4eb40400786157984a918c796 Mon Sep 17 00:00:00 2001 From: Twan Ariens <34845004+twanariens@users.noreply.github.com> Date: Tue, 11 Aug 2020 21:04:21 +0200 Subject: [PATCH 12/12] Update 20200218230644_MobileDevices.cs --- .../Migrations/OmbiMySql/20200218230644_MobileDevices.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Ombi.Store/Migrations/OmbiMySql/20200218230644_MobileDevices.cs b/src/Ombi.Store/Migrations/OmbiMySql/20200218230644_MobileDevices.cs index ce2c2ebd2..ae533b901 100644 --- a/src/Ombi.Store/Migrations/OmbiMySql/20200218230644_MobileDevices.cs +++ b/src/Ombi.Store/Migrations/OmbiMySql/20200218230644_MobileDevices.cs @@ -11,7 +11,7 @@ namespace Ombi.Store.Migrations.OmbiMySql migrationBuilder.Sql(@"CREATE TABLE `MobileDevices` ( `Id` int NOT NULL AUTO_INCREMENT, `Token` longtext CHARACTER SET utf8mb4 NULL, - `UserId` varchar(255) COLLATE utf8mb4_bin NOT NULL, + `UserId` varchar(255) CHARACTER SET utf8mb4 NOT NULL, `AddedAt` datetime(6) NOT NULL, CONSTRAINT `PK_MobileDevices` PRIMARY KEY (`Id`), CONSTRAINT `FK_MobileDevices_AspNetUsers_UserId` FOREIGN KEY (`UserId`) REFERENCES `AspNetUsers` (`Id`) ON DELETE RESTRICT