From f074f28db7362aaebb5f12131e04c5d5bf9cf0de Mon Sep 17 00:00:00 2001 From: TidusJar Date: Mon, 2 Jan 2017 20:23:53 +0000 Subject: [PATCH] * userManagementController.js: fixed #881 * UserManagementModule.cs: --- .../userManagementController.js | 5 +++ Ombi.UI/Modules/UserManagementModule.cs | 31 +++++++++---------- 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/Ombi.UI/Content/app/userManagement/userManagementController.js b/Ombi.UI/Content/app/userManagement/userManagementController.js index 7803318d7..de6c3f14f 100644 --- a/Ombi.UI/Content/app/userManagement/userManagementController.js +++ b/Ombi.UI/Content/app/userManagement/userManagementController.js @@ -74,6 +74,8 @@ } } + if(Array.isArray($scope.users)){ + var existingUsername = $scope.users.some(function (u) { return u.username === $scope.user.username; }); @@ -81,6 +83,7 @@ if (existingUsername) { return generateNotify("A user with the username " + $scope.user.username + " already exists!", 'danger'); } + } userManagementService.addUser($scope.user, $scope.selectedPermissions, $scope.selectedFeatures) .then(function (data) { @@ -92,6 +95,8 @@ clearCheckboxes(); }; }); + + }; // Watch the checkboxes for updates (Creating a user) diff --git a/Ombi.UI/Modules/UserManagementModule.cs b/Ombi.UI/Modules/UserManagementModule.cs index 1a2581d40..bcf41d3a1 100644 --- a/Ombi.UI/Modules/UserManagementModule.cs +++ b/Ombi.UI/Modules/UserManagementModule.cs @@ -86,23 +86,20 @@ namespace Ombi.UI.Modules { //Get Plex Users var plexUsers = PlexApi.GetUsers(plexSettings.PlexAuthToken); - - foreach (var u in plexUsers.User) - { - var dbUser = plexDbUsers.FirstOrDefault(x => x.PlexUserId == u.Id); - var userDb = userLogins.FirstOrDefault(x => x.UserId == u.Id); - - // We don't have the user in the database yet - if (dbUser == null) - { - model.Add(MapPlexUser(u, null, userDb?.LastLoggedIn ?? DateTime.MinValue)); - } - else - { - // The Plex User is in the database - model.Add(MapPlexUser(u, dbUser, userDb?.LastLoggedIn ?? DateTime.MinValue)); - } - } + if (plexUsers != null && plexUsers.User != null) { + foreach (var u in plexUsers.User) { + var dbUser = plexDbUsers.FirstOrDefault (x => x.PlexUserId == u.Id); + var userDb = userLogins.FirstOrDefault (x => x.UserId == u.Id); + + // We don't have the user in the database yet + if (dbUser == null) { + model.Add (MapPlexUser (u, null, userDb?.LastLoggedIn ?? DateTime.MinValue)); + } else { + // The Plex User is in the database + model.Add (MapPlexUser (u, dbUser, userDb?.LastLoggedIn ?? DateTime.MinValue)); + } + } + } // Also get the server admin var account = PlexApi.GetAccount(plexSettings.PlexAuthToken);