diff --git a/.editorconfig b/.editorconfig index 7b0cce5c0..8a07e89a8 100644 --- a/.editorconfig +++ b/.editorconfig @@ -179,7 +179,6 @@ dotnet_diagnostic.CA1720.severity = suggestion dotnet_diagnostic.CA1721.severity = suggestion dotnet_diagnostic.CA1724.severity = suggestion dotnet_diagnostic.CA1725.severity = suggestion -dotnet_diagnostic.CA1805.severity = suggestion dotnet_diagnostic.CA1806.severity = suggestion dotnet_diagnostic.CA1810.severity = suggestion dotnet_diagnostic.CA1812.severity = suggestion diff --git a/src/NzbDrone.Common/TPL/LimitedConcurrencyLevelTaskScheduler.cs b/src/NzbDrone.Common/TPL/LimitedConcurrencyLevelTaskScheduler.cs index 2f1a295b5..a6137486b 100644 --- a/src/NzbDrone.Common/TPL/LimitedConcurrencyLevelTaskScheduler.cs +++ b/src/NzbDrone.Common/TPL/LimitedConcurrencyLevelTaskScheduler.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Generic; using System.Linq; using System.Threading; @@ -19,7 +19,7 @@ namespace NzbDrone.Common.TPL private readonly int _maxDegreeOfParallelism; /// Whether the scheduler is currently processing work items. - private int _delegatesQueuedOrRunning = 0; + private int _delegatesQueuedOrRunning; /// /// Initializes an instance of the LimitedConcurrencyLevelTaskScheduler class with the diff --git a/src/NzbDrone.Core/Datastore/WhereBuilderPostgres.cs b/src/NzbDrone.Core/Datastore/WhereBuilderPostgres.cs index f3e31e179..91f910c9e 100644 --- a/src/NzbDrone.Core/Datastore/WhereBuilderPostgres.cs +++ b/src/NzbDrone.Core/Datastore/WhereBuilderPostgres.cs @@ -15,9 +15,9 @@ namespace NzbDrone.Core.Datastore private const DbType EnumerableMultiParameter = (DbType)(-1); private readonly string _paramNamePrefix; - private readonly bool _requireConcreteValue = false; - private int _paramCount = 0; - private bool _gotConcreteValue = false; + private readonly bool _requireConcreteValue; + private int _paramCount; + private bool _gotConcreteValue; public WhereBuilderPostgres(Expression filter, bool requireConcreteValue, int seq) { diff --git a/src/NzbDrone.Core/Datastore/WhereBuilderSqlite.cs b/src/NzbDrone.Core/Datastore/WhereBuilderSqlite.cs index 54b24d7e1..8725361e9 100644 --- a/src/NzbDrone.Core/Datastore/WhereBuilderSqlite.cs +++ b/src/NzbDrone.Core/Datastore/WhereBuilderSqlite.cs @@ -15,9 +15,9 @@ namespace NzbDrone.Core.Datastore private const DbType EnumerableMultiParameter = (DbType)(-1); private readonly string _paramNamePrefix; - private readonly bool _requireConcreteValue = false; - private int _paramCount = 0; - private bool _gotConcreteValue = false; + private readonly bool _requireConcreteValue; + private int _paramCount; + private bool _gotConcreteValue; public WhereBuilderSqlite(Expression filter, bool requireConcreteValue, int seq) { diff --git a/src/NzbDrone.Core/HealthCheck/HealthCheckService.cs b/src/NzbDrone.Core/HealthCheck/HealthCheckService.cs index 8735efe3d..1538674ab 100644 --- a/src/NzbDrone.Core/HealthCheck/HealthCheckService.cs +++ b/src/NzbDrone.Core/HealthCheck/HealthCheckService.cs @@ -34,8 +34,8 @@ namespace NzbDrone.Core.HealthCheck private readonly ICached _healthCheckResults; - private bool _hasRunHealthChecksAfterGracePeriod = false; - private bool _isRunningHealthChecksAfterGracePeriod = false; + private bool _hasRunHealthChecksAfterGracePeriod; + private bool _isRunningHealthChecksAfterGracePeriod; public HealthCheckService(IEnumerable healthChecks, IServerSideNotificationService serverSideNotificationService, diff --git a/src/NzbDrone.Core/Indexers/Definitions/Cardigann/CardigannDefinition.cs b/src/NzbDrone.Core/Indexers/Definitions/Cardigann/CardigannDefinition.cs index 094e9b07e..491bae1d3 100644 --- a/src/NzbDrone.Core/Indexers/Definitions/Cardigann/CardigannDefinition.cs +++ b/src/NzbDrone.Core/Indexers/Definitions/Cardigann/CardigannDefinition.cs @@ -44,7 +44,7 @@ namespace NzbDrone.Core.Indexers.Cardigann public double? RequestDelay { get; set; } public List Links { get; set; } public List Legacylinks { get; set; } - public bool Followredirect { get; set; } = false; + public bool Followredirect { get; set; } public bool TestLinkTorrent { get; set; } = true; public List Certificates { get; set; } public CapabilitiesBlock Caps { get; set; } @@ -95,7 +95,7 @@ namespace NzbDrone.Core.Indexers.Cardigann public List Cookies { get; set; } public string Method { get; set; } public string Form { get; set; } - public bool Selectors { get; set; } = false; + public bool Selectors { get; set; } public Dictionary Inputs { get; set; } public Dictionary Selectorinputs { get; set; } public Dictionary Getselectorinputs { get; set; } @@ -114,7 +114,7 @@ namespace NzbDrone.Core.Indexers.Cardigann public class SelectorBlock { public string Selector { get; set; } - public bool Optional { get; set; } = false; + public bool Optional { get; set; } public string Text { get; set; } public string Attribute { get; set; } public string Remove { get; set; } @@ -157,7 +157,7 @@ namespace NzbDrone.Core.Indexers.Cardigann public int After { get; set; } public SelectorBlock Dateheaders { get; set; } public SelectorBlock Count { get; set; } - public bool Multiple { get; set; } = false; + public bool Multiple { get; set; } } public class SearchPathBlock : RequestBlock diff --git a/src/NzbDrone.Mono/Disk/ProcMountProvider.cs b/src/NzbDrone.Mono/Disk/ProcMountProvider.cs index 5900d203c..2cce7d8b6 100644 --- a/src/NzbDrone.Mono/Disk/ProcMountProvider.cs +++ b/src/NzbDrone.Mono/Disk/ProcMountProvider.cs @@ -27,7 +27,7 @@ namespace NzbDrone.Mono.Disk private static Dictionary _fileSystems; - private bool _hasLoggedProcMountFailure = false; + private bool _hasLoggedProcMountFailure; public ProcMountProvider(Logger logger) {