From 79361d92cb043659f585b8bab3c36e37c7376d71 Mon Sep 17 00:00:00 2001
From: Bogdan <mynameisbogdan@users.noreply.github.com>
Date: Thu, 20 Jul 2023 23:05:48 +0300
Subject: [PATCH] Ensure `No search results found` isn't shown without a search

---
 ...NoSearchResults.js => NoSearchResults.tsx} | 15 +++++------
 frontend/src/Search/SearchIndex.js            | 25 +++++++++++--------
 2 files changed, 21 insertions(+), 19 deletions(-)
 rename frontend/src/Search/{NoSearchResults.js => NoSearchResults.tsx} (63%)

diff --git a/frontend/src/Search/NoSearchResults.js b/frontend/src/Search/NoSearchResults.tsx
similarity index 63%
rename from frontend/src/Search/NoSearchResults.js
rename to frontend/src/Search/NoSearchResults.tsx
index 03fce4be9..4ffd1d7fd 100644
--- a/frontend/src/Search/NoSearchResults.js
+++ b/frontend/src/Search/NoSearchResults.tsx
@@ -1,9 +1,12 @@
-import PropTypes from 'prop-types';
 import React from 'react';
 import translate from 'Utilities/String/translate';
 import styles from './NoSearchResults.css';
 
-function NoSearchResults(props) {
+interface NoSearchResultsProps {
+  totalItems: number;
+}
+
+function NoSearchResults(props: NoSearchResultsProps) {
   const { totalItems } = props;
 
   if (totalItems > 0) {
@@ -18,15 +21,9 @@ function NoSearchResults(props) {
 
   return (
     <div>
-      <div className={styles.message}>
-        {translate('NoSearchResultsFound')}
-      </div>
+      <div className={styles.message}>{translate('NoSearchResultsFound')}</div>
     </div>
   );
 }
 
-NoSearchResults.propTypes = {
-  totalItems: PropTypes.number.isRequired
-};
-
 export default NoSearchResults;
diff --git a/frontend/src/Search/SearchIndex.js b/frontend/src/Search/SearchIndex.js
index ba25b0912..3bcceadd5 100644
--- a/frontend/src/Search/SearchIndex.js
+++ b/frontend/src/Search/SearchIndex.js
@@ -326,15 +326,17 @@ class SearchIndex extends Component {
             innerClassName={styles.tableInnerContentBody}
           >
             {
-              isFetching && !isPopulated &&
-                <LoadingIndicator />
+              isFetching && !isPopulated ?
+                <LoadingIndicator /> :
+                null
             }
 
             {
-              !isFetching && !!error &&
+              !isFetching && !!error ?
                 <Alert kind={kinds.DANGER}>
                   {getErrorMessage(error, 'Failed to load search results from API')}
-                </Alert>
+                </Alert> :
+                null
             }
 
             {
@@ -359,16 +361,18 @@ class SearchIndex extends Component {
             }
 
             {
-              !error && !isFetching && !hasIndexers &&
+              !error && !isFetching && !hasIndexers ?
                 <NoIndexer
                   totalItems={0}
                   onAddIndexerPress={this.onAddIndexerPress}
-                />
+                /> :
+                null
             }
 
             {
-              !error && !isFetching && hasIndexers && !items.length &&
-                <NoSearchResults totalItems={totalItems} />
+              !error && !isFetching && isPopulated && hasIndexers && !items.length ?
+                <NoSearchResults totalItems={totalItems} /> :
+                null
             }
 
             <AddIndexerModal
@@ -384,11 +388,12 @@ class SearchIndex extends Component {
           </PageContentBody>
 
           {
-            isLoaded && !!jumpBarItems.order.length &&
+            isLoaded && !!jumpBarItems.order.length ?
               <PageJumpBar
                 items={jumpBarItems}
                 onItemPress={this.onJumpBarItemPress}
-              />
+              /> :
+              null
           }
         </div>