Fixed: Ignore "special drives" from System » Disk Space (#3050)

Fixes #3045, fixes #3122.

src/NzbDrone.Core.Test/DiskSpace/DiskSpaceServiceFixture.cs

@@ -0,0 +1,160 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using FluentAssertions;
+using Moq;
+using NUnit.Framework;
+using NzbDrone.Common.Disk;
+using NzbDrone.Core.Configuration;
+using NzbDrone.Core.DiskSpace;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Core.Movies;
+using NzbDrone.Test.Common;
+
+namespace NzbDrone.Core.Test.DiskSpace
+{
+    [TestFixture]
+    public class DiskSpaceServiceFixture : CoreTest<DiskSpaceService>
+    {
+        private string _moviesFolder;
+        private string _moviesFolder2;
+        private string _droneFactoryFolder;
+
+        [SetUp]
+        public void SetUp()
+        {
+            _moviesFolder = @"G:\fasdlfsdf\movies".AsOsAgnostic();
+            _moviesFolder2 = @"G:\fasdlfsdf\movies2".AsOsAgnostic();
+            _droneFactoryFolder = @"G:\dronefactory".AsOsAgnostic();
+
+            Mocker.GetMock<IDiskProvider>()
+                  .Setup(v => v.GetMounts())
+                  .Returns(new List<IMount>());
+
+            Mocker.GetMock<IDiskProvider>()
+                  .Setup(v => v.GetPathRoot(It.IsAny<string>()))
+                  .Returns(@"G:\".AsOsAgnostic());
+
+            Mocker.GetMock<IDiskProvider>()
+                  .Setup(v => v.GetAvailableSpace(It.IsAny<string>()))
+                  .Returns(0);
+
+            Mocker.GetMock<IDiskProvider>()
+                  .Setup(v => v.GetTotalSize(It.IsAny<string>()))
+                  .Returns(0);
+
+            GivenMovies();
+        }
+
+        private void GivenMovies(params Movie[] movies)
+        {
+            Mocker.GetMock<IMovieService>()
+                  .Setup(v => v.GetAllMovies())
+                  .Returns(movies.ToList());
+        }
+
+        private void GivenExistingFolder(string folder)
+        {
+            Mocker.GetMock<IDiskProvider>()
+                  .Setup(v => v.FolderExists(folder))
+                  .Returns(true);
+        }
+
+        [Test]
+        public void should_check_diskspace_for_movies_folders()
+        {
+            GivenMovies(new Movie { Path = _moviesFolder });
+
+            GivenExistingFolder(_moviesFolder);
+
+            var freeSpace = Subject.GetFreeSpace();
+
+            freeSpace.Should().NotBeEmpty();
+        }
+
+        [Test]
+        public void should_check_diskspace_for_same_root_folder_only_once()
+        {
+            GivenMovies(new Movie { Path = _moviesFolder }, new Movie { Path = _moviesFolder2 });
+
+            GivenExistingFolder(_moviesFolder);
+            GivenExistingFolder(_moviesFolder2);
+
+            var freeSpace = Subject.GetFreeSpace();
+
+            freeSpace.Should().HaveCount(1);
+
+            Mocker.GetMock<IDiskProvider>()
+                  .Verify(v => v.GetAvailableSpace(It.IsAny<string>()), Times.Once());
+        }
+
+        [Test]
+        [Ignore("Unknown failure")]
+        public void should_not_check_diskspace_for_missing_movies_folders()
+        {
+            GivenMovies(new Movie { Path = _moviesFolder });
+
+            var freeSpace = Subject.GetFreeSpace();
+
+            freeSpace.Should().BeEmpty();
+
+            Mocker.GetMock<IDiskProvider>()
+                  .Verify(v => v.GetAvailableSpace(It.IsAny<string>()), Times.Never());
+        }
+
+        [Test]
+        public void should_check_diskspace_for_dronefactory_folder()
+        {
+            Mocker.GetMock<IConfigService>()
+                  .SetupGet(v => v.DownloadedMoviesFolder)
+                  .Returns(_droneFactoryFolder);
+
+            GivenExistingFolder(_droneFactoryFolder);
+
+            var freeSpace = Subject.GetFreeSpace();
+
+            freeSpace.Should().NotBeEmpty();
+        }
+
+        [Test]
+        [Ignore("Unknown failure")]
+        public void should_not_check_diskspace_for_missing_dronefactory_folder()
+        {
+            Mocker.GetMock<IConfigService>()
+                  .SetupGet(v => v.DownloadedMoviesFolder)
+                  .Returns(_droneFactoryFolder);
+
+            var freeSpace = Subject.GetFreeSpace();
+
+            freeSpace.Should().BeEmpty();
+
+            Mocker.GetMock<IDiskProvider>()
+                  .Verify(v => v.GetAvailableSpace(It.IsAny<string>()), Times.Never());
+        }
+
+        [TestCase("/boot")]
+        [TestCase("/var/lib/rancher")]
+        [TestCase("/var/lib/rancher/volumes")]
+        [TestCase("/var/lib/kubelet")]
+        [TestCase("/var/lib/docker")]
+        [TestCase("/some/place/docker/aufs")]
+        [TestCase("/etc/network")]
+        [TestCase("/snap/filebot/9")]
+        [TestCase("/snap/core/5145")]
+        public void should_not_check_diskspace_for_irrelevant_mounts(string path)
+        {
+            var mount = new Mock<IMount>();
+            mount.SetupGet(v => v.RootDirectory).Returns(path);
+            mount.SetupGet(v => v.DriveType).Returns(System.IO.DriveType.Fixed);
+
+            Mocker.GetMock<IDiskProvider>()
+                  .Setup(v => v.GetMounts())
+                  .Returns(new List<IMount> { mount.Object });
+
+            var freeSpace = Subject.GetFreeSpace();
+
+            freeSpace.Should().BeEmpty();
+        }
+    }
+}

src/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj

@@ -168,6 +168,7 @@
     <Compile Include="DecisionEngineTests\Search\MovieSpecificationFixture.cs" />
     <Compile Include="DecisionEngineTests\RawDiskSpecificationFixture.cs" />
     <Compile Include="DecisionEngineTests\UpgradeDiskSpecificationFixture.cs" />
+    <Compile Include="DiskSpace\DiskSpaceServiceFixture.cs" />
     <Compile Include="Download\CompletedDownloadServiceFixture.cs" />
     <Compile Include="Download\DownloadApprovedReportsTests\DownloadApprovedFixture.cs" />
     <Compile Include="Download\DownloadClientTests\Blackhole\ScanWatchFolderFixture.cs" />

src/NzbDrone.Core/DiskSpace/DiskSpaceService.cs

@@ -2,6 +2,7 @@ using System;
 using System.IO;
 using System.Collections.Generic;
 using System.Linq;
+using System.Text.RegularExpressions;
 using NLog;
 using NzbDrone.Common.Disk;
 using NzbDrone.Common.Extensions;
@@ -22,6 +23,8 @@ namespace NzbDrone.Core.DiskSpace
         private readonly IDiskProvider _diskProvider;
         private readonly Logger _logger;
 
+        private static readonly Regex _regexSpecialDrive = new Regex("^/var/lib/(docker|rancher|kubelet)(/|$)|^/(boot|etc|snap)(/|$)|/docker(/var)?/aufs(/|$)", RegexOptions.Compiled);
+
         public DiskSpaceService(IMovieService movieService, IConfigService configService, IDiskProvider diskProvider, Logger logger)
         {
             _movieService = movieService;
@@ -59,7 +62,10 @@ namespace NzbDrone.Core.DiskSpace
 
         private IEnumerable<DiskSpace> GetFixedDisksFreeSpace()
         {
-            return GetDiskSpace(_diskProvider.GetMounts().Where(d => d.DriveType == DriveType.Fixed).Select(d => d.RootDirectory), true);
+            return GetDiskSpace(_diskProvider.GetMounts()
+                .Where(d => d.DriveType == DriveType.Fixed)
+                .Where(d => !_regexSpecialDrive.IsMatch(d.RootDirectory))
+                .Select(d => d.RootDirectory), true);
         }
 
         private IEnumerable<DiskSpace> GetDiskSpace(IEnumerable<string> paths, bool suppressWarnings = false)

src/NzbDrone.Mono/Disk/DiskProvider.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
@@ -189,8 +189,6 @@ namespace NzbDrone.Mono.Disk
             }
 
             return g.gr_gid;
-
-
         }
     }
 }

src/NzbDrone.Mono/Disk/ProcMountProvider.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
@@ -111,6 +111,18 @@ namespace NzbDrone.Mono.Disk
                 return null;
             }
 
+            if (mount.StartsWith("/var/lib/"))
+            {
+                // Could be /var/lib/docker when docker uses zfs. Very unlikely that a useful mount is located in /var/lib.
+                return null;
+            }
+
+            if (mount.StartsWith("/snap/"))
+            {
+                // Mount point for snap packages
+                return null;
+            }
+
             var driveType = FindDriveType.Find(type);
 
             if (name.StartsWith("/dev/") || GetFileSystems().GetValueOrDefault(type, false))