From 2d42c59d70561d57d09ac3ca28eb9df90880c943 Mon Sep 17 00:00:00 2001
From: Mark McDowall <markus.mcd5@gmail.com>
Date: Tue, 27 Oct 2015 22:19:24 -0700
Subject: [PATCH] Fixed: Log download client name when communication fails

---
 .../Checks/DownloadClientCheckFixture.cs         |  3 +++
 src/NzbDrone.Core/Download/IDownloadClient.cs    |  3 +--
 .../HealthCheck/Checks/DownloadClientCheck.cs    | 16 +++++++++-------
 3 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/src/NzbDrone.Core.Test/HealthCheck/Checks/DownloadClientCheckFixture.cs b/src/NzbDrone.Core.Test/HealthCheck/Checks/DownloadClientCheckFixture.cs
index 9f80edd63..fc1067575 100644
--- a/src/NzbDrone.Core.Test/HealthCheck/Checks/DownloadClientCheckFixture.cs
+++ b/src/NzbDrone.Core.Test/HealthCheck/Checks/DownloadClientCheckFixture.cs
@@ -3,7 +3,9 @@ using System.Collections.Generic;
 using NUnit.Framework;
 using NzbDrone.Core.Download;
 using NzbDrone.Core.HealthCheck.Checks;
+using NzbDrone.Core.Indexers;
 using NzbDrone.Core.Test.Framework;
+using NzbDrone.Core.ThingiProvider;
 using NzbDrone.Test.Common;
 
 namespace NzbDrone.Core.Test.HealthCheck.Checks
@@ -25,6 +27,7 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks
         public void should_return_error_when_download_client_throws()
         {
             var downloadClient = Mocker.GetMock<IDownloadClient>();
+            downloadClient.Setup(s => s.Definition).Returns(new IndexerDefinition{Name = "Test"});
 
             downloadClient.Setup(s => s.GetItems())
                           .Throws<Exception>();
diff --git a/src/NzbDrone.Core/Download/IDownloadClient.cs b/src/NzbDrone.Core/Download/IDownloadClient.cs
index aa46cff48..6703d8a22 100644
--- a/src/NzbDrone.Core/Download/IDownloadClient.cs
+++ b/src/NzbDrone.Core/Download/IDownloadClient.cs
@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using NzbDrone.Core.Indexers;
 using NzbDrone.Core.Parser.Model;
 using NzbDrone.Core.ThingiProvider;
diff --git a/src/NzbDrone.Core/HealthCheck/Checks/DownloadClientCheck.cs b/src/NzbDrone.Core/HealthCheck/Checks/DownloadClientCheck.cs
index 8a13ad82d..851c94e84 100644
--- a/src/NzbDrone.Core/HealthCheck/Checks/DownloadClientCheck.cs
+++ b/src/NzbDrone.Core/HealthCheck/Checks/DownloadClientCheck.cs
@@ -25,17 +25,19 @@ namespace NzbDrone.Core.HealthCheck.Checks
                 return new HealthCheck(GetType(), HealthCheckResult.Warning, "No download client is available");
             }
 
-            try
+            foreach (var downloadClient in downloadClients)
             {
-                foreach (var downloadClient in downloadClients)
+                try
                 {
                     downloadClient.GetItems();
                 }
-            }
-            catch (Exception ex)
-            {
-                _logger.Error("Unable to communicate with download client: ", ex);
-               return new HealthCheck(GetType(), HealthCheckResult.Error, "Unable to communicate with download client: " + ex.Message);
+                catch (Exception ex)
+                {
+                    var message = String.Format("Unable to communicate with {0}.", downloadClient.Definition.Name);
+
+                    _logger.Error(message, ex);
+                    return new HealthCheck(GetType(), HealthCheckResult.Error, message + " " + ex.Message);
+                }
             }
 
             return new HealthCheck(GetType());