Fixed: Better support for adding series that contain special characters

src/NzbDrone.Core.Test/MetadataSourceTests/TraktProxyFixture.cs

@@ -21,6 +21,7 @@ namespace NzbDrone.Core.Test.MetadataSourceTests
         [TestCase("Franklin & Bash", "Franklin & Bash")]
         [TestCase("Mr. D", "Mr. D")]
         [TestCase("Rob & Big", "Rob and Big")]
+        [TestCase("M*A*S*H", "M*A*S*H")]
         public void successful_search(string title, string expected)
         {
             var result = Subject.SearchForNewSeries(title);

src/NzbDrone.Core/MetadataSource/TraktProxy.cs

@@ -4,13 +4,12 @@ using System.IO;
 using System.Linq;
 using System.Net;
 using System.Text.RegularExpressions;
+using System.Web;
 using NLog;
 using NzbDrone.Common;
 using NzbDrone.Core.MediaCover;
 using NzbDrone.Core.MetadataSource.Trakt;
-using NzbDrone.Core.Notifications.Xbmc.Model;
 using NzbDrone.Core.Tv;
-using Omu.ValueInjecter;
 using RestSharp;
 using Episode = NzbDrone.Core.Tv.Episode;
 using NzbDrone.Core.Rest;
@@ -20,7 +19,8 @@ namespace NzbDrone.Core.MetadataSource
     public class TraktProxy : ISearchForNewSeries, IProvideSeriesInfo
     {
         private readonly Logger _logger;
-        private static readonly Regex InvalidSearchCharRegex = new Regex(@"[^a-zA-Z0-9\s-\.]", RegexOptions.Compiled);
+        private static readonly Regex CollapseSpaceRegex = new Regex(@"\s+", RegexOptions.Compiled);
+        private static readonly Regex InvalidSearchCharRegex = new Regex(@"(?:\*)", RegexOptions.Compiled);
 
         public TraktProxy(Logger logger)
         {
@@ -166,9 +166,9 @@ namespace NzbDrone.Core.MetadataSource
         private static string GetSearchTerm(string phrase)
         {
             phrase = phrase.RemoveAccent().ToLower();
-            phrase = phrase.Replace("&", "and");
+            phrase = InvalidSearchCharRegex.Replace(phrase, "");
-            phrase = InvalidSearchCharRegex.Replace(phrase, string.Empty);
+            phrase = CollapseSpaceRegex.Replace(phrase, " ").Trim().ToLower();
-            phrase = phrase.CleanSpaces().Replace(" ", "+");
+            phrase = HttpUtility.UrlEncode(phrase);
 
             return phrase;
         }