From aa522066ee2dfe9760085bb6722c3980ba20680b Mon Sep 17 00:00:00 2001 From: Robin Dadswell <19610103+RobinDadswell@users.noreply.github.com> Date: Tue, 4 May 2021 10:23:25 +0100 Subject: [PATCH] New: Mono health check moved from warning to error --- .../HealthCheck/Checks/MonoNotNetCoreCheckFixture.cs | 8 ++++---- .../HealthCheck/Checks/MonoNotNetCoreCheck.cs | 2 +- src/NzbDrone.Core/Localization/Core/en.json | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/NzbDrone.Core.Test/HealthCheck/Checks/MonoNotNetCoreCheckFixture.cs b/src/NzbDrone.Core.Test/HealthCheck/Checks/MonoNotNetCoreCheckFixture.cs index bb4ba066c..6e416acc1 100644 --- a/src/NzbDrone.Core.Test/HealthCheck/Checks/MonoNotNetCoreCheckFixture.cs +++ b/src/NzbDrone.Core.Test/HealthCheck/Checks/MonoNotNetCoreCheckFixture.cs @@ -18,9 +18,9 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks [Test] [Platform("Mono")] - public void should_log_warning_if_mono() + public void should_log_error_if_mono() { - Subject.Check().ShouldBeWarning(); + Subject.Check().ShouldBeError(); } [Test] @@ -41,7 +41,7 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks [Test] [Platform("Mono")] - public void should_log_warning_if_freebsd() + public void should_log_error_if_freebsd() { Mocker.GetMock() .Setup(x => x.StartAndCapture("uname", null, null)) @@ -52,7 +52,7 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks new ProcessOutputLine(ProcessOutputLevel.Standard, "FreeBSD") } }); - Subject.Check().ShouldBeWarning(); + Subject.Check().ShouldBeError(); } } } diff --git a/src/NzbDrone.Core/HealthCheck/Checks/MonoNotNetCoreCheck.cs b/src/NzbDrone.Core/HealthCheck/Checks/MonoNotNetCoreCheck.cs index da257b8d7..e3bd1d5f3 100644 --- a/src/NzbDrone.Core/HealthCheck/Checks/MonoNotNetCoreCheck.cs +++ b/src/NzbDrone.Core/HealthCheck/Checks/MonoNotNetCoreCheck.cs @@ -39,7 +39,7 @@ namespace NzbDrone.Core.HealthCheck.Checks } return new HealthCheck(GetType(), - HealthCheckResult.Warning, + HealthCheckResult.Error, _localizationService.GetLocalizedString("MonoNotNetCoreCheckMessage"), "#update_to_net_core_version"); } diff --git a/src/NzbDrone.Core/Localization/Core/en.json b/src/NzbDrone.Core/Localization/Core/en.json index e50c88033..7eb0c4091 100644 --- a/src/NzbDrone.Core/Localization/Core/en.json +++ b/src/NzbDrone.Core/Localization/Core/en.json @@ -527,7 +527,7 @@ "MonitoredOnly": "Monitored Only", "MonitoredStatus": "Monitored/Status", "MonitorMovie": "Monitor Movie", - "MonoNotNetCoreCheckMessage": "Please upgrade to the .NET Core version of Radarr", + "MonoNotNetCoreCheckMessage": "Please upgrade to the .NET Core version of Radarr, Mono versions will not be supported in the next release. ", "MonoTlsCheckMessage": "Radarr Mono 4.x tls workaround still enabled, consider removing MONO_TLS_PROVIDER=legacy environment option", "MonoVersion": "Mono Version", "MonoVersionCheckNotSupportedMessage": "Currently installed Mono version {0} is no longer supported. Please upgrade Mono to version {1}.",