From b393c11b275e7b07f7ef3012bc2472beb2e91003 Mon Sep 17 00:00:00 2001
From: "kay.one" <kay.one@gmail.com>
Date: Sat, 26 Jan 2013 13:07:34 -0800
Subject: [PATCH] added global script/ajax error handling.

---
 NzbDrone.Web/NzbDrone.Web.csproj              |  5 +-
 NzbDrone.Web/Views/V2/Index.cshtml            |  2 +
 .../_backboneApp/CassetteConfiguration.cs     |  1 +
 NzbDrone.Web/_backboneApp/Content/base.css    |  9 +++
 .../_backboneApp/Shared/ErrorModel.js         | 16 +++++
 .../_backboneApp/Shared/ErrorTemplate.html    |  4 ++
 NzbDrone.Web/_backboneApp/Shared/ErrorView.js | 68 +++++++++++++++++++
 NzbDrone.Web/_backboneApp/app.js              |  3 +-
 NzbDrone.Web/_backboneApp/errorHandler.js     | 15 ----
 NzbDrone.Web/_backboneApp/nzbdrone.logging.js |  3 +
 10 files changed, 109 insertions(+), 17 deletions(-)
 create mode 100644 NzbDrone.Web/_backboneApp/Shared/ErrorModel.js
 create mode 100644 NzbDrone.Web/_backboneApp/Shared/ErrorTemplate.html
 create mode 100644 NzbDrone.Web/_backboneApp/Shared/ErrorView.js
 delete mode 100644 NzbDrone.Web/_backboneApp/errorHandler.js
 create mode 100644 NzbDrone.Web/_backboneApp/nzbdrone.logging.js

diff --git a/NzbDrone.Web/NzbDrone.Web.csproj b/NzbDrone.Web/NzbDrone.Web.csproj
index 7b004ad0e..46c36bf71 100644
--- a/NzbDrone.Web/NzbDrone.Web.csproj
+++ b/NzbDrone.Web/NzbDrone.Web.csproj
@@ -194,7 +194,7 @@
     <Content Include="_backboneApp\AddSeries\SearchResultModel.js" />
     <Content Include="_backboneApp\AddSeries\SearchResultCollection.js" />
     <Content Include="_backboneApp\Content\Intelisense\bootstrap.css" />
-    <Content Include="_backboneApp\errorHandler.js" />
+    <Content Include="_backboneApp\nzbdrone.logging.js" />
     <Content Include="_backboneApp\JsLibraries\backbone.marionette.extend.js" />
     <Compile Include="_backboneApp\CassetteConfiguration.cs" />
     <Compile Include="Controllers\ImageController.cs" />
@@ -385,6 +385,9 @@
     <Content Include="_backboneApp\JsLibraries\backbone.js" />
     <Content Include="_backboneApp\JsLibraries\backbone.marionette.js" />
     <Content Include="_backboneApp\AddSeries\addSeriesLayoutTemplate.html" />
+    <Content Include="_backboneApp\Shared\ErrorModel.js" />
+    <Content Include="_backboneApp\Shared\ErrorTemplate.html" />
+    <Content Include="_backboneApp\Shared\ErrorView.js" />
     <Content Include="_backboneApp\Shared\SpinnerTemplate.html" />
     <Content Include="_backboneApp\Shared\SpinnerView.js" />
     <None Include="_backboneApp\JsLibraries\jquery-1.8.2.intellisense.js" />
diff --git a/NzbDrone.Web/Views/V2/Index.cshtml b/NzbDrone.Web/Views/V2/Index.cshtml
index 77c543cf4..57e0b76ec 100644
--- a/NzbDrone.Web/Views/V2/Index.cshtml
+++ b/NzbDrone.Web/Views/V2/Index.cshtml
@@ -50,6 +50,8 @@
         </div>
         <div id="content" class="row">
             <div class="span20">
+                <div id="error-region" class="row">
+                </div>
                 <div id="sub-menu-region" class="row">
                 </div>
                 <div class="row">
diff --git a/NzbDrone.Web/_backboneApp/CassetteConfiguration.cs b/NzbDrone.Web/_backboneApp/CassetteConfiguration.cs
index 0d2b54258..32c71a0cd 100644
--- a/NzbDrone.Web/_backboneApp/CassetteConfiguration.cs
+++ b/NzbDrone.Web/_backboneApp/CassetteConfiguration.cs
@@ -31,6 +31,7 @@ namespace NzbDrone.Web.Backbone.NzbDrone
 
             bundles.Add<ScriptBundle>(NZBDRONE, new[]{
                       APP_PATH + "\\AddSeries\\AddSeriesLayout.js",
+                      APP_PATH + "\\Shared\\ErrorView.js",
 
             
             });
diff --git a/NzbDrone.Web/_backboneApp/Content/base.css b/NzbDrone.Web/_backboneApp/Content/base.css
index 8d07034b3..bae5d5793 100644
--- a/NzbDrone.Web/_backboneApp/Content/base.css
+++ b/NzbDrone.Web/_backboneApp/Content/base.css
@@ -58,3 +58,12 @@ body {
     text-align: center;
     padding: 30px;
 }
+
+
+#error-region .alert {
+    margin: 10px;
+}
+
+#error-region .alert .icon-warning-sign {
+    padding-right: 10px;
+}
diff --git a/NzbDrone.Web/_backboneApp/Shared/ErrorModel.js b/NzbDrone.Web/_backboneApp/Shared/ErrorModel.js
new file mode 100644
index 000000000..96cbfa33e
--- /dev/null
+++ b/NzbDrone.Web/_backboneApp/Shared/ErrorModel.js
@@ -0,0 +1,16 @@
+/// <reference path="../app.js" />
+
+NzbDrone.Shared.ErrorCollection = Backbone.Collection.extend({
+
+    model: NzbDrone.Shared.ErrorModel,
+
+});
+
+
+NzbDrone.Shared.ErrorModel = Backbone.Model.extend({
+
+    defaults: {
+        "title": "NO_TITLE",
+        "message": "NO_MESSAGE",
+    }
+});
diff --git a/NzbDrone.Web/_backboneApp/Shared/ErrorTemplate.html b/NzbDrone.Web/_backboneApp/Shared/ErrorTemplate.html
new file mode 100644
index 000000000..c5a581e88
--- /dev/null
+++ b/NzbDrone.Web/_backboneApp/Shared/ErrorTemplate.html
@@ -0,0 +1,4 @@
+<div class="alert alert-error">
+    <button type="button" class="close" data-dismiss="alert">×</button>
+    <i class="icon-warning-sign" /><strong>{{title}}</strong> {{message}}
+</div>
diff --git a/NzbDrone.Web/_backboneApp/Shared/ErrorView.js b/NzbDrone.Web/_backboneApp/Shared/ErrorView.js
new file mode 100644
index 000000000..95b999341
--- /dev/null
+++ b/NzbDrone.Web/_backboneApp/Shared/ErrorView.js
@@ -0,0 +1,68 @@
+/// <reference path="../app.js" />
+/// <reference path="ErrorModel.js" />
+
+NzbDrone.Shared.ErrorItemView = Backbone.Marionette.ItemView.extend({
+    template: "Shared/ErrorTemplate",
+});
+
+NzbDrone.Shared.ErrorView = Backbone.Marionette.CollectionView.extend({
+
+    itemView: NzbDrone.Shared.ErrorItemView,
+
+    initialize: function () {
+
+        this.collection = new NzbDrone.Shared.ErrorCollection();
+        this.listenTo(this.collection, 'reset', this.render);
+    },
+});
+
+
+
+NzbDrone.addInitializer(function (options) {
+
+    console.log("initializing error handler");
+
+    NzbDrone.Shared.ErrorView.instance = new NzbDrone.Shared.ErrorView();
+
+    NzbDrone.errorRegion.show(NzbDrone.Shared.ErrorView.instance);
+
+});
+
+
+window.onerror = function (msg, url, line) {
+
+    var errorView = NzbDrone.Shared.ErrorView.instance;
+
+    if (errorView) {
+        var model = new NzbDrone.Shared.ErrorModel();
+
+        var a = document.createElement('a');
+        a.href = url;
+
+        model.set('title', a.pathname.split('/').pop() + " : " + line);
+        model.set('message', msg);
+        errorView.collection.add(model);
+    } else {
+        alert("Error: " + msg + "\nurl: " + url + "\nline #: " + line);
+    }
+
+    var suppressErrorAlert = false;
+    // If you return true, then error alerts (like in older versions of 
+    // Internet Explorer) will be suppressed.
+    return suppressErrorAlert;
+};
+
+$(document).ajaxError(function (event, XMLHttpRequest, ajaxOptionsa) {
+
+    var errorView = NzbDrone.Shared.ErrorView.instance;
+
+    var model = new NzbDrone.Shared.ErrorModel();
+    model.set('title', ajaxOptionsa.url + " : " + XMLHttpRequest.statusText);
+    model.set('message', XMLHttpRequest.responseText);
+    errorView.collection.add(model);
+
+    var suppressErrorAlert = false;
+    // If you return true, then error alerts (like in older versions of 
+    // Internet Explorer) will be suppressed.
+    return suppressErrorAlert;
+});
\ No newline at end of file
diff --git a/NzbDrone.Web/_backboneApp/app.js b/NzbDrone.Web/_backboneApp/app.js
index 7b59464c9..ac7d8c2a4 100644
--- a/NzbDrone.Web/_backboneApp/app.js
+++ b/NzbDrone.Web/_backboneApp/app.js
@@ -10,7 +10,7 @@
 /// <reference path="JsLibraries/backbone.marionette.extend.js" />
 /// <reference path="JsLibraries/backbone.modelbinder.js" />
 /// <reference path="JsLibraries/bootstrap.js" />
-/// <reference path="errorHandler.js" />
+/// <reference path="nzbdrone.logging.js" />
 
 if (typeof console == "undefined") {
     window.console = { log: function () { } };
@@ -74,6 +74,7 @@ NzbDrone.addInitializer(function (options) {
 
     NzbDrone.addRegions({
         mainRegion: "#main-region",
+        errorRegion: "#error-region",
     });
 
     NzbDrone.Router = new NzbDrone.Router();
diff --git a/NzbDrone.Web/_backboneApp/errorHandler.js b/NzbDrone.Web/_backboneApp/errorHandler.js
deleted file mode 100644
index 955a67e8d..000000000
--- a/NzbDrone.Web/_backboneApp/errorHandler.js
+++ /dev/null
@@ -1,15 +0,0 @@
-/// <reference path="JsLibraries/jquery.js" />
-
-window.onerror = function (msg, url, line) {
-    alert("Error: " + msg + "\nurl: " + url + "\nline #: " + line);
-
-
-    var suppressErrorAlert = false;
-    // If you return true, then error alerts (like in older versions of 
-    // Internet Explorer) will be suppressed.
-    return suppressErrorAlert;
-};
-
-$(document).ajaxSuccess(function (event, XMLHttpRequest, ajaxOptionsa) {
-    console.log(ajaxOptionsa);
-});
\ No newline at end of file
diff --git a/NzbDrone.Web/_backboneApp/nzbdrone.logging.js b/NzbDrone.Web/_backboneApp/nzbdrone.logging.js
new file mode 100644
index 000000000..69069ac09
--- /dev/null
+++ b/NzbDrone.Web/_backboneApp/nzbdrone.logging.js
@@ -0,0 +1,3 @@
+$(document).ajaxSuccess(function (event, XMLHttpRequest, ajaxOptionsa) {
+    console.log(ajaxOptionsa);
+});
\ No newline at end of file