better error messages when download client connection fails

pull/3113/head
Keivan Beigi 10 years ago
parent 690569cbbc
commit dcf434abd3

@ -185,15 +185,15 @@ namespace NzbDrone.Core.Download.Clients.Nzbget
request.JsonSerializer = new JsonNetSerializer();
request.RequestFormat = DataFormat.Json;
request.AddBody(jsonRequest);
return request;
}
private void CheckForError(IRestResponse response)
{
if (response.ResponseStatus != ResponseStatus.Completed)
if (response.ErrorException != null)
{
throw new DownloadClientException("Unable to connect to NzbGet, please check your settings", response.ErrorException);
throw new DownloadClientException("Unable to connect to NzbGet. " + response.ErrorException.Message, response.ErrorException);
}
if (response.StatusCode == System.Net.HttpStatusCode.Unauthorized)

@ -15,9 +15,9 @@ namespace NzbDrone.Core.HealthCheck.Checks
public override HealthCheck Check()
{
var downloadClients = _downloadClientProvider.GetDownloadClients();
var downloadClients = _downloadClientProvider.GetDownloadClients().ToList();
if (downloadClients.Count() == 0)
if (!downloadClients.Any())
{
return new HealthCheck(GetType(), HealthCheckResult.Warning, "No download client is available");
}
@ -29,9 +29,9 @@ namespace NzbDrone.Core.HealthCheck.Checks
downloadClient.GetItems();
}
}
catch (Exception)
catch (Exception e)
{
return new HealthCheck(GetType(), HealthCheckResult.Error, "Unable to communicate with download client");
return new HealthCheck(GetType(), HealthCheckResult.Error, "Unable to communicate with download client " + e.Message);
}
return new HealthCheck(GetType());

Loading…
Cancel
Save