Fixed: Close database connection in housekeeping tasks

src/NzbDrone.Core/Housekeeping/Housekeepers/CleanupDownloadClientUnavailablePendingReleases.cs

@@ -16,29 +16,30 @@ namespace NzbDrone.Core.Housekeeping.Housekeepers
 
         public void Clean()
         {
-            var mapper = _database.OpenConnection();
-
-            if (_database.DatabaseType == DatabaseType.PostgreSQL)
+            using (var mapper = _database.OpenConnection())
             {
+                if (_database.DatabaseType == DatabaseType.PostgreSQL)
+                {
+                    mapper.Execute(@"DELETE FROM ""PendingReleases""
+                                WHERE ""Added"" < @TwoWeeksAgo
+                                AND ""Reason"" = ANY (@Reasons)",
+                              new
+                              {
+                                  TwoWeeksAgo = DateTime.UtcNow.AddDays(-14),
+                                  Reasons = new[] { (int)PendingReleaseReason.DownloadClientUnavailable, (int)PendingReleaseReason.Fallback }
+                              });
+                }
+                else
+                {
                 mapper.Execute(@"DELETE FROM ""PendingReleases""
-                            WHERE ""Added"" < @TwoWeeksAgo
-                            AND ""Reason"" = ANY (@Reasons)",
-                          new
-                          {
-                              TwoWeeksAgo = DateTime.UtcNow.AddDays(-14),
-                              Reasons = new[] { (int)PendingReleaseReason.DownloadClientUnavailable, (int)PendingReleaseReason.Fallback }
-                          });
-            }
-            else
-            {
-            mapper.Execute(@"DELETE FROM ""PendingReleases""
-                            WHERE ""Added"" < @TwoWeeksAgo
-                            AND ""REASON"" IN @Reasons",
-                          new
-                          {
-                              TwoWeeksAgo = DateTime.UtcNow.AddDays(-14),
-                              Reasons = new[] { (int)PendingReleaseReason.DownloadClientUnavailable, (int)PendingReleaseReason.Fallback }
-                          });
+                                WHERE ""Added"" < @TwoWeeksAgo
+                                AND ""REASON"" IN @Reasons",
+                              new
+                              {
+                                  TwoWeeksAgo = DateTime.UtcNow.AddDays(-14),
+                                  Reasons = new[] { (int)PendingReleaseReason.DownloadClientUnavailable, (int)PendingReleaseReason.Fallback }
+                              });
+                }
             }
         }
     }

src/NzbDrone.Core/Housekeeping/Housekeepers/CleanupOrphanedDownloadClientStatus.cs

@@ -14,14 +14,15 @@ namespace NzbDrone.Core.Housekeeping.Housekeepers
 
         public void Clean()
         {
-            var mapper = _database.OpenConnection();
-
-            mapper.Execute(@"DELETE FROM ""DownloadClientStatus""
-                                     WHERE ""Id"" IN (
-                                     SELECT ""DownloadClientStatus"".""Id"" FROM ""DownloadClientStatus""
-                                     LEFT OUTER JOIN ""DownloadClients""
-                                     ON ""DownloadClientStatus"".""ProviderId"" = ""DownloadClients"".""Id""
-                                     WHERE ""DownloadClients"".""Id"" IS NULL)");
+            using (var mapper = _database.OpenConnection())
+            {
+                mapper.Execute(@"DELETE FROM ""DownloadClientStatus""
+                                         WHERE ""Id"" IN (
+                                         SELECT ""DownloadClientStatus"".""Id"" FROM ""DownloadClientStatus""
+                                         LEFT OUTER JOIN ""DownloadClients""
+                                         ON ""DownloadClientStatus"".""ProviderId"" = ""DownloadClients"".""Id""
+                                         WHERE ""DownloadClients"".""Id"" IS NULL)");
+            }
         }
     }
 }

src/NzbDrone.Core/Housekeeping/Housekeepers/CleanupUnusedTags.cs

@@ -18,30 +18,31 @@ namespace NzbDrone.Core.Housekeeping.Housekeepers
 
         public void Clean()
         {
-            var mapper = _database.OpenConnection();
-
-            var usedTags = new[] { "Movies", "Notifications", "DelayProfiles", "Restrictions", "ImportLists", "Indexers" }
-                .SelectMany(v => GetUsedTags(v, mapper))
-                .Distinct()
-                .ToList();
-
-            if (usedTags.Any())
+            using (var mapper = _database.OpenConnection())
             {
-                var usedTagsList = usedTags.Select(d => d.ToString()).Join(",");
+                var usedTags = new[] { "Movies", "Notifications", "DelayProfiles", "Restrictions", "ImportLists", "Indexers" }
+                    .SelectMany(v => GetUsedTags(v, mapper))
+                    .Distinct()
+                    .ToList();
 
-                if (_database.DatabaseType == DatabaseType.PostgreSQL)
+                if (usedTags.Any())
                 {
-                    mapper.Execute($"DELETE FROM \"Tags\" WHERE NOT \"Id\" = ANY (\'{{{usedTagsList}}}\'::int[])");
+                    var usedTagsList = usedTags.Select(d => d.ToString()).Join(",");
+
+                    if (_database.DatabaseType == DatabaseType.PostgreSQL)
+                    {
+                        mapper.Execute($"DELETE FROM \"Tags\" WHERE NOT \"Id\" = ANY (\'{{{usedTagsList}}}\'::int[])");
+                    }
+                    else
+                    {
+                        mapper.Execute($"DELETE FROM \"Tags\" WHERE NOT \"Id\" IN ({usedTagsList})");
+                    }
                 }
                 else
                 {
-                    mapper.Execute($"DELETE FROM \"Tags\" WHERE NOT \"Id\" IN ({usedTagsList})");
+                    mapper.Execute("DELETE FROM \"Tags\"");
                 }
             }
-            else
-            {
-                mapper.Execute("DELETE FROM \"Tags\"");
-            }
         }
 
         private int[] GetUsedTags(string table, IDbConnection mapper)