From ea18a366c4edece3726220bb7750b6039f7c8625 Mon Sep 17 00:00:00 2001 From: Qstick Date: Thu, 2 Apr 2020 22:45:27 -0400 Subject: [PATCH] fixup! Code Smells --- src/NzbDrone.Core/Update/ConfigureUpdateMechanism.cs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/NzbDrone.Core/Update/ConfigureUpdateMechanism.cs b/src/NzbDrone.Core/Update/ConfigureUpdateMechanism.cs index 1f001d280..79e91bce1 100644 --- a/src/NzbDrone.Core/Update/ConfigureUpdateMechanism.cs +++ b/src/NzbDrone.Core/Update/ConfigureUpdateMechanism.cs @@ -1,8 +1,6 @@ using System; using System.Collections.Generic; using System.Linq; -using System.Text; -using System.Threading.Tasks; using NLog; using NzbDrone.Common.Extensions; using NzbDrone.Core.Configuration; @@ -17,9 +15,9 @@ namespace NzbDrone.Core.Update public class UpdaterConfigProvider : IUpdaterConfigProvider, IHandle { - private Logger _logger; - private IConfigFileProvider _configFileProvider; - private IDeploymentInfoProvider _deploymentInfoProvider; + private readonly Logger _logger; + private readonly IConfigFileProvider _configFileProvider; + private readonly IDeploymentInfoProvider _deploymentInfoProvider; public UpdaterConfigProvider(IDeploymentInfoProvider deploymentInfoProvider, IConfigFileProvider configFileProvider, Logger logger) { @@ -53,7 +51,7 @@ namespace NzbDrone.Core.Update { var currentBranch = _configFileProvider.Branch; var packageBranch = _deploymentInfoProvider.PackageBranch; - if (packageBranch.IsNotNullOrWhiteSpace() & packageBranch != currentBranch) + if (packageBranch.IsNotNullOrWhiteSpace() && packageBranch != currentBranch) { _logger.Info("External updater uses branch {0} instead of the currently selected {1}, changing to {0}.", packageBranch, currentBranch); ChangeBranch(packageBranch);