From 916acdb81a98d108e50e5861d01cf34e56a7690e Mon Sep 17 00:00:00 2001
From: Dtaggart <Dustin.Taggart@live.com>
Date: Thu, 10 Sep 2020 18:04:53 -0400
Subject: [PATCH] New: Index priority

---
 .../Indexers/EditIndexerModalContent.js       | 17 ++++++++-
 .../src/Settings/Indexers/Indexers/Indexer.js | 12 +++++-
 .../Settings/Indexers/Indexers/Indexers.js    |  3 ++
 .../PrioritizeDownloadDecisionFixture.cs      | 37 ++++++++++++++++++-
 .../Migration/003_add_priority_to_indexers.cs | 14 +++++++
 .../DownloadDecisionComparer.cs               |  6 +++
 .../Download/ProcessDownloadDecisions.cs      |  1 +
 src/NzbDrone.Core/Indexers/IndexerBase.cs     |  2 +
 .../Indexers/IndexerDefinition.cs             |  1 +
 src/NzbDrone.Core/Parser/Model/ReleaseInfo.cs |  1 +
 .../Indexers/IndexerResource.cs               |  3 ++
 11 files changed, 93 insertions(+), 4 deletions(-)
 create mode 100644 src/NzbDrone.Core/Datastore/Migration/003_add_priority_to_indexers.cs

diff --git a/frontend/src/Settings/Indexers/Indexers/EditIndexerModalContent.js b/frontend/src/Settings/Indexers/Indexers/EditIndexerModalContent.js
index 218507a65..d7fab32ab 100644
--- a/frontend/src/Settings/Indexers/Indexers/EditIndexerModalContent.js
+++ b/frontend/src/Settings/Indexers/Indexers/EditIndexerModalContent.js
@@ -42,7 +42,8 @@ function EditIndexerModalContent(props) {
     enableInteractiveSearch,
     supportsRss,
     supportsSearch,
-    fields
+    fields,
+    priority
   } = item;
 
   return (
@@ -131,7 +132,21 @@ function EditIndexerModalContent(props) {
                   );
                 })
               }
+               <FormGroup
+                  advancedSettings={advancedSettings}
+                  isAdvanced={true}>
+                <FormLabel>Indexer Priority</FormLabel>
 
+                <FormInputGroup
+                  type={inputTypes.NUMBER}
+                  name="priority"
+                  helpText="Indexer Priority from 1 (Highest) to 50 (Lowest). Default: 25."
+                  min={1}
+                  max={50}
+                  {...priority}
+                  onChange={onInputChange}
+                />
+              </FormGroup>
             </Form>
         }
       </ModalBody>
diff --git a/frontend/src/Settings/Indexers/Indexers/Indexer.js b/frontend/src/Settings/Indexers/Indexers/Indexer.js
index 8d7e5719d..5c762260c 100644
--- a/frontend/src/Settings/Indexers/Indexers/Indexer.js
+++ b/frontend/src/Settings/Indexers/Indexers/Indexer.js
@@ -58,7 +58,9 @@ class Indexer extends Component {
       enableAutomaticSearch,
       enableInteractiveSearch,
       supportsRss,
-      supportsSearch
+      supportsSearch,
+      priority,
+      showPriority
     } = this.props;
 
     return (
@@ -93,7 +95,13 @@ class Indexer extends Component {
                 Interactive Search
               </Label>
           }
-
+          
+          {
+            showPriority &&
+              <Label kind={kinds.DEFAULT}>
+                Priority: {priority}
+              </Label>
+          }
           {
             !enableRss && !enableAutomaticSearch && !enableInteractiveSearch &&
               <Label
diff --git a/frontend/src/Settings/Indexers/Indexers/Indexers.js b/frontend/src/Settings/Indexers/Indexers/Indexers.js
index 3f020d7ac..29c0ff2bc 100644
--- a/frontend/src/Settings/Indexers/Indexers/Indexers.js
+++ b/frontend/src/Settings/Indexers/Indexers/Indexers.js
@@ -56,6 +56,8 @@ class Indexers extends Component {
       isAddIndexerModalOpen,
       isEditIndexerModalOpen
     } = this.state;
+    
+    const showPriority = items.some((index) => index.priority != 25);
 
     return (
       <FieldSet legend="Indexers">
@@ -70,6 +72,7 @@ class Indexers extends Component {
                   <Indexer
                     key={item.id}
                     {...item}
+                    showPriority={showPriority}
                     onConfirmDeleteIndexer={onConfirmDeleteIndexer}
                   />
                 );
diff --git a/src/NzbDrone.Core.Test/DecisionEngineTests/PrioritizeDownloadDecisionFixture.cs b/src/NzbDrone.Core.Test/DecisionEngineTests/PrioritizeDownloadDecisionFixture.cs
index f11bcd070..9c3b41b24 100644
--- a/src/NzbDrone.Core.Test/DecisionEngineTests/PrioritizeDownloadDecisionFixture.cs
+++ b/src/NzbDrone.Core.Test/DecisionEngineTests/PrioritizeDownloadDecisionFixture.cs
@@ -34,7 +34,7 @@ namespace NzbDrone.Core.Test.DecisionEngineTests
                             .Build();
         }
 
-        private RemoteBook GivenRemoteAlbum(List<Book> albums, QualityModel quality, int age = 0, long size = 0, DownloadProtocol downloadProtocol = DownloadProtocol.Usenet)
+        private RemoteBook GivenRemoteAlbum(List<Book> albums, QualityModel quality, int age = 0, long size = 0, DownloadProtocol downloadProtocol = DownloadProtocol.Usenet, int indexerPriority = 25)
         {
             var remoteBook = new RemoteBook();
             remoteBook.ParsedBookInfo = new ParsedBookInfo();
@@ -47,6 +47,7 @@ namespace NzbDrone.Core.Test.DecisionEngineTests
             remoteBook.Release.PublishDate = DateTime.Now.AddDays(-age);
             remoteBook.Release.Size = size;
             remoteBook.Release.DownloadProtocol = downloadProtocol;
+            remoteBook.Release.IndexerPriority = indexerPriority;
 
             remoteBook.Author = Builder<Author>.CreateNew()
                                                 .With(e => e.QualityProfile = new QualityProfile
@@ -476,5 +477,39 @@ namespace NzbDrone.Core.Test.DecisionEngineTests
             qualifiedReports.First().RemoteBook.ParsedBookInfo.Quality.Revision.Version.Should().Be(1);
             qualifiedReports.First().RemoteBook.PreferredWordScore.Should().Be(10);
         }
+
+        [Test]
+        public void sort_download_decisions_based_on_indexer_priority()
+        {
+            var remoteAlbum1 = GivenRemoteAlbum(new List<Book> { GivenAlbum(1) }, new QualityModel(Quality.AZW3, new Revision(1)), indexerPriority: 25);
+            var remoteAlbum2 = GivenRemoteAlbum(new List<Book> { GivenAlbum(1) }, new QualityModel(Quality.AZW3, new Revision(1)), indexerPriority: 50);
+            var remoteAlbum3 = GivenRemoteAlbum(new List<Book> { GivenAlbum(1) }, new QualityModel(Quality.AZW3, new Revision(1)), indexerPriority: 1);
+
+            var decisions = new List<DownloadDecision>();
+            decisions.AddRange(new[] { new DownloadDecision(remoteAlbum1), new DownloadDecision(remoteAlbum2), new DownloadDecision(remoteAlbum3) });
+
+            var qualifiedReports = Subject.PrioritizeDecisions(decisions);
+            qualifiedReports.First().RemoteBook.Should().Be(remoteAlbum3);
+            qualifiedReports.Skip(1).First().RemoteBook.Should().Be(remoteAlbum1);
+            qualifiedReports.Last().RemoteBook.Should().Be(remoteAlbum2);
+        }
+
+        [Test]
+        public void ensure_download_decisions_indexer_priority_is_not_perfered_over_quality()
+        {
+            var remoteAlbum1 = GivenRemoteAlbum(new List<Book> { GivenAlbum(1) }, new QualityModel(Quality.EPUB, new Revision(1)), indexerPriority: 25);
+            var remoteAlbum2 = GivenRemoteAlbum(new List<Book> { GivenAlbum(1) }, new QualityModel(Quality.AZW3, new Revision(1)), indexerPriority: 50);
+            var remoteAlbum3 = GivenRemoteAlbum(new List<Book> { GivenAlbum(1) }, new QualityModel(Quality.PDF, new Revision(1)), indexerPriority: 1);
+            var remoteAlbum4 = GivenRemoteAlbum(new List<Book> { GivenAlbum(1) }, new QualityModel(Quality.AZW3, new Revision(1)), indexerPriority: 25);
+
+            var decisions = new List<DownloadDecision>();
+            decisions.AddRange(new[] { new DownloadDecision(remoteAlbum1), new DownloadDecision(remoteAlbum2), new DownloadDecision(remoteAlbum3), new DownloadDecision(remoteAlbum4) });
+
+            var qualifiedReports = Subject.PrioritizeDecisions(decisions);
+            qualifiedReports.First().RemoteBook.Should().Be(remoteAlbum4);
+            qualifiedReports.Skip(1).First().RemoteBook.Should().Be(remoteAlbum2);
+            qualifiedReports.Skip(2).First().RemoteBook.Should().Be(remoteAlbum1);
+            qualifiedReports.Last().RemoteBook.Should().Be(remoteAlbum3);
+        }
     }
 }
diff --git a/src/NzbDrone.Core/Datastore/Migration/003_add_priority_to_indexers.cs b/src/NzbDrone.Core/Datastore/Migration/003_add_priority_to_indexers.cs
new file mode 100644
index 000000000..86376a20c
--- /dev/null
+++ b/src/NzbDrone.Core/Datastore/Migration/003_add_priority_to_indexers.cs
@@ -0,0 +1,14 @@
+using FluentMigrator;
+using NzbDrone.Core.Datastore.Migration.Framework;
+
+namespace NzbDrone.Core.Datastore.Migration
+{
+    [Migration(003)]
+    public class add_priority_to_indexers : NzbDroneMigrationBase
+    {
+        protected override void MainDbUpgrade()
+        {
+            Alter.Table("Indexers").AddColumn("Priority").AsInt32().NotNullable().WithDefaultValue(25);
+        }
+    }
+}
diff --git a/src/NzbDrone.Core/DecisionEngine/DownloadDecisionComparer.cs b/src/NzbDrone.Core/DecisionEngine/DownloadDecisionComparer.cs
index 41d95bc6a..f707aacc9 100644
--- a/src/NzbDrone.Core/DecisionEngine/DownloadDecisionComparer.cs
+++ b/src/NzbDrone.Core/DecisionEngine/DownloadDecisionComparer.cs
@@ -30,6 +30,7 @@ namespace NzbDrone.Core.DecisionEngine
                 CompareQuality,
                 ComparePreferredWordScore,
                 CompareProtocol,
+                CompareIndexerPriority,
                 ComparePeersIfTorrent,
                 CompareBookCount,
                 CompareAgeIfUsenet,
@@ -59,6 +60,11 @@ namespace NzbDrone.Core.DecisionEngine
             return comparers.Select(comparer => comparer).FirstOrDefault(result => result != 0);
         }
 
+        private int CompareIndexerPriority(DownloadDecision x, DownloadDecision y)
+        {
+            return CompareByReverse(x.RemoteBook.Release, y.RemoteBook.Release, release => release.IndexerPriority);
+        }
+
         private int CompareQuality(DownloadDecision x, DownloadDecision y)
         {
             if (_configService.DownloadPropersAndRepacks == ProperDownloadTypes.DoNotPrefer)
diff --git a/src/NzbDrone.Core/Download/ProcessDownloadDecisions.cs b/src/NzbDrone.Core/Download/ProcessDownloadDecisions.cs
index 1cd1aea0c..763efa23e 100644
--- a/src/NzbDrone.Core/Download/ProcessDownloadDecisions.cs
+++ b/src/NzbDrone.Core/Download/ProcessDownloadDecisions.cs
@@ -74,6 +74,7 @@ namespace NzbDrone.Core.Download
 
                 try
                 {
+                    _logger.Trace("Grabbing from Indexer {0} at priority {1}.", remoteBook.Release.Indexer, remoteBook.Release.IndexerPriority);
                     _downloadService.DownloadReport(remoteBook);
                     grabbed.Add(report);
                 }
diff --git a/src/NzbDrone.Core/Indexers/IndexerBase.cs b/src/NzbDrone.Core/Indexers/IndexerBase.cs
index 6f0ddbf8a..caf9c71fb 100644
--- a/src/NzbDrone.Core/Indexers/IndexerBase.cs
+++ b/src/NzbDrone.Core/Indexers/IndexerBase.cs
@@ -22,6 +22,7 @@ namespace NzbDrone.Core.Indexers
 
         public abstract string Name { get; }
         public abstract DownloadProtocol Protocol { get; }
+        public int Priority { get; set; }
 
         public abstract bool SupportsRss { get; }
         public abstract bool SupportsSearch { get; }
@@ -80,6 +81,7 @@ namespace NzbDrone.Core.Indexers
                 c.IndexerId = Definition.Id;
                 c.Indexer = Definition.Name;
                 c.DownloadProtocol = Protocol;
+                c.IndexerPriority = ((IndexerDefinition)Definition).Priority;
             });
 
             return result;
diff --git a/src/NzbDrone.Core/Indexers/IndexerDefinition.cs b/src/NzbDrone.Core/Indexers/IndexerDefinition.cs
index 019a61727..3bcd56b52 100644
--- a/src/NzbDrone.Core/Indexers/IndexerDefinition.cs
+++ b/src/NzbDrone.Core/Indexers/IndexerDefinition.cs
@@ -10,6 +10,7 @@ namespace NzbDrone.Core.Indexers
         public DownloadProtocol Protocol { get; set; }
         public bool SupportsRss { get; set; }
         public bool SupportsSearch { get; set; }
+        public int Priority { get; set; } = 25;
 
         public override bool Enable => EnableRss || EnableAutomaticSearch || EnableInteractiveSearch;
 
diff --git a/src/NzbDrone.Core/Parser/Model/ReleaseInfo.cs b/src/NzbDrone.Core/Parser/Model/ReleaseInfo.cs
index e514e2872..f2521fe1d 100644
--- a/src/NzbDrone.Core/Parser/Model/ReleaseInfo.cs
+++ b/src/NzbDrone.Core/Parser/Model/ReleaseInfo.cs
@@ -17,6 +17,7 @@ namespace NzbDrone.Core.Parser.Model
         public string Indexer { get; set; }
         public string Author { get; set; }
         public string Book { get; set; }
+        public int IndexerPriority { get; set; }
         public DownloadProtocol DownloadProtocol { get; set; }
         public DateTime PublishDate { get; set; }
 
diff --git a/src/Readarr.Api.V1/Indexers/IndexerResource.cs b/src/Readarr.Api.V1/Indexers/IndexerResource.cs
index 48c3f3703..f643ed70d 100644
--- a/src/Readarr.Api.V1/Indexers/IndexerResource.cs
+++ b/src/Readarr.Api.V1/Indexers/IndexerResource.cs
@@ -10,6 +10,7 @@ namespace Readarr.Api.V1.Indexers
         public bool SupportsRss { get; set; }
         public bool SupportsSearch { get; set; }
         public DownloadProtocol Protocol { get; set; }
+        public int Priority { get; set; }
     }
 
     public class IndexerResourceMapper : ProviderResourceMapper<IndexerResource, IndexerDefinition>
@@ -29,6 +30,7 @@ namespace Readarr.Api.V1.Indexers
             resource.SupportsRss = definition.SupportsRss;
             resource.SupportsSearch = definition.SupportsSearch;
             resource.Protocol = definition.Protocol;
+            resource.Priority = definition.Priority;
 
             return resource;
         }
@@ -45,6 +47,7 @@ namespace Readarr.Api.V1.Indexers
             definition.EnableRss = resource.EnableRss;
             definition.EnableAutomaticSearch = resource.EnableAutomaticSearch;
             definition.EnableInteractiveSearch = resource.EnableInteractiveSearch;
+            definition.Priority = resource.Priority;
 
             return definition;
         }