From af1f389f8e2ebd872f7e1e76be52394885f3295a Mon Sep 17 00:00:00 2001
From: Bogdan <mynameisbogdan@users.noreply.github.com>
Date: Sun, 30 Jun 2024 05:35:37 +0300
Subject: [PATCH] Fixed: Validate metadata and quality profiles for root
 folders

Don't allow `0` as possible value for metadata and quality profiles, and permit to edit root folders with bad values in UI.
---
 .../ImportLists/Manage/ManageImportListsModalRow.tsx      | 5 +++--
 .../src/Settings/MediaManagement/RootFolder/RootFolder.js | 8 ++++----
 src/NzbDrone.Core/Books/Services/BookCutoffService.cs     | 8 ++++----
 .../MediaFiles/BookImport/ImportDecisionMaker.cs          | 4 ++--
 .../Profiles/Qualities/QualityProfileService.cs           | 4 ++--
 .../Validation/QualityProfileExistsValidator.cs           | 8 ++++----
 .../Profiles/Quality/QualityProfileController.cs          | 4 ++--
 .../Profiles/Quality/QualityProfileSchemaController.cs    | 8 ++++----
 src/Readarr.Api.V1/RootFolders/RootFolderController.cs    | 6 ++++--
 9 files changed, 29 insertions(+), 26 deletions(-)

diff --git a/frontend/src/Settings/ImportLists/ImportLists/Manage/ManageImportListsModalRow.tsx b/frontend/src/Settings/ImportLists/ImportLists/Manage/ManageImportListsModalRow.tsx
index 3a37c406f..ad188e2b2 100644
--- a/frontend/src/Settings/ImportLists/ImportLists/Manage/ManageImportListsModalRow.tsx
+++ b/frontend/src/Settings/ImportLists/ImportLists/Manage/ManageImportListsModalRow.tsx
@@ -8,6 +8,7 @@ import TagListConnector from 'Components/TagListConnector';
 import { createMetadataProfileSelectorForHook } from 'Store/Selectors/createMetadataProfileSelector';
 import { createQualityProfileSelectorForHook } from 'Store/Selectors/createQualityProfileSelector';
 import { SelectStateInputProps } from 'typings/props';
+import translate from 'Utilities/String/translate';
 import styles from './ManageImportListsModalRow.css';
 
 interface ManageImportListsModalRowProps {
@@ -70,7 +71,7 @@ function ManageImportListsModalRow(props: ManageImportListsModalRowProps) {
       </TableRowCell>
 
       <TableRowCell className={styles.qualityProfileId}>
-        {qualityProfile?.name ?? 'None'}
+        {qualityProfile?.name ?? translate('None')}
       </TableRowCell>
 
       <TableRowCell className={styles.metadataProfileId}>
@@ -82,7 +83,7 @@ function ManageImportListsModalRow(props: ManageImportListsModalRowProps) {
       </TableRowCell>
 
       <TableRowCell className={styles.enableAutomaticAdd}>
-        {enableAutomaticAdd ? 'Yes' : 'No'}
+        {enableAutomaticAdd ? translate('Yes') : translate('No')}
       </TableRowCell>
 
       <TableRowCell className={styles.tags}>
diff --git a/frontend/src/Settings/MediaManagement/RootFolder/RootFolder.js b/frontend/src/Settings/MediaManagement/RootFolder/RootFolder.js
index 20cefc53f..47e5dfcf1 100644
--- a/frontend/src/Settings/MediaManagement/RootFolder/RootFolder.js
+++ b/frontend/src/Settings/MediaManagement/RootFolder/RootFolder.js
@@ -75,12 +75,12 @@ class RootFolder extends Component {
             {path}
           </Label>
 
-          <Label kind={kinds.SUCCESS}>
-            {qualityProfile.name}
+          <Label kind={qualityProfile?.name ? kinds.SUCCESS : kinds.DANGER}>
+            {qualityProfile?.name || translate('None')}
           </Label>
 
-          <Label kind={kinds.SUCCESS}>
-            {metadataProfile.name}
+          <Label kind={metadataProfile?.name ? kinds.SUCCESS : kinds.DANGER}>
+            {metadataProfile?.name || translate('None')}
           </Label>
         </div>
 
diff --git a/src/NzbDrone.Core/Books/Services/BookCutoffService.cs b/src/NzbDrone.Core/Books/Services/BookCutoffService.cs
index dfa25e1f5..f107edf6a 100644
--- a/src/NzbDrone.Core/Books/Services/BookCutoffService.cs
+++ b/src/NzbDrone.Core/Books/Services/BookCutoffService.cs
@@ -15,18 +15,18 @@ namespace NzbDrone.Core.Books
     public class BookCutoffService : IBookCutoffService
     {
         private readonly IBookRepository _bookRepository;
-        private readonly IProfileService _profileService;
+        private readonly IQualityProfileService _qualityProfileService;
 
-        public BookCutoffService(IBookRepository bookRepository, IProfileService profileService)
+        public BookCutoffService(IBookRepository bookRepository, IQualityProfileService qualityProfileService)
         {
             _bookRepository = bookRepository;
-            _profileService = profileService;
+            _qualityProfileService = qualityProfileService;
         }
 
         public PagingSpec<Book> BooksWhereCutoffUnmet(PagingSpec<Book> pagingSpec)
         {
             var qualitiesBelowCutoff = new List<QualitiesBelowCutoff>();
-            var profiles = _profileService.All();
+            var profiles = _qualityProfileService.All();
 
             //Get all items less than the cutoff
             foreach (var profile in profiles)
diff --git a/src/NzbDrone.Core/MediaFiles/BookImport/ImportDecisionMaker.cs b/src/NzbDrone.Core/MediaFiles/BookImport/ImportDecisionMaker.cs
index 195c9e5a2..8bc31b34a 100644
--- a/src/NzbDrone.Core/MediaFiles/BookImport/ImportDecisionMaker.cs
+++ b/src/NzbDrone.Core/MediaFiles/BookImport/ImportDecisionMaker.cs
@@ -53,7 +53,7 @@ namespace NzbDrone.Core.MediaFiles.BookImport
         private readonly IAugmentingService _augmentingService;
         private readonly IIdentificationService _identificationService;
         private readonly IRootFolderService _rootFolderService;
-        private readonly IProfileService _qualityProfileService;
+        private readonly IQualityProfileService _qualityProfileService;
         private readonly Logger _logger;
 
         public ImportDecisionMaker(IEnumerable<IImportDecisionEngineSpecification<LocalBook>> trackSpecifications,
@@ -63,7 +63,7 @@ namespace NzbDrone.Core.MediaFiles.BookImport
                                    IAugmentingService augmentingService,
                                    IIdentificationService identificationService,
                                    IRootFolderService rootFolderService,
-                                   IProfileService qualityProfileService,
+                                   IQualityProfileService qualityProfileService,
                                    Logger logger)
         {
             _trackSpecifications = trackSpecifications;
diff --git a/src/NzbDrone.Core/Profiles/Qualities/QualityProfileService.cs b/src/NzbDrone.Core/Profiles/Qualities/QualityProfileService.cs
index 65ea84a26..937dfb6c4 100644
--- a/src/NzbDrone.Core/Profiles/Qualities/QualityProfileService.cs
+++ b/src/NzbDrone.Core/Profiles/Qualities/QualityProfileService.cs
@@ -13,7 +13,7 @@ using NzbDrone.Core.RootFolders;
 
 namespace NzbDrone.Core.Profiles.Qualities
 {
-    public interface IProfileService
+    public interface IQualityProfileService
     {
         QualityProfile Add(QualityProfile profile);
         void Update(QualityProfile profile);
@@ -24,7 +24,7 @@ namespace NzbDrone.Core.Profiles.Qualities
         QualityProfile GetDefaultProfile(string name, Quality cutoff = null, params Quality[] allowed);
     }
 
-    public class QualityProfileService : IProfileService,
+    public class QualityProfileService : IQualityProfileService,
                                          IHandle<ApplicationStartedEvent>,
                                          IHandle<CustomFormatAddedEvent>,
                                          IHandle<CustomFormatDeletedEvent>
diff --git a/src/NzbDrone.Core/Validation/QualityProfileExistsValidator.cs b/src/NzbDrone.Core/Validation/QualityProfileExistsValidator.cs
index acfcdc402..6efb72c32 100644
--- a/src/NzbDrone.Core/Validation/QualityProfileExistsValidator.cs
+++ b/src/NzbDrone.Core/Validation/QualityProfileExistsValidator.cs
@@ -5,11 +5,11 @@ namespace NzbDrone.Core.Validation
 {
     public class QualityProfileExistsValidator : PropertyValidator
     {
-        private readonly IProfileService _profileService;
+        private readonly IQualityProfileService _qualityProfileService;
 
-        public QualityProfileExistsValidator(IProfileService profileService)
+        public QualityProfileExistsValidator(IQualityProfileService qualityProfileService)
         {
-            _profileService = profileService;
+            _qualityProfileService = qualityProfileService;
         }
 
         protected override string GetDefaultMessageTemplate() => "Quality Profile does not exist";
@@ -21,7 +21,7 @@ namespace NzbDrone.Core.Validation
                 return true;
             }
 
-            return _profileService.Exists((int)context.PropertyValue);
+            return _qualityProfileService.Exists((int)context.PropertyValue);
         }
     }
 }
diff --git a/src/Readarr.Api.V1/Profiles/Quality/QualityProfileController.cs b/src/Readarr.Api.V1/Profiles/Quality/QualityProfileController.cs
index 0a5cec33c..ecaf86207 100644
--- a/src/Readarr.Api.V1/Profiles/Quality/QualityProfileController.cs
+++ b/src/Readarr.Api.V1/Profiles/Quality/QualityProfileController.cs
@@ -14,10 +14,10 @@ namespace Readarr.Api.V1.Profiles.Quality
     [V1ApiController]
     public class QualityProfileController : RestController<QualityProfileResource>
     {
-        private readonly IProfileService _qualityProfileService;
+        private readonly IQualityProfileService _qualityProfileService;
         private readonly ICustomFormatService _formatService;
 
-        public QualityProfileController(IProfileService qualityProfileService, ICustomFormatService formatService)
+        public QualityProfileController(IQualityProfileService qualityProfileService, ICustomFormatService formatService)
         {
             _qualityProfileService = qualityProfileService;
             _formatService = formatService;
diff --git a/src/Readarr.Api.V1/Profiles/Quality/QualityProfileSchemaController.cs b/src/Readarr.Api.V1/Profiles/Quality/QualityProfileSchemaController.cs
index 85a46b6cf..fd9abc5d1 100644
--- a/src/Readarr.Api.V1/Profiles/Quality/QualityProfileSchemaController.cs
+++ b/src/Readarr.Api.V1/Profiles/Quality/QualityProfileSchemaController.cs
@@ -7,17 +7,17 @@ namespace Readarr.Api.V1.Profiles.Quality
     [V1ApiController("qualityprofile/schema")]
     public class QualityProfileSchemaController : Controller
     {
-        private readonly IProfileService _profileService;
+        private readonly IQualityProfileService _qualityProfileService;
 
-        public QualityProfileSchemaController(IProfileService profileService)
+        public QualityProfileSchemaController(IQualityProfileService qualityProfileService)
         {
-            _profileService = profileService;
+            _qualityProfileService = qualityProfileService;
         }
 
         [HttpGet]
         public QualityProfileResource GetSchema()
         {
-            var qualityProfile = _profileService.GetDefaultProfile(string.Empty);
+            var qualityProfile = _qualityProfileService.GetDefaultProfile(string.Empty);
 
             return qualityProfile.ToResource();
         }
diff --git a/src/Readarr.Api.V1/RootFolders/RootFolderController.cs b/src/Readarr.Api.V1/RootFolders/RootFolderController.cs
index d49466c9f..7c3bc932f 100644
--- a/src/Readarr.Api.V1/RootFolders/RootFolderController.cs
+++ b/src/Readarr.Api.V1/RootFolders/RootFolderController.cs
@@ -60,10 +60,12 @@ namespace Readarr.Api.V1.RootFolders
             SharedValidator.RuleFor(c => c.Name)
                 .NotEmpty();
 
-            SharedValidator.RuleFor(c => c.DefaultMetadataProfileId)
+            SharedValidator.RuleFor(c => c.DefaultMetadataProfileId).Cascade(CascadeMode.Stop)
+                .ValidId()
                 .SetValidator(metadataProfileExistsValidator);
 
-            SharedValidator.RuleFor(c => c.DefaultQualityProfileId)
+            SharedValidator.RuleFor(c => c.DefaultQualityProfileId).Cascade(CascadeMode.Stop)
+                .ValidId()
                 .SetValidator(qualityProfileExistsValidator);
 
             SharedValidator.RuleFor(c => c.Host).ValidHost().When(x => x.IsCalibreLibrary);