diff --git a/NzbDrone.Core.Test/Files/LongOverview.txt b/NzbDrone.Core.Test/Files/LongOverview.txt new file mode 100644 index 000000000..2e282e24f --- /dev/null +++ b/NzbDrone.Core.Test/Files/LongOverview.txt @@ -0,0 +1,58 @@ +var test = @"As Sterling Cooper Draper Pryce tries to build upon its current business, Peggy is given new responsibility. Don and Harry indulge a client. Betty contemplates her mortality after seeing a doctor. + +Recap: + +Sally and Bobby struggle to zip Betty into a tight dress, but without success. Betty crawls under the covers, tells Henry she doesn’t feel well and refuses to join him at a social function that evening. + +At Don’s apartment, Megan speaks in French to her mother on the phone while dressing for an SCDP client dinner with Heinz. She passes the phone to Don who, flustered by the language barrier, hands the phone back. + +Later at the restaurant, the Heinz client and his wife ask how Don and Megan met. "At work," Don says. "Don was divorced," Megan adds. The client asks Don to enlist the Rolling Stones for a television ad. Don says he’ll try. + +Pete tells Roger they’re on the verge of signing Mohawk, and he would like Roger to handle the account. They decide to hire an additional copywriter because Peggy has her hands full. They believe the client would want a man. + +Harry tells Don that he’s arranged a backstage meeting with the Rolling Stones’ manager on Saturday night. + +At home, Betty sits on the couch in her robe, eating Bugles and reading the paper. Her mother-in-law stops by and suggests diet pills to help Betty get back into shape. + +Back at the office, Don and Roger inform Peggy about Mohawk then ask her to hire a male copywriter. + +Betty visits her doctor to inquire about diet pills. The doctor explains that rapid weight gain in housewives is usually caused by unhappiness or boredom. During his exam, he finds a lump in her throat. + +Betty returns home and looks for Henry, who is not there. She calls Don and frantically tells him about the thyroid lump. "Say what you always say," she begs. "Everything’s gonna be okay," he replies. + +In her office, Peggy leafs through portfolios. She’s impressed by the work of Michael Ginsberg. Stan advises her to hire someone less talented or the new guy will end up her boss. + +As Betty relaxes in the bathtub, Henry tells her he scheduled a doctor’s appointment for her the next morning. At the doctor’s office, she runs into Joyce, an old acquaintance who suggests they meet for lunch. + +Peggy interviews Michael but is put off by his insistence on seeing Don. When she ends the interview prematurely, he apologizes. + +Over lunch, Betty predicts that if she dies, her kids will "never hear a nice word about me again." A fortuneteller stops by her and Joyce’s table and reads Betty’s tea leaves: "You’re a great soul. You mean so much to the people around you." Betty bursts into tears. + +Peggy tells Roger that Michael is crazy, but Roger insists that she hire him. He says hiring a Jew would make the agency more modern, then cracks a joke about Don’s new black secretary, Dawn. + +As he gets ready for the Stones concert, Don warns Megan that Betty might call. + +Backstage at the concert, Don and Harry wait for the Stones to arrive. Harry tells two teenage girls that he and Don are in the advertising business. + +Henry kisses Betty in bed. She returns his advance, surprising him. "It’s been too long," she says. + +Back at the concert, one of the girls sneaks Harry in past security. The other girl remains with Don. + +In the kitchen, Betty dreams that she’s watching Henry and the kids seated for a meal while Henry’s mother serves them. Sally turns Betty’s chair upside down. "I’m so sorry sweetheart," says Betty. She wakes from the dream. +Harry bursts out of the backstage room exclaiming that he’s signed the Stones for the commercial. But when he hears the crowd screaming "They’re here!" he realizes he accidentally signed the wrong band: The Trade Winds. + +The next morning, Don tells Megan that Betty might be sick. Megan encourages him to not get stuck thinking about what might happen. + +In his office, Don admires Michael’s portfolio during the interview. Michael fawns over Don, who congratulates Peggy on finding a good candidate. Peggy tells Michael he got the job. + +Betty finds out the tumor is benign. Henry hugs her, but she replies: "It’s nice to be put through the ringer and find out I’m just fat.' + +Pete gathers everyone at the office to announce that he landed the Mohawk account but Roger will handle it. Roger storms out then tells Don he’s tired of trying to prove his worth. Don reveals that Betty might have cancer. "When is everything going to get back to normal?" Roger wonders. + +Don calls Betty for an update. Henry picks up the phone and is surprised that Don knew about Betty’s situation. He tells Don that Betty is fine and promptly hangs up. + +Michael comes home, unpacks groceries and tells his father that he got the job. His father blesses him with a prayer in Hebrew. + +Betty and Sally eat ice cream sundaes at the kitchen table. Sally leaves hers half-eaten, and Betty reaches over to finish it."; + +test.Length.Dump(); \ No newline at end of file diff --git a/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj b/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj index e58966c77..22819caa9 100644 --- a/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj +++ b/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj @@ -203,6 +203,9 @@ Always + + Always + Always diff --git a/NzbDrone.Core.Test/ProviderTests/EpisodeProviderTest.cs b/NzbDrone.Core.Test/ProviderTests/EpisodeProviderTest.cs index 51699f75b..a69cdcb2d 100644 --- a/NzbDrone.Core.Test/ProviderTests/EpisodeProviderTest.cs +++ b/NzbDrone.Core.Test/ProviderTests/EpisodeProviderTest.cs @@ -2,6 +2,7 @@ using System; using System.Collections.Generic; +using System.IO; using System.Linq; using FizzWare.NBuilder; @@ -479,6 +480,48 @@ namespace NzbDrone.Core.Test.ProviderTests result.Where(e => e.Ignored).Should().HaveCount(episodeCount); } + [Test] + public void RefreshEpisodeInfo_should_trim_overview_to_4000_characters() + { + //Arrange + const int seriesId = 71663; + const int episodeCount = 10; + + var longOverview = File.ReadAllText(@".\Files\LongOverview.txt"); + + var fakeEpisodes = Builder.CreateNew().With( + c => c.Episodes = + new List(Builder.CreateListOfSize(episodeCount). + All() + .With(l => l.Language = new TvdbLanguage(0, "eng", "a")) + .With(e => e.SeasonNumber = 0) + .TheLast(1) + .With(e => e.Overview = longOverview) + .Build()) + ).With(c => c.Id = seriesId).Build(); + + var fakeSeries = Builder.CreateNew().With(c => c.SeriesId = seriesId).Build(); + + WithRealDb(); + + Db.Insert(fakeSeries); + + Mocker.GetMock() + .Setup(c => c.GetSeries(seriesId, true)) + .Returns(fakeEpisodes); + + Mocker.GetMock() + .Setup(s => s.IsIgnored(seriesId, 0)) + .Returns(false); + + //Act + Mocker.Resolve().RefreshEpisodeInfo(fakeSeries); + + //Assert + var result = Mocker.Resolve().GetEpisodeBySeries(seriesId).ToList(); + result.Should().HaveCount(episodeCount); + } + [Test] public void new_episodes_only_calls_Insert() { diff --git a/NzbDrone.Core/Providers/EpisodeProvider.cs b/NzbDrone.Core/Providers/EpisodeProvider.cs index 08d3b8c16..d3461d018 100644 --- a/NzbDrone.Core/Providers/EpisodeProvider.cs +++ b/NzbDrone.Core/Providers/EpisodeProvider.cs @@ -327,7 +327,11 @@ namespace NzbDrone.Core.Providers episodeToUpdate.EpisodeNumber = episode.EpisodeNumber; episodeToUpdate.SeasonNumber = episode.SeasonNumber; episodeToUpdate.Title = episode.EpisodeName; - episodeToUpdate.Overview = episode.Overview; + + if (episode.Overview.Length > 3998) + episodeToUpdate.Overview = episode.Overview.Substring(0, 3998); + else + episodeToUpdate.Overview = episode.Overview; if (episode.FirstAired.Year > 1900) episodeToUpdate.AirDate = episode.FirstAired.Date;