diff --git a/src/NzbDrone.Core.Test/TvTests/RefreshSeriesServiceFixture.cs b/src/NzbDrone.Core.Test/TvTests/RefreshSeriesServiceFixture.cs index 1012149c1..31c402927 100644 --- a/src/NzbDrone.Core.Test/TvTests/RefreshSeriesServiceFixture.cs +++ b/src/NzbDrone.Core.Test/TvTests/RefreshSeriesServiceFixture.cs @@ -1,11 +1,14 @@ -using System; +using System; using System.Collections.Generic; +using System.IO; using System.Linq; using FizzWare.NBuilder; +using FluentAssertions; using Moq; using NUnit.Framework; using NzbDrone.Common.Extensions; using NzbDrone.Core.Exceptions; +using NzbDrone.Core.MediaFiles; using NzbDrone.Core.MetadataSource; using NzbDrone.Core.Test.Framework; using NzbDrone.Core.Tv; @@ -180,5 +183,35 @@ namespace NzbDrone.Core.Test.TvTests .Verify(v => v.UpdateSeries(It.Is(s => s.Seasons.Count == 2), It.IsAny())); } + + [Test] + public void should_rescan_series_if_updating_fails() + { + Mocker.GetMock() + .Setup(s => s.GetSeriesInfo(_series.Id)) + .Throws(new IOException()); + + Assert.Throws(() => Subject.Execute(new RefreshSeriesCommand(_series.Id))); + + Mocker.GetMock() + .Verify(v => v.Scan(_series), Times.Once()); + + ExceptionVerification.ExpectedErrors(1); + } + + [Test] + public void should_not_rescan_series_if_updating_fails_with_series_not_found() + { + Mocker.GetMock() + .Setup(s => s.GetSeriesInfo(_series.Id)) + .Throws(new SeriesNotFoundException(_series.Id)); + + Subject.Execute(new RefreshSeriesCommand(_series.Id)); + + Mocker.GetMock() + .Verify(v => v.Scan(_series), Times.Never()); + + ExceptionVerification.ExpectedErrors(1); + } } } diff --git a/src/NzbDrone.Core/Tv/RefreshSeriesService.cs b/src/NzbDrone.Core/Tv/RefreshSeriesService.cs index f177b5857..a7f42f554 100644 --- a/src/NzbDrone.Core/Tv/RefreshSeriesService.cs +++ b/src/NzbDrone.Core/Tv/RefreshSeriesService.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Generic; using System.IO; using System.Linq; @@ -144,6 +144,18 @@ namespace NzbDrone.Core.Tv return seasons; } + private void RescanSeries(Series series) + { + try + { + _diskScanService.Scan(series); + } + catch (Exception e) + { + _logger.Error(e, "Couldn't rescan series {0}", series); + } + } + public void Execute(RefreshSeriesCommand message) { _eventAggregator.PublishEvent(new SeriesRefreshStartingEvent(message.Trigger == CommandTrigger.Manual)); @@ -151,7 +163,17 @@ namespace NzbDrone.Core.Tv if (message.SeriesId.HasValue) { var series = _seriesService.GetSeries(message.SeriesId.Value); - RefreshSeriesInfo(series); + + try + { + RefreshSeriesInfo(series); + } + catch (Exception e) + { + _logger.Error(e, "Couldn't refresh info for {0}", series); + RescanSeries(series); + throw; + } } else { @@ -168,20 +190,14 @@ namespace NzbDrone.Core.Tv catch (Exception e) { _logger.Error(e, "Couldn't refresh info for {0}", series); + RescanSeries(series); } } else { - try - { - _logger.Info("Skipping refresh of series: {0}", series.Title); - _diskScanService.Scan(series); - } - catch (Exception e) - { - _logger.Error(e, "Couldn't rescan series {0}", series); - } + _logger.Info("Skipping refresh of series: {0}", series.Title); + RescanSeries(series); } } }