From 32d6909045b2bc5cb1ba8bffd9055b343d64917a Mon Sep 17 00:00:00 2001
From: Keivan Beigi <kay.one@gmail.com>
Date: Fri, 5 Jul 2013 16:53:05 -0700
Subject: [PATCH] fixed Ajax errors not being displayed in the UI.

---
 .../Exceptions/NzbDroneException.cs           | 26 +++++++
 NzbDrone.Common/NzbDrone.Common.csproj        |  2 +
 NzbDrone.Core.Test/NzbDrone.Core.Test.csproj  |  2 +-
 .../Qualities/QualityProfileFixture.cs        | 39 ----------
 .../Qualities/QualityProfileServiceFixture.cs | 75 +++++++++++++++++++
 NzbDrone.Core/MediaFiles/MediaFileService.cs  |  2 -
 NzbDrone.Core/NzbDrone.Core.csproj            |  1 +
 .../Qualities/QualityProfileInUseException.cs | 13 ++++
 .../Qualities/QualityProfileService.cs        | 16 +++-
 NzbDrone.Core/Qualities/QualitySize.cs        |  3 +-
 UI/app.js                                     |  7 +-
 11 files changed, 134 insertions(+), 52 deletions(-)
 create mode 100644 NzbDrone.Common/Exceptions/NzbDroneException.cs
 delete mode 100644 NzbDrone.Core.Test/Qualities/QualityProfileFixture.cs
 create mode 100644 NzbDrone.Core.Test/Qualities/QualityProfileServiceFixture.cs
 create mode 100644 NzbDrone.Core/Qualities/QualityProfileInUseException.cs

diff --git a/NzbDrone.Common/Exceptions/NzbDroneException.cs b/NzbDrone.Common/Exceptions/NzbDroneException.cs
new file mode 100644
index 000000000..67b467a37
--- /dev/null
+++ b/NzbDrone.Common/Exceptions/NzbDroneException.cs
@@ -0,0 +1,26 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+
+namespace NzbDrone.Common.Exceptions
+{
+
+
+    public abstract class NzbDroneException : ApplicationException
+    {
+        protected NzbDroneException(string message, params object[] args)
+            : base(string.Format(message, args))
+        {
+
+        }
+
+
+        protected NzbDroneException(string message)
+            : base(message)
+        {
+
+        }
+    }
+
+}
diff --git a/NzbDrone.Common/NzbDrone.Common.csproj b/NzbDrone.Common/NzbDrone.Common.csproj
index c18a6f6b4..cd7ad1b32 100644
--- a/NzbDrone.Common/NzbDrone.Common.csproj
+++ b/NzbDrone.Common/NzbDrone.Common.csproj
@@ -106,6 +106,7 @@
     <Compile Include="EnvironmentInfo\BuildInfo.cs" />
     <Compile Include="EnvironmentInfo\RuntimeInfo.cs" />
     <Compile Include="EnvironmentInfo\OsInfo.cs" />
+    <Compile Include="Exceptions\NzbDroneException.cs" />
     <Compile Include="Instrumentation\GlobalExceptionHandlers.cs" />
     <Compile Include="Instrumentation\ExceptronTarget.cs" />
     <Compile Include="Messaging\LimitedConcurrencyLevelTaskScheduler.cs" />
@@ -176,6 +177,7 @@
       <Name>Exceptron.Client</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup />
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <Import Project="$(SolutionDir)\.nuget\nuget.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
diff --git a/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj b/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj
index 6c98013cb..4fde1c4da 100644
--- a/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj
+++ b/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj
@@ -215,7 +215,7 @@
     <Compile Include="Framework\TestDbHelper.cs" />
     <Compile Include="ParserTests\ParserFixture.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
-    <Compile Include="Qualities\QualityProfileFixture.cs" />
+    <Compile Include="Qualities\QualityProfileServiceFixture.cs" />
     <Compile Include="TvTests\SeriesServiceFixture.cs" />
     <Compile Include="UpdateTests\UpdatePackageProviderFixture.cs" />
     <Compile Include="XbmcVersionTests.cs" />
diff --git a/NzbDrone.Core.Test/Qualities/QualityProfileFixture.cs b/NzbDrone.Core.Test/Qualities/QualityProfileFixture.cs
deleted file mode 100644
index 4316854ef..000000000
--- a/NzbDrone.Core.Test/Qualities/QualityProfileFixture.cs
+++ /dev/null
@@ -1,39 +0,0 @@
-using System.Linq;
-using FizzWare.NBuilder;
-using Moq;
-using NUnit.Framework;
-using NzbDrone.Core.Lifecycle;
-using NzbDrone.Core.Qualities;
-using NzbDrone.Core.Test.Framework;
-
-namespace NzbDrone.Core.Test.Qualities
-{
-    [TestFixture]
-    
-    public class QualityProfileFixture : CoreTest<QualityProfileService>
-    {
-        [Test]
-        public void Init_should_add_two_profiles()
-        {
-            Subject.Handle(new ApplicationStartedEvent());
-
-            Mocker.GetMock<IQualityProfileRepository>()
-                .Verify(v => v.Insert(It.IsAny<QualityProfile>()), Times.Exactly(4));
-        }
-
-        [Test]
-        //This confirms that new profiles are added only if no other profiles exists.
-        //We don't want to keep adding them back if a user deleted them on purpose.
-        public void Init_should_skip_if_any_profiles_already_exist()
-        {
-            Mocker.GetMock<IQualityProfileRepository>()
-                  .Setup(s => s.All())
-                  .Returns(Builder<QualityProfile>.CreateListOfSize(2).Build().ToList());
-
-            Subject.Handle(new ApplicationStartedEvent());
-
-            Mocker.GetMock<IQualityProfileRepository>()
-                .Verify(v => v.Insert(It.IsAny<QualityProfile>()), Times.Never());
-        }
-    }
-}
\ No newline at end of file
diff --git a/NzbDrone.Core.Test/Qualities/QualityProfileServiceFixture.cs b/NzbDrone.Core.Test/Qualities/QualityProfileServiceFixture.cs
new file mode 100644
index 000000000..9390925c1
--- /dev/null
+++ b/NzbDrone.Core.Test/Qualities/QualityProfileServiceFixture.cs
@@ -0,0 +1,75 @@
+using System.Linq;
+using FizzWare.NBuilder;
+using Moq;
+using NUnit.Framework;
+using NzbDrone.Core.Lifecycle;
+using NzbDrone.Core.Qualities;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Core.Tv;
+
+namespace NzbDrone.Core.Test.Qualities
+{
+    [TestFixture]
+
+    public class QualityProfileServiceFixture : CoreTest<QualityProfileService>
+    {
+        [Test]
+        public void Init_should_add_two_profiles()
+        {
+            Subject.Handle(new ApplicationStartedEvent());
+
+            Mocker.GetMock<IQualityProfileRepository>()
+                .Verify(v => v.Insert(It.IsAny<QualityProfile>()), Times.Exactly(4));
+        }
+
+        [Test]
+        //This confirms that new profiles are added only if no other profiles exists.
+        //We don't want to keep adding them back if a user deleted them on purpose.
+        public void Init_should_skip_if_any_profiles_already_exist()
+        {
+            Mocker.GetMock<IQualityProfileRepository>()
+                  .Setup(s => s.All())
+                  .Returns(Builder<QualityProfile>.CreateListOfSize(2).Build().ToList());
+
+            Subject.Handle(new ApplicationStartedEvent());
+
+            Mocker.GetMock<IQualityProfileRepository>()
+                .Verify(v => v.Insert(It.IsAny<QualityProfile>()), Times.Never());
+        }
+
+
+        [Test]
+        public void should_not_be_able_to_delete_profile_if_assigned_to_series()
+        {
+            var seriesList = Builder<Series>.CreateListOfSize(3)
+                                            .Random(1)
+                                            .With(c => c.QualityProfileId = 2)
+                                            .Build().ToList();
+
+
+            Mocker.GetMock<ISeriesService>().Setup(c => c.GetAllSeries()).Returns(seriesList);
+
+            Assert.Throws<QualityProfileInUseException>(() => Subject.Delete(2));
+
+            Mocker.GetMock<IQualityProfileRepository>().Verify(c => c.Delete(It.IsAny<int>()), Times.Never());
+
+        }
+
+
+        [Test]
+        public void should_delete_profile_if_not_assigned_to_series()
+        {
+            var seriesList = Builder<Series>.CreateListOfSize(3)
+                                            .All()
+                                            .With(c => c.QualityProfileId = 2)
+                                            .Build().ToList();
+
+
+            Mocker.GetMock<ISeriesService>().Setup(c => c.GetAllSeries()).Returns(seriesList);
+
+            Subject.Delete(1);
+
+            Mocker.GetMock<IQualityProfileRepository>().Verify(c => c.Delete(1), Times.Once());
+        }
+    }
+}
\ No newline at end of file
diff --git a/NzbDrone.Core/MediaFiles/MediaFileService.cs b/NzbDrone.Core/MediaFiles/MediaFileService.cs
index a4c0f4d97..20752ed6c 100644
--- a/NzbDrone.Core/MediaFiles/MediaFileService.cs
+++ b/NzbDrone.Core/MediaFiles/MediaFileService.cs
@@ -1,10 +1,8 @@
 using System.Collections.Generic;
-using System.IO;
 using NLog;
 using NzbDrone.Common.Messaging;
 using NzbDrone.Core.Configuration;
 using NzbDrone.Core.MediaFiles.Events;
-using NzbDrone.Core.Tv;
 using NzbDrone.Core.Tv.Events;
 
 namespace NzbDrone.Core.MediaFiles
diff --git a/NzbDrone.Core/NzbDrone.Core.csproj b/NzbDrone.Core/NzbDrone.Core.csproj
index ca596935c..0bd76974b 100644
--- a/NzbDrone.Core/NzbDrone.Core.csproj
+++ b/NzbDrone.Core/NzbDrone.Core.csproj
@@ -376,6 +376,7 @@
     <Compile Include="Parser\Parser.cs" />
     <Compile Include="Parser\ParsingService.cs" />
     <Compile Include="Providers\UpdateXemMappings.cs" />
+    <Compile Include="Qualities\QualityProfileInUseException.cs" />
     <Compile Include="Qualities\QualitySizeRepository.cs" />
     <Compile Include="Qualities\QualityProfileRepository.cs" />
     <Compile Include="SeriesStats\SeriesStatisticsService.cs" />
diff --git a/NzbDrone.Core/Qualities/QualityProfileInUseException.cs b/NzbDrone.Core/Qualities/QualityProfileInUseException.cs
new file mode 100644
index 000000000..24c50e7c6
--- /dev/null
+++ b/NzbDrone.Core/Qualities/QualityProfileInUseException.cs
@@ -0,0 +1,13 @@
+using NzbDrone.Common.Exceptions;
+
+namespace NzbDrone.Core.Qualities
+{
+    public class QualityProfileInUseException : NzbDroneException
+    {
+        public QualityProfileInUseException(int profileId)
+            : base("QualityProfile [{0}] is in use.", profileId)
+        {
+
+        }
+    }
+}
\ No newline at end of file
diff --git a/NzbDrone.Core/Qualities/QualityProfileService.cs b/NzbDrone.Core/Qualities/QualityProfileService.cs
index 35832b156..fb96cee99 100644
--- a/NzbDrone.Core/Qualities/QualityProfileService.cs
+++ b/NzbDrone.Core/Qualities/QualityProfileService.cs
@@ -3,6 +3,7 @@ using System.Linq;
 using NLog;
 using NzbDrone.Common.Messaging;
 using NzbDrone.Core.Lifecycle;
+using NzbDrone.Core.Tv;
 
 
 namespace NzbDrone.Core.Qualities
@@ -19,11 +20,13 @@ namespace NzbDrone.Core.Qualities
     public class QualityProfileService : IQualityProfileService, IHandle<ApplicationStartedEvent>
     {
         private readonly IQualityProfileRepository _qualityProfileRepository;
+        private readonly ISeriesService _seriesService;
         private readonly Logger _logger;
 
-        public QualityProfileService(IQualityProfileRepository qualityProfileRepository, Logger logger)
+        public QualityProfileService(IQualityProfileRepository qualityProfileRepository, ISeriesService seriesService, Logger logger)
         {
             _qualityProfileRepository = qualityProfileRepository;
+            _seriesService = seriesService;
             _logger = logger;
         }
 
@@ -39,6 +42,11 @@ namespace NzbDrone.Core.Qualities
 
         public void Delete(int id)
         {
+            if (_seriesService.GetAllSeries().Any(c => c.QualityProfileId == id))
+            {
+                throw new QualityProfileInUseException(id);
+            }
+
             _qualityProfileRepository.Delete(id);
         }
 
@@ -59,14 +67,14 @@ namespace NzbDrone.Core.Qualities
             _logger.Info("Setting up default quality profiles");
 
             var sd = new QualityProfile
-            { 
-                Name = "SD", 
+            {
+                Name = "SD",
                 Allowed = new List<Quality>
                               {
                                   Quality.SDTV,
                                   Quality.WEBDL480p,
                                   Quality.DVD
-                              }, 
+                              },
                 Cutoff = Quality.SDTV
             };
 
diff --git a/NzbDrone.Core/Qualities/QualitySize.cs b/NzbDrone.Core/Qualities/QualitySize.cs
index 3e9e31032..5a8ccc23f 100644
--- a/NzbDrone.Core/Qualities/QualitySize.cs
+++ b/NzbDrone.Core/Qualities/QualitySize.cs
@@ -1,4 +1,5 @@
-using System.Linq;
+using System;
+using System.Linq;
 using NzbDrone.Core.Datastore;
 
 
diff --git a/UI/app.js b/UI/app.js
index 1b469c287..46801acef 100644
--- a/UI/app.js
+++ b/UI/app.js
@@ -30,16 +30,13 @@ require.config({
     shim: {
 
         $: {
-            deps   :
-                [
-                    'Instrumentation/ErrorHandler'
-                ],
             exports: '$',
 
             init: function () {
                 require(
                     [
-                        'jQuery/ToTheTop'
+                        'jQuery/ToTheTop',
+                        'Instrumentation/ErrorHandler'
                     ]);
             }