Fixed: Tag inputs respect non-QWERTY layouts

pull/3660/head
Anthony Borushko 5 years ago committed by GitHub
parent 1b3839ac0d
commit 638066db03
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -135,7 +135,7 @@ class FilterBuilderRowValue extends Component {
tagList={tagList}
allowNew={!tagList.length}
kind={kinds.DEFAULT}
delimiters={[9, 13]}
delimiters={['Tab', 'Enter']}
maxSuggestionsLength={100}
minQueryLength={0}
tagComponent={FilterBuilderRowValueTag}

@ -100,9 +100,9 @@ class TagInput extends Component {
suggestions
} = this.state;
const keyCode = event.keyCode;
const key = event.key;
if (keyCode === 8 && !value.length) {
if (key === 'Backspace' && !value.length) {
const index = tags.length - 1;
if (index >= 0) {
@ -116,7 +116,7 @@ class TagInput extends Component {
event.preventDefault();
}
if (delimiters.includes(keyCode)) {
if (delimiters.includes(key)) {
const selectedIndex = this._autosuggestRef.highlightedSuggestionIndex;
const tag = getTag(value, selectedIndex, suggestions, allowNew);
@ -260,7 +260,7 @@ TagInput.propTypes = {
allowNew: PropTypes.bool.isRequired,
kind: PropTypes.oneOf(kinds.all).isRequired,
placeholder: PropTypes.string.isRequired,
delimiters: PropTypes.arrayOf(PropTypes.number).isRequired,
delimiters: PropTypes.arrayOf(PropTypes.string).isRequired,
minQueryLength: PropTypes.number.isRequired,
hasError: PropTypes.bool,
hasWarning: PropTypes.bool,
@ -275,8 +275,7 @@ TagInput.defaultProps = {
allowNew: true,
kind: kinds.INFO,
placeholder: '',
// Tab, enter, space and comma
delimiters: [9, 13, 32, 188],
delimiters: ['Tab', 'Enter', ' ', ','],
minQueryLength: 1,
tagComponent: TagInputTag
};

@ -13,8 +13,7 @@ import FormLabel from 'Components/Form/FormLabel';
import FormInputGroup from 'Components/Form/FormInputGroup';
import styles from './EditReleaseProfileModalContent.css';
// Tab, enter, and comma
const tagInputDelimiters = [9, 13, 188];
const tagInputDelimiters = ['Tab', 'Enter', ','];
function EditReleaseProfileModalContent(props) {
const {

Loading…
Cancel
Save