From 6b1e4ef81938d264a2ddc8b626b0502f799aa640 Mon Sep 17 00:00:00 2001 From: Bogdan Date: Sun, 28 May 2023 02:53:49 +0300 Subject: [PATCH] Enforce rule IDE0005 on build --- src/Directory.Build.props | 7 +++++++ .../Http/Dispatchers/ManagedHttpDispatcher.cs | 1 - src/NzbDrone.Common/OAuth/OAuthRequest.cs | 2 +- .../MatchesGrabSpecificationFixture.cs | 1 - .../TorrentRss/TorrentRssSettingsDetector.cs | 12 ++++++------ .../Aggregation/Aggregators/AggregateReleaseInfo.cs | 1 - .../EpisodeImport/ImportApprovedEpisodes.cs | 1 - src/NzbDrone.Core/MediaFiles/ScriptImportDecider.cs | 1 - .../MediaFiles/UpgradeMediaFileService.cs | 1 - .../Notifications/NotificationService.cs | 1 - .../Notifications/Signal/SignalError.cs | 4 +--- .../Notifications/Signal/SignalProxy.cs | 1 - src/Sonarr.Api.V3/Episodes/EpisodeController.cs | 1 - src/Sonarr.Api.V3/Series/SeriesController.cs | 1 - 14 files changed, 15 insertions(+), 20 deletions(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 9db1afbec..370dfce70 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -30,6 +30,13 @@ false true + + + true + + $(NoWarn);CS1591 diff --git a/src/NzbDrone.Common/Http/Dispatchers/ManagedHttpDispatcher.cs b/src/NzbDrone.Common/Http/Dispatchers/ManagedHttpDispatcher.cs index f89a7cf1e..33a758c2e 100644 --- a/src/NzbDrone.Common/Http/Dispatchers/ManagedHttpDispatcher.cs +++ b/src/NzbDrone.Common/Http/Dispatchers/ManagedHttpDispatcher.cs @@ -7,7 +7,6 @@ using System.Net.Sockets; using System.Text; using System.Threading; using System.Threading.Tasks; -using NLog; using NzbDrone.Common.Cache; using NzbDrone.Common.Extensions; using NzbDrone.Common.Http.Proxy; diff --git a/src/NzbDrone.Common/OAuth/OAuthRequest.cs b/src/NzbDrone.Common/OAuth/OAuthRequest.cs index 99275bf03..34b4e7408 100644 --- a/src/NzbDrone.Common/OAuth/OAuthRequest.cs +++ b/src/NzbDrone.Common/OAuth/OAuthRequest.cs @@ -29,7 +29,7 @@ namespace NzbDrone.Common.OAuth public virtual string Version { get; set; } public virtual string SessionHandle { get; set; } - /// + /// public virtual string RequestUrl { get; set; } #if !WINRT diff --git a/src/NzbDrone.Core.Test/MediaFiles/EpisodeImport/Specifications/MatchesGrabSpecificationFixture.cs b/src/NzbDrone.Core.Test/MediaFiles/EpisodeImport/Specifications/MatchesGrabSpecificationFixture.cs index 526303f00..a148d9d09 100644 --- a/src/NzbDrone.Core.Test/MediaFiles/EpisodeImport/Specifications/MatchesGrabSpecificationFixture.cs +++ b/src/NzbDrone.Core.Test/MediaFiles/EpisodeImport/Specifications/MatchesGrabSpecificationFixture.cs @@ -1,5 +1,4 @@ using System.Collections.Generic; -using System.Linq; using FizzWare.NBuilder; using FluentAssertions; using NUnit.Framework; diff --git a/src/NzbDrone.Core/Indexers/TorrentRss/TorrentRssSettingsDetector.cs b/src/NzbDrone.Core/Indexers/TorrentRss/TorrentRssSettingsDetector.cs index 6ce0af979..123187395 100644 --- a/src/NzbDrone.Core/Indexers/TorrentRss/TorrentRssSettingsDetector.cs +++ b/src/NzbDrone.Core/Indexers/TorrentRss/TorrentRssSettingsDetector.cs @@ -35,13 +35,13 @@ namespace NzbDrone.Core.Indexers.TorrentRss /// /// Indexer Settings to use for Parser /// Parsed Settings or null - public TorrentRssIndexerParserSettings Detect(TorrentRssIndexerSettings indexerSettings) + public TorrentRssIndexerParserSettings Detect(TorrentRssIndexerSettings settings) { - _logger.Debug("Evaluating TorrentRss feed '{0}'", indexerSettings.BaseUrl); + _logger.Debug("Evaluating TorrentRss feed '{0}'", settings.BaseUrl); try { - var requestGenerator = new TorrentRssIndexerRequestGenerator { Settings = indexerSettings }; + var requestGenerator = new TorrentRssIndexerRequestGenerator { Settings = settings }; var request = requestGenerator.GetRecentRequests().GetAllTiers().First().First(); HttpResponse httpResponse = null; @@ -56,14 +56,14 @@ namespace NzbDrone.Core.Indexers.TorrentRss } var indexerResponse = new IndexerResponse(request, httpResponse); - return GetParserSettings(indexerResponse, indexerSettings); + return GetParserSettings(indexerResponse, settings); } catch (Exception ex) { - ex.WithData("FeedUrl", indexerSettings.BaseUrl); + ex.WithData("FeedUrl", settings.BaseUrl); throw; } - } + } private TorrentRssIndexerParserSettings GetParserSettings(IndexerResponse response, TorrentRssIndexerSettings indexerSettings) { diff --git a/src/NzbDrone.Core/MediaFiles/EpisodeImport/Aggregation/Aggregators/AggregateReleaseInfo.cs b/src/NzbDrone.Core/MediaFiles/EpisodeImport/Aggregation/Aggregators/AggregateReleaseInfo.cs index 8456c7838..111b465f6 100644 --- a/src/NzbDrone.Core/MediaFiles/EpisodeImport/Aggregation/Aggregators/AggregateReleaseInfo.cs +++ b/src/NzbDrone.Core/MediaFiles/EpisodeImport/Aggregation/Aggregators/AggregateReleaseInfo.cs @@ -1,4 +1,3 @@ -using System.Collections.Generic; using System.Linq; using NzbDrone.Common.Extensions; using NzbDrone.Core.Download; diff --git a/src/NzbDrone.Core/MediaFiles/EpisodeImport/ImportApprovedEpisodes.cs b/src/NzbDrone.Core/MediaFiles/EpisodeImport/ImportApprovedEpisodes.cs index 71a714c71..a77cc8957 100644 --- a/src/NzbDrone.Core/MediaFiles/EpisodeImport/ImportApprovedEpisodes.cs +++ b/src/NzbDrone.Core/MediaFiles/EpisodeImport/ImportApprovedEpisodes.cs @@ -9,7 +9,6 @@ using NzbDrone.Core.Download; using NzbDrone.Core.Extras; using NzbDrone.Core.MediaFiles.Commands; using NzbDrone.Core.MediaFiles.Events; -using NzbDrone.Core.MediaFiles.MediaInfo; using NzbDrone.Core.Messaging.Commands; using NzbDrone.Core.Messaging.Events; using NzbDrone.Core.Parser.Model; diff --git a/src/NzbDrone.Core/MediaFiles/ScriptImportDecider.cs b/src/NzbDrone.Core/MediaFiles/ScriptImportDecider.cs index 573ef0b56..50cb9b0e8 100644 --- a/src/NzbDrone.Core/MediaFiles/ScriptImportDecider.cs +++ b/src/NzbDrone.Core/MediaFiles/ScriptImportDecider.cs @@ -1,4 +1,3 @@ -using System.Collections.Generic; using System.Collections.Specialized; using System.IO; using System.Linq; diff --git a/src/NzbDrone.Core/MediaFiles/UpgradeMediaFileService.cs b/src/NzbDrone.Core/MediaFiles/UpgradeMediaFileService.cs index f980e1b15..908271c6d 100644 --- a/src/NzbDrone.Core/MediaFiles/UpgradeMediaFileService.cs +++ b/src/NzbDrone.Core/MediaFiles/UpgradeMediaFileService.cs @@ -4,7 +4,6 @@ using NLog; using NzbDrone.Common.Disk; using NzbDrone.Common.Extensions; using NzbDrone.Core.MediaFiles.EpisodeImport; -using NzbDrone.Core.MediaFiles.MediaInfo; using NzbDrone.Core.Parser.Model; namespace NzbDrone.Core.MediaFiles diff --git a/src/NzbDrone.Core/Notifications/NotificationService.cs b/src/NzbDrone.Core/Notifications/NotificationService.cs index c1bf7ace9..46e672f1f 100644 --- a/src/NzbDrone.Core/Notifications/NotificationService.cs +++ b/src/NzbDrone.Core/Notifications/NotificationService.cs @@ -4,7 +4,6 @@ using System.Linq; using NLog; using NzbDrone.Common.Extensions; using NzbDrone.Core.Download; -using NzbDrone.Core.Download.TrackedDownloads; using NzbDrone.Core.HealthCheck; using NzbDrone.Core.MediaFiles.Events; using NzbDrone.Core.Messaging.Events; diff --git a/src/NzbDrone.Core/Notifications/Signal/SignalError.cs b/src/NzbDrone.Core/Notifications/Signal/SignalError.cs index 49f973f28..15d5f56c6 100644 --- a/src/NzbDrone.Core/Notifications/Signal/SignalError.cs +++ b/src/NzbDrone.Core/Notifications/Signal/SignalError.cs @@ -1,6 +1,4 @@ -using Newtonsoft.Json; - -namespace NzbDrone.Core.Notifications.Signal +namespace NzbDrone.Core.Notifications.Signal { public class SignalError { diff --git a/src/NzbDrone.Core/Notifications/Signal/SignalProxy.cs b/src/NzbDrone.Core/Notifications/Signal/SignalProxy.cs index 487248b6d..e41de7a32 100644 --- a/src/NzbDrone.Core/Notifications/Signal/SignalProxy.cs +++ b/src/NzbDrone.Core/Notifications/Signal/SignalProxy.cs @@ -1,7 +1,6 @@ using System; using System.Net; using System.Text; -using System.Web; using FluentValidation.Results; using NLog; using NzbDrone.Common.Extensions; diff --git a/src/Sonarr.Api.V3/Episodes/EpisodeController.cs b/src/Sonarr.Api.V3/Episodes/EpisodeController.cs index 06f034d8f..7b53a1f54 100644 --- a/src/Sonarr.Api.V3/Episodes/EpisodeController.cs +++ b/src/Sonarr.Api.V3/Episodes/EpisodeController.cs @@ -6,7 +6,6 @@ using NzbDrone.Core.DecisionEngine.Specifications; using NzbDrone.Core.Tv; using NzbDrone.SignalR; using Sonarr.Http; -using Sonarr.Http.Extensions; using Sonarr.Http.REST; using Sonarr.Http.REST.Attributes; diff --git a/src/Sonarr.Api.V3/Series/SeriesController.cs b/src/Sonarr.Api.V3/Series/SeriesController.cs index d0867764f..96bd27952 100644 --- a/src/Sonarr.Api.V3/Series/SeriesController.cs +++ b/src/Sonarr.Api.V3/Series/SeriesController.cs @@ -19,7 +19,6 @@ using NzbDrone.Core.Validation; using NzbDrone.Core.Validation.Paths; using NzbDrone.SignalR; using Sonarr.Http; -using Sonarr.Http.Extensions; using Sonarr.Http.REST; using Sonarr.Http.REST.Attributes;