New: Improve UI status when downloads cannot be imported automatically

Closes #6873

frontend/src/Activity/Queue/QueueStatus.js

@@ -70,6 +70,11 @@ function QueueStatus(props) {
     iconName = icons.DOWNLOADED;
     title = translate('Downloaded');
 
+    if (trackedDownloadState === 'importBlocked') {
+      title += ` - ${translate('UnableToImportAutomatically')}`;
+      iconKind = kinds.WARNING;
+    }
+
     if (trackedDownloadState === 'importPending') {
       title += ` - ${translate('WaitingToImport')}`;
       iconKind = kinds.PURPLE;

src/NzbDrone.Core.Test/Download/CompletedDownloadServiceTests/ImportFixture.cs

@@ -366,7 +366,7 @@ namespace NzbDrone.Core.Test.Download.CompletedDownloadServiceTests
             Mocker.GetMock<IEventAggregator>()
                   .Verify(v => v.PublishEvent(It.IsAny<DownloadCompletedEvent>()), Times.Never());
 
-            _trackedDownload.State.Should().Be(TrackedDownloadState.ImportPending);
+            _trackedDownload.State.Should().Be(TrackedDownloadState.ImportBlocked);
         }
 
         private void AssertImported()

src/NzbDrone.Core/Download/CompletedDownloadService.cs

@@ -64,8 +64,8 @@ namespace NzbDrone.Core.Download
 
             SetImportItem(trackedDownload);
 
-            // Only process tracked downloads that are still downloading
-            if (trackedDownload.State != TrackedDownloadState.Downloading)
+            // Only process tracked downloads that are still downloading or have been blocked for importing due to an issue with matching
+            if (trackedDownload.State != TrackedDownloadState.Downloading && trackedDownload.State != TrackedDownloadState.ImportBlocked)
             {
                 return;
             }
@@ -96,7 +96,7 @@ namespace NzbDrone.Core.Download
                 if (series == null)
                 {
                     trackedDownload.Warn("Series title mismatch; automatic import is not possible. Check the download troubleshooting entry on the wiki for common causes.");
-                    SendManualInteractionRequiredNotification(trackedDownload);
+                    SetStateToImportBlocked(trackedDownload);
 
                     return;
                 }
@@ -108,7 +108,7 @@ namespace NzbDrone.Core.Download
                 if (seriesMatchType == SeriesMatchType.Id && releaseSource != ReleaseSourceType.InteractiveSearch)
                 {
                     trackedDownload.Warn("Found matching series via grab history, but release was matched to series by ID. Automatic import is not possible. See the FAQ for details.");
-                    SendManualInteractionRequiredNotification(trackedDownload);
+                    SetStateToImportBlocked(trackedDownload);
 
                     return;
                 }
@@ -129,7 +129,7 @@ namespace NzbDrone.Core.Download
             if (trackedDownload.RemoteEpisode == null)
             {
                 trackedDownload.Warn("Unable to parse download, automatic import is not possible.");
-                SendManualInteractionRequiredNotification(trackedDownload);
+                SetStateToImportBlocked(trackedDownload);
 
                 return;
             }
@@ -187,7 +187,7 @@ namespace NzbDrone.Core.Download
             if (statusMessages.Any())
             {
                 trackedDownload.Warn(statusMessages.ToArray());
-                SendManualInteractionRequiredNotification(trackedDownload);
+                SetStateToImportBlocked(trackedDownload);
             }
         }
 
@@ -254,8 +254,10 @@ namespace NzbDrone.Core.Download
             return false;
         }
 
-        private void SendManualInteractionRequiredNotification(TrackedDownload trackedDownload)
+        private void SetStateToImportBlocked(TrackedDownload trackedDownload)
         {
+            trackedDownload.State = TrackedDownloadState.ImportBlocked;
+
             if (!trackedDownload.HasNotifiedManualInteractionRequired)
             {
                 var grabbedHistories = _historyService.FindByDownloadId(trackedDownload.DownloadItem.DownloadId).Where(h => h.EventType == EpisodeHistoryEventType.Grabbed).ToList();

src/NzbDrone.Core/Download/TrackedDownloads/TrackedDownload.cs

@@ -40,6 +40,7 @@ namespace NzbDrone.Core.Download.TrackedDownloads
     public enum TrackedDownloadState
     {
         Downloading,
+        ImportBlocked,
         ImportPending,
         Importing,
         Imported,

src/NzbDrone.Core/Localization/Core/en.json

@@ -1992,6 +1992,7 @@
   "Umask770Description": "{octal} - Owner & Group write",
   "Umask775Description": "{octal} - Owner & Group write, Other read",
   "Umask777Description": "{octal} - Everyone write",
+  "UnableToImportAutomatically": "Unable to Import Automatically",
   "UnableToLoadAutoTagging": "Unable to load auto tagging",
   "UnableToLoadBackups": "Unable to load backups",
   "UnableToUpdateSonarrDirectly": "Unable to update {appName} directly,",