Fixed: Waiting a long time for unavailable root folders

Closes #2877

frontend/src/RootFolder/RootFolderRow.css

@@ -1,7 +1,16 @@
 .link {
   composes: link from '~Components/Link/Link.css';
+}
+
+.unavailablePath {
+  display: flex;
+  align-items: center;
+}
+
+.unavailableLabel {
+  composes: label from '~Components/Label.css';
 
-  display: block;
+  margin-left: 10px;
 }
 
 .freeSpace,

frontend/src/RootFolder/RootFolderRow.js

@@ -1,7 +1,8 @@
 import PropTypes from 'prop-types';
 import React from 'react';
 import formatBytes from 'Utilities/Number/formatBytes';
-import { icons } from 'Helpers/Props';
+import { icons, kinds } from 'Helpers/Props';
+import Label from 'Components/Label';
 import IconButton from 'Components/Link/IconButton';
 import Link from 'Components/Link/Link';
 import TableRow from 'Components/Table/TableRow';
@@ -18,20 +19,35 @@ function RootFolderRow(props) {
   } = props;
 
   const unmappedFoldersCount = unmappedFolders.length || '-';
+  const isUnavailable = freeSpace == null;
 
   return (
     <TableRow>
       <TableRowCell>
-        <Link
-          className={styles.link}
-          to={`/add/import/${id}`}
-        >
-          {path}
-        </Link>
+        {
+          isUnavailable ?
+            <div className={styles.unavailablePath}>
+              {path}
+
+              <Label
+                className={styles.unavailableLabel}
+                kind={kinds.DANGER}
+              >
+                Unavailable
+              </Label>
+            </div> :
+
+            <Link
+              className={styles.link}
+              to={`/add/import/${id}`}
+            >
+              {path}
+            </Link>
+        }
       </TableRowCell>
 
       <TableRowCell className={styles.freeSpace}>
-        {formatBytes(freeSpace) || '-'}
+        {freeSpace ? formatBytes(freeSpace) : '-'}
       </TableRowCell>
 
       <TableRowCell className={styles.unmappedFolders}>
@@ -52,13 +68,12 @@ function RootFolderRow(props) {
 RootFolderRow.propTypes = {
   id: PropTypes.number.isRequired,
   path: PropTypes.string.isRequired,
-  freeSpace: PropTypes.number.isRequired,
+  freeSpace: PropTypes.number,
   unmappedFolders: PropTypes.arrayOf(PropTypes.object).isRequired,
   onDeletePress: PropTypes.func.isRequired
 };
 
 RootFolderRow.defaultProps = {
-  freeSpace: 0,
   unmappedFolders: []
 };
 

src/NzbDrone.Core.Test/RootFolderTests/RootFolderServiceFixture.cs

@@ -7,7 +7,6 @@ using FluentAssertions;
 using Moq;
 using NUnit.Framework;
 using NzbDrone.Common.Disk;
-using NzbDrone.Core.Configuration;
 using NzbDrone.Core.RootFolders;
 using NzbDrone.Core.Test.Framework;
 using NzbDrone.Core.Tv;

src/NzbDrone.Core/RootFolders/RootFolderService.cs

@@ -2,6 +2,8 @@ using System.Linq;
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Threading;
+using System.Threading.Tasks;
 using NLog;
 using NzbDrone.Common;
 using NzbDrone.Common.Disk;
@@ -67,11 +69,9 @@ namespace NzbDrone.Core.RootFolders
             {
                 try
                 {
-                    if (folder.Path.IsPathValid() && _diskProvider.FolderExists(folder.Path))
+                    if (folder.Path.IsPathValid())
                     {
-                        folder.FreeSpace = _diskProvider.GetAvailableSpace(folder.Path);
-                        folder.TotalSpace = _diskProvider.GetTotalSize(folder.Path);
-                        folder.UnmappedFolders = GetUnmappedFolders(folder.Path);
+                        GetDetails(folder);
                     }
                 }
                 //We don't want an exception to prevent the root folders from loading in the UI, so they can still be deleted
@@ -111,9 +111,7 @@ namespace NzbDrone.Core.RootFolders
 
             _rootFolderRepository.Insert(rootFolder);
 
-            rootFolder.FreeSpace = _diskProvider.GetAvailableSpace(rootFolder.Path);
-            rootFolder.TotalSpace = _diskProvider.GetTotalSize(rootFolder.Path);
-            rootFolder.UnmappedFolders = GetUnmappedFolders(rootFolder.Path);
+            GetDetails(rootFolder);
 
             return rootFolder;
         }
@@ -160,9 +158,8 @@ namespace NzbDrone.Core.RootFolders
         public RootFolder Get(int id)
         {
             var rootFolder = _rootFolderRepository.Get(id);
-            rootFolder.FreeSpace = _diskProvider.GetAvailableSpace(rootFolder.Path);
-            rootFolder.TotalSpace = _diskProvider.GetTotalSize(rootFolder.Path);
-            rootFolder.UnmappedFolders = GetUnmappedFolders(rootFolder.Path);
+            GetDetails(rootFolder);
+
             return rootFolder;
         }
 
@@ -179,5 +176,19 @@ namespace NzbDrone.Core.RootFolders
 
             return possibleRootFolder.Path;
         }
+
+        private void GetDetails(RootFolder rootFolder)
+        {
+            Task.Run(() =>
+            {
+                if (_diskProvider.FolderExists(rootFolder.Path))
+                {
+                    rootFolder.FreeSpace = _diskProvider.GetAvailableSpace(rootFolder.Path);
+                    rootFolder.TotalSpace = _diskProvider.GetTotalSize(rootFolder.Path);
+                    rootFolder.UnmappedFolders = GetUnmappedFolders(rootFolder.Path);
+                }
+            })
+                .Wait(5000);
+        }
     }
 }