From ee00ef8c17962ce1e3b1c018d7ed359dd2099559 Mon Sep 17 00:00:00 2001 From: Mark McDowall Date: Tue, 26 Apr 2011 08:39:03 -0700 Subject: [PATCH] Added notes for handling Full Season releases, decisions to be made on how to handle them and how to correct multi-episode releases (as long as the first episode is needed we mark it as so). Currently full season releases can be parsed, but will not process. --- NzbDrone.Core/Providers/EpisodeProvider.cs | 3 ++- NzbDrone.Core/Providers/Indexer/IndexerProviderBase.cs | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/NzbDrone.Core/Providers/EpisodeProvider.cs b/NzbDrone.Core/Providers/EpisodeProvider.cs index 4eefb176e..0f1fed3af 100644 --- a/NzbDrone.Core/Providers/EpisodeProvider.cs +++ b/NzbDrone.Core/Providers/EpisodeProvider.cs @@ -75,6 +75,8 @@ namespace NzbDrone.Core.Providers /// public virtual bool IsNeeded(EpisodeParseResult parsedReport) { + //Todo: Fix this so it properly handles multi-epsiode releases (Currently as long as the first episode is needed we download it) + //Todo: for small releases this is less of an issue, but for Full Season Releases this could be an issue if we only need the first episode (or first few) foreach (var episode in parsedReport.Episodes) { var episodeInfo = GetEpisode(parsedReport.SeriesId, parsedReport.SeasonNumber, episode); @@ -128,7 +130,6 @@ namespace NzbDrone.Core.Providers Logger.Trace("Quality is past cut-off skipping."); continue; } - } } diff --git a/NzbDrone.Core/Providers/Indexer/IndexerProviderBase.cs b/NzbDrone.Core/Providers/Indexer/IndexerProviderBase.cs index 299eb27d2..6c7f85a0a 100644 --- a/NzbDrone.Core/Providers/Indexer/IndexerProviderBase.cs +++ b/NzbDrone.Core/Providers/Indexer/IndexerProviderBase.cs @@ -135,6 +135,9 @@ namespace NzbDrone.Core.Providers.Indexer return; } + //Todo: How to handle full season files? Currently the episode list is completely empty for these releases + //Todo: Should we assume that the release contains all the episodes that belong to this season and add them from the DB? + if (!_episodeProvider.IsNeeded(parseResult)) { _logger.Debug("Episode {0} is not needed. skipping.", parseResult);