From 0166d9a0dddbbd3c862c25a3c75c62b2ef48db35 Mon Sep 17 00:00:00 2001
From: morpheus65535 <louis_vezina@hotmail.com>
Date: Tue, 8 Mar 2022 23:04:00 -0500
Subject: [PATCH] Implemented number input and used it with backup retention
 and port settings.

---
 frontend/src/pages/Settings/General/index.tsx | 24 +++++++++++++++----
 frontend/src/pages/Settings/Radarr/index.tsx  |  5 +++-
 frontend/src/pages/Settings/Sonarr/index.tsx  |  5 +++-
 .../src/pages/Settings/components/forms.tsx   | 14 ++++++++++-
 4 files changed, 41 insertions(+), 7 deletions(-)

diff --git a/frontend/src/pages/Settings/General/index.tsx b/frontend/src/pages/Settings/General/index.tsx
index 3c48ceeee..5e9b1b5dc 100644
--- a/frontend/src/pages/Settings/General/index.tsx
+++ b/frontend/src/pages/Settings/General/index.tsx
@@ -46,7 +46,11 @@ const SettingsGeneralView: FunctionComponent = () => {
           <Message>Valid IPv4 address or '0.0.0.0' for all interfaces</Message>
         </Input>
         <Input name="Port">
-          <Text placeholder={6767} settingKey="settings-general-port"></Text>
+          <Text
+            placeholder={6767}
+            settingKey="settings-general-port"
+            numberWithArrows={true}
+          ></Text>
         </Input>
         <Input name="Base URL">
           <InputGroup>
@@ -131,7 +135,10 @@ const SettingsGeneralView: FunctionComponent = () => {
               <Text settingKey="settings-proxy-url"></Text>
             </Input>
             <Input name="Port">
-              <Text settingKey="settings-proxy-port"></Text>
+              <Text
+                settingKey="settings-proxy-port"
+                numberWithArrows={true}
+              ></Text>
             </Input>
             <Input name="Username">
               <Text settingKey="settings-proxy-username"></Text>
@@ -177,8 +184,17 @@ const SettingsGeneralView: FunctionComponent = () => {
         </Input>
       </Group>
       <Group header="Backups">
-        <File settingKey="settings-backup-folder" type="bazarr"></File>
-        <Message>Absolute path to the backup directory</Message>
+        <Input name="Folder">
+          <File settingKey="settings-backup-folder" type="bazarr"></File>
+          <Message>Absolute path to the backup directory</Message>
+        </Input>
+
+        <Input name="Retention (days)">
+          <Text
+            settingKey="settings-backup-retention"
+            numberWithArrows={true}
+          ></Text>
+        </Input>
       </Group>
       <Group header="Analytics">
         <Input>
diff --git a/frontend/src/pages/Settings/Radarr/index.tsx b/frontend/src/pages/Settings/Radarr/index.tsx
index 7281983fd..4511134f7 100644
--- a/frontend/src/pages/Settings/Radarr/index.tsx
+++ b/frontend/src/pages/Settings/Radarr/index.tsx
@@ -39,7 +39,10 @@ const SettingsRadarrView: FunctionComponent<Props> = () => {
               <Message>Hostname or IPv4 Address</Message>
             </Input>
             <Input name="Port">
-              <Text settingKey="settings-radarr-port"></Text>
+              <Text
+                settingKey="settings-radarr-port"
+                numberWithArrows={true}
+              ></Text>
             </Input>
             <Input name="Base URL">
               <InputGroup>
diff --git a/frontend/src/pages/Settings/Sonarr/index.tsx b/frontend/src/pages/Settings/Sonarr/index.tsx
index c1e26e2dc..6dd97b0b6 100644
--- a/frontend/src/pages/Settings/Sonarr/index.tsx
+++ b/frontend/src/pages/Settings/Sonarr/index.tsx
@@ -41,7 +41,10 @@ const SettingsSonarrView: FunctionComponent<Props> = () => {
               <Message>Hostname or IPv4 Address</Message>
             </Input>
             <Input name="Port">
-              <Text settingKey="settings-sonarr-port"></Text>
+              <Text
+                settingKey="settings-sonarr-port"
+                numberWithArrows={true}
+              ></Text>
             </Input>
             <Input name="Base URL">
               <InputGroup>
diff --git a/frontend/src/pages/Settings/components/forms.tsx b/frontend/src/pages/Settings/components/forms.tsx
index 47361289a..32ac352e3 100644
--- a/frontend/src/pages/Settings/components/forms.tsx
+++ b/frontend/src/pages/Settings/components/forms.tsx
@@ -39,6 +39,7 @@ export interface TextProps extends BaseInput<React.ReactText> {
   placeholder?: React.ReactText;
   password?: boolean;
   controlled?: boolean;
+  numberWithArrows?: boolean;
 }
 
 export const Text: FunctionComponent<TextProps> = ({
@@ -49,15 +50,26 @@ export const Text: FunctionComponent<TextProps> = ({
   override,
   password,
   settingKey,
+  numberWithArrows,
 }) => {
   const value = useLatest<React.ReactText>(settingKey, isReactText, override);
 
   const update = useSingleUpdate();
   const collapse = useCollapse();
 
+  const fieldType = () => {
+    if (password) {
+      return "password";
+    } else if (numberWithArrows) {
+      return "number";
+    } else {
+      return "text";
+    }
+  };
+
   return (
     <Form.Control
-      type={password ? "password" : "text"}
+      type={fieldType()}
       placeholder={placeholder?.toString()}
       disabled={disabled}
       defaultValue={controlled ? undefined : value ?? undefined}