Fix some foreign providers not being updated properly

bazarr/subtitles/download.py

@@ -143,11 +143,13 @@ def _get_language_obj(languages):
 
 
 def _set_forced_providers(forced_required, pool):
+    # TODO: maybe a separate pool for forced configs? only_foreign is hardcoded
+    # in get_providers and this causes updating the pool on every call
     if forced_required:
-        pool.provider_configs['podnapisi']['only_foreign'] = True
-        pool.provider_configs['subscene']['only_foreign'] = True
-        pool.provider_configs['opensubtitles']['only_foreign'] = True
-    else:
-        pool.provider_configs['podnapisi']['only_foreign'] = False
-        pool.provider_configs['subscene']['only_foreign'] = False
-        pool.provider_configs['opensubtitles']['only_foreign'] = False
+        pool.provider_configs.update(
+            {
+                "podnapisi": {"only_foreign": True},
+                "subscene": {"only_foreign": True},
+                "opensubtitles": {"only_foreign": True}
+             }
+        )

bazarr/subtitles/manual.py

@@ -56,10 +56,9 @@ def manual_search(path, profile_id, providers, sceneName, title, media_type):
                         if language.forced:
                             subscene_language_set.add(language)
                     if len(subscene_language_set):
-                        s_pool.provider_configs['subscene'] = {}
-                        s_pool.provider_configs['subscene']['only_foreign'] = True
+                        s_pool.provider_configs.update({"subscene": {"only_foreign": True}})
                         subtitles_subscene = list_all_subtitles([video], subscene_language_set, s_pool)
-                        s_pool.provider_configs['subscene']['only_foreign'] = False
+                        s_pool.provider_configs.update({"subscene": {"only_foreign": False}})
                         subtitles[video] += subtitles_subscene[video]
             else:
                 subtitles = []