From dae68d7e8b5968b79855a5c840f5fbae7fc0ab06 Mon Sep 17 00:00:00 2001 From: German Gutierrez Date: Fri, 8 May 2020 13:57:42 +0200 Subject: [PATCH 01/11] betaseries: logging 404 errors instead of raising --- libs/subliminal_patch/providers/betaseries.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libs/subliminal_patch/providers/betaseries.py b/libs/subliminal_patch/providers/betaseries.py index 7115ada5e..41a48291c 100644 --- a/libs/subliminal_patch/providers/betaseries.py +++ b/libs/subliminal_patch/providers/betaseries.py @@ -139,7 +139,12 @@ class BetaSeriesProvider(Provider): def download_subtitle(self, subtitle): logger.info('Downloading subtitle %r', subtitle) r = self.session.get(subtitle.download_link, timeout=10) - r.raise_for_status() + print('STATUS %s' % r.status_code) + if r.status_code == 404: + logger.error('Error 404 downloading %r', subtitle) + return + else: + r.raise_for_status() archive = _get_archive(r.content) if archive: @@ -153,7 +158,7 @@ class BetaSeriesProvider(Provider): if subtitle_content: subtitle.content = fix_line_ending(subtitle_content) else: - logger.debug('Could not extract subtitle from %r', archive) + logger.error('Could not extract subtitle from %r', archive) def _get_archive(content): From fda6b5ef014e5893fa299e9b17d688a968d11d03 Mon Sep 17 00:00:00 2001 From: German Gutierrez Date: Fri, 8 May 2020 14:08:17 +0200 Subject: [PATCH 02/11] betaseries: removing print line used for debug --- libs/subliminal_patch/providers/betaseries.py | 1 - 1 file changed, 1 deletion(-) diff --git a/libs/subliminal_patch/providers/betaseries.py b/libs/subliminal_patch/providers/betaseries.py index 41a48291c..f4c769293 100644 --- a/libs/subliminal_patch/providers/betaseries.py +++ b/libs/subliminal_patch/providers/betaseries.py @@ -139,7 +139,6 @@ class BetaSeriesProvider(Provider): def download_subtitle(self, subtitle): logger.info('Downloading subtitle %r', subtitle) r = self.session.get(subtitle.download_link, timeout=10) - print('STATUS %s' % r.status_code) if r.status_code == 404: logger.error('Error 404 downloading %r', subtitle) return From 84ad5aaeaa43adc28effa485e94f33781b40e256 Mon Sep 17 00:00:00 2001 From: josdion Date: Thu, 4 Jun 2020 20:24:55 +0300 Subject: [PATCH 03/11] fix for #914 Replace latin_1 with cp1252, as latin_1 is already in the list with its alias iso-8859-1. Don't know why cp1252 hasn't been included so far. --- libs/subliminal_patch/subtitle.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/subliminal_patch/subtitle.py b/libs/subliminal_patch/subtitle.py index 4ef52edbe..b3dc3ebcb 100644 --- a/libs/subliminal_patch/subtitle.py +++ b/libs/subliminal_patch/subtitle.py @@ -206,7 +206,7 @@ class Subtitle(Subtitle_): else: # Western European (windows-1252) / Northern European - encodings.extend(['latin-1', 'iso-8859-15', 'iso-8859-9', 'iso-8859-4', 'iso-8859-1']) + encodings.extend(['windows-1252', 'iso-8859-15', 'iso-8859-9', 'iso-8859-4', 'iso-8859-1']) # try to decode logger.debug('Trying encodings %r', encodings) From 9bd725beb23407c70f3a6f5bbd3bee24b7b97baf Mon Sep 17 00:00:00 2001 From: Halali Date: Sun, 7 Jun 2020 14:00:42 +0200 Subject: [PATCH 04/11] Post-Processing Score tag Added --- bazarr/get_subtitle.py | 12 +-- bazarr/helper.py | 3 +- views/_main.html | 2 +- views/settingssubtitles.html | 161 ++++++++++++++++++++++------------- 4 files changed, 109 insertions(+), 69 deletions(-) diff --git a/bazarr/get_subtitle.py b/bazarr/get_subtitle.py index 8de7bc5ab..87eafa4a6 100644 --- a/bazarr/get_subtitle.py +++ b/bazarr/get_subtitle.py @@ -220,10 +220,10 @@ def download_subtitle(path, language, audio_language, hi, forced, providers, pro + "%." if use_postprocessing is True: + percent_score = round(subtitle.score * 100 / max_score, 2) command = pp_replace(postprocessing_cmd, path, downloaded_path, downloaded_language, downloaded_language_code2, downloaded_language_code3, audio_language, - audio_language_code2, audio_language_code3, subtitle.language.forced) - percent_score = round(subtitle.score * 100 / max_score, 2) + audio_language_code2, audio_language_code3, subtitle.language.forced, percent_score) if media_type == 'series': use_pp_threshold = settings.general.getboolean('use_postprocessing_threshold') @@ -445,10 +445,10 @@ def manual_download_subtitle(path, language, audio_language, hi, forced, subtitl score) + "% using manual search." if use_postprocessing is True: + percent_score = round(subtitle.score * 100 / max_score, 2) command = pp_replace(postprocessing_cmd, path, downloaded_path, downloaded_language, downloaded_language_code2, downloaded_language_code3, audio_language, - audio_language_code2, audio_language_code3, subtitle.language.forced) - percent_score = round(subtitle.score * 100 / max_score, 2) + audio_language_code2, audio_language_code3, subtitle.language.forced, percent_score) if media_type == 'series': use_pp_threshold = settings.general.getboolean('use_postprocessing_threshold') @@ -560,10 +560,10 @@ def manual_upload_subtitle(path, language, forced, title, scene_name, media_type audio_language_code3 = alpha3_from_language(audio_language) - if use_postprocessing is True: + if use_postprocessing: command = pp_replace(postprocessing_cmd, path, subtitle_path, uploaded_language, uploaded_language_code2, uploaded_language_code3, audio_language, - audio_language_code2, audio_language_code3, forced) + audio_language_code2, audio_language_code3, forced, 100) postprocessing(command, path) diff --git a/bazarr/helper.py b/bazarr/helper.py index f4a08135c..7b91486e1 100644 --- a/bazarr/helper.py +++ b/bazarr/helper.py @@ -95,7 +95,7 @@ class PathMappings: path_mappings = PathMappings() -def pp_replace(pp_command, episode, subtitles, language, language_code2, language_code3, episode_language, episode_language_code2, episode_language_code3, forced): +def pp_replace(pp_command, episode, subtitles, language, language_code2, language_code3, episode_language, episode_language_code2, episode_language_code3, forced, score): is_forced = ":forced" if forced else "" is_forced_string = " forced" if forced else "" pp_command = pp_command.replace('{{directory}}', os.path.dirname(episode)) @@ -108,6 +108,7 @@ def pp_replace(pp_command, episode, subtitles, language, language_code2, languag pp_command = pp_command.replace('{{episode_language}}', episode_language) pp_command = pp_command.replace('{{episode_language_code2}}', episode_language_code2) pp_command = pp_command.replace('{{episode_language_code3}}', episode_language_code3) + pp_command = pp_command.replace('{{score}}', score) return pp_command diff --git a/views/_main.html b/views/_main.html index 94bf67cbf..3d2237c6f 100644 --- a/views/_main.html +++ b/views/_main.html @@ -130,7 +130,7 @@ -