From 0806d0dc922f4967996630ccef44109e52390065 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sat, 18 Dec 2021 11:13:32 +0100
Subject: [PATCH] Bugfix/fix hidden statistics values (#552)

* Fix hidden values (0)

* Update changelog
---
 CHANGELOG.md                                  |  1 +
 .../src/app/pages/about/about-page.html       | 29 ++++++++++++++-----
 2 files changed, 23 insertions(+), 7 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4d1fc56bc..b23a9d1f2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Fixed the symbol conversion from _Yahoo Finance_ including a hyphen
+- Fixed hidden values (`0`) in the statistics section on the about page
 
 ### Todo
 
diff --git a/apps/client/src/app/pages/about/about-page.html b/apps/client/src/app/pages/about/about-page.html
index a8462f5c1..e9e9482a8 100644
--- a/apps/client/src/app/pages/about/about-page.html
+++ b/apps/client/src/app/pages/about/about-page.html
@@ -108,8 +108,11 @@
         <mat-card-content>
           <div class="row">
             <div class="col-xs-12 col-md-4 my-2">
-              <h3 class="mb-0" [hidden]="!statistics?.activeUsers1d">
-                {{ statistics?.activeUsers1d ?? '-' }}
+              <h3
+                class="mb-0"
+                [hidden]="statistics?.activeUsers1d === undefined"
+              >
+                {{ statistics?.activeUsers1d || '-' }}
               </h3>
               <div class="h6 mb-0">
                 <span i18n>Active Users</span>&nbsp;<small class="text-muted"
@@ -118,7 +121,10 @@
               </div>
             </div>
             <div class="col-xs-12 col-md-4 my-2">
-              <h3 class="mb-0" [hidden]="!statistics?.activeUsers7d">
+              <h3
+                class="mb-0"
+                [hidden]="statistics?.activeUsers7d === undefined"
+              >
                 {{ statistics?.activeUsers7d ?? '-' }}
               </h3>
               <div class="h6 mb-0">
@@ -128,7 +134,10 @@
               </div>
             </div>
             <div class="col-xs-12 col-md-4 my-2">
-              <h3 class="mb-0" [hidden]="!statistics?.activeUsers30d">
+              <h3
+                class="mb-0"
+                [hidden]="statistics?.activeUsers30d === undefined"
+              >
                 {{ statistics?.activeUsers30d ?? '-' }}
               </h3>
               <div class="h6 mb-0">
@@ -138,7 +147,7 @@
               </div>
             </div>
             <div class="col-xs-12 col-md-4 my-2">
-              <h3 class="mb-0" [hidden]="!statistics?.newUsers30d">
+              <h3 class="mb-0" [hidden]="statistics?.newUsers30d === undefined">
                 {{ statistics?.newUsers30d ?? '-' }}
               </h3>
               <div class="h6 mb-0">
@@ -148,13 +157,19 @@
               </div>
             </div>
             <div class="col-xs-12 col-md-4 my-2">
-              <h3 class="mb-0" [hidden]="!statistics?.gitHubContributors">
+              <h3
+                class="mb-0"
+                [hidden]="statistics?.gitHubContributors === undefined"
+              >
                 {{ statistics?.gitHubContributors ?? '-' }}
               </h3>
               <div class="h6 mb-0" i18n>Contributors on GitHub</div>
             </div>
             <div class="col-xs-12 col-md-4 my-2">
-              <h3 class="mb-0" [hidden]="!statistics?.gitHubStargazers">
+              <h3
+                class="mb-0"
+                [hidden]="statistics?.gitHubStargazers === undefined"
+              >
                 {{ statistics?.gitHubStargazers ?? '-' }}
               </h3>
               <div class="h6 mb-0" i18n>Stars on GitHub</div>