Bugfix/fix symbol conversion from yahoo finance with hyphen (#549)

* Fix symbol conversion from Yahoo Finance * Update changelog
2 years ago · 155bf67f60
parent 9aefe3747e
commit 155bf67f60
2 changed files with 5 additions and 1 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

 ## Unreleased

+### Fixed
+
+- Fixed the symbol conversion from _Yahoo Finance_ including a hyphen
+
 ### Todo

 - Apply data migration (`yarn database:migrate`)
--- a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
+++ b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
@ -240,7 +240,7 @@ export class YahooFinanceService implements DataProviderInterface {
  }

  private convertFromYahooFinanceSymbol(aYahooFinanceSymbol: string) {
-    const symbol = aYahooFinanceSymbol.replace('-', '');
+    const symbol = aYahooFinanceSymbol.replace('-USD', 'USD');
    return symbol.replace('=X', '');
  }