From 21570cca19c3cd1d0ae0ff974ae1b0853a07838d Mon Sep 17 00:00:00 2001
From: Thomas <4159106+dtslvr@users.noreply.github.com>
Date: Sat, 31 Jul 2021 22:46:39 +0200
Subject: [PATCH] Fix impersonation in performance endpoint

---
 apps/api/src/app/portfolio/portfolio.controller.ts | 8 +-------
 apps/api/src/app/portfolio/portfolio.service.ts    | 7 +------
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/apps/api/src/app/portfolio/portfolio.controller.ts b/apps/api/src/app/portfolio/portfolio.controller.ts
index a7f5aa197..812e69f4b 100644
--- a/apps/api/src/app/portfolio/portfolio.controller.ts
+++ b/apps/api/src/app/portfolio/portfolio.controller.ts
@@ -236,14 +236,8 @@ export class PortfolioController {
     @Query('range') range,
     @Res() res: Response
   ): Promise<PortfolioPerformance> {
-    const impersonationUserId =
-      await this.impersonationService.validateImpersonationId(
-        impersonationId,
-        this.request.user.id
-      );
-
     const performanceInformation = await this.portfolioService.getPerformance(
-      impersonationUserId,
+      impersonationId,
       range
     );
 
diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index bc719b66d..ac012fa2f 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -527,12 +527,7 @@ export class PortfolioService {
     aImpersonationId: string,
     aDateRange: DateRange = 'max'
   ): Promise<{ hasErrors: boolean; performance: PortfolioPerformance }> {
-    const impersonationUserId =
-      await this.impersonationService.validateImpersonationId(
-        aImpersonationId,
-        this.request.user.id
-      );
-    const userId = impersonationUserId || this.request.user.id;
+    const userId = await this.getUserId(aImpersonationId);
 
     const portfolioCalculator = new PortfolioCalculator(
       this.currentRateService,