From 29d3b762a8d6e66abe473adf5a239f3e8a71e421 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sun, 6 Oct 2024 18:49:42 +0200 Subject: [PATCH] Feature/switch typescript-eslint no-unused-vars to error (#3887) * Switch @typescript-eslint/no-unused-vars to error --- .eslintrc.json | 1 - .../api/src/app/account/account.controller.ts | 15 +++---- apps/api/src/app/account/account.service.ts | 9 +---- .../app/admin/update-bulk-market-data.dto.ts | 2 +- apps/api/src/app/auth/google.strategy.ts | 3 +- .../calculator/mwr/portfolio-calculator.ts | 16 ++------ .../twr/portfolio-calculator.spec.ts | 39 ------------------- .../calculator/twr/portfolio-calculator.ts | 8 +--- .../portfolio/current-rate.service.spec.ts | 2 +- .../src/app/portfolio/portfolio.service.ts | 5 +-- .../redis-cache/redis-cache.service.mock.ts | 4 +- .../src/app/user/update-user-setting.dto.ts | 1 - .../emergency-fund/emergency-fund-setup.ts | 2 +- .../alpha-vantage/alpha-vantage.service.ts | 2 +- .../coingecko/coingecko.service.ts | 2 +- .../yahoo-finance/yahoo-finance.service.ts | 1 - .../eod-historical-data.service.ts | 4 +- .../financial-modeling-prep.service.ts | 2 +- .../google-sheets/google-sheets.service.ts | 2 +- .../data-provider/manual/manual.service.ts | 10 ++--- .../rapid-api/rapid-api.service.ts | 2 +- .../yahoo-finance/yahoo-finance.service.ts | 2 +- .../exchange-rate-data.service.mock.ts | 7 +--- .../portfolio-snapshot.service.mock.ts | 2 - apps/api/src/validators/is-currency-code.ts | 5 +-- .../src/app/adapter/custom-date-adapter.ts | 2 +- .../admin-market-data.service.ts | 2 +- .../home-overview/home-overview.component.ts | 1 - .../core/notification/notification.service.ts | 2 +- .../src/app/pages/faq/faq-page.component.ts | 2 +- .../src/lib/assistant/assistant.component.ts | 1 - .../holdings-table.component.ts | 1 - .../portfolio-proportion-chart.component.ts | 2 +- .../top-holdings/top-holdings.component.ts | 1 - 34 files changed, 38 insertions(+), 124 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index c2e6b8079..a3b868692 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -135,7 +135,6 @@ "@typescript-eslint/no-unsafe-enum-comparison": "warn", "@typescript-eslint/no-unsafe-member-access": "warn", "@typescript-eslint/no-unsafe-return": "warn", - "@typescript-eslint/no-unused-vars": "warn", "@typescript-eslint/no-unsafe-call": "warn", "@typescript-eslint/require-await": "warn", "@typescript-eslint/restrict-template-expressions": "warn", diff --git a/apps/api/src/app/account/account.controller.ts b/apps/api/src/app/account/account.controller.ts index 44e136793..c0f4dac6a 100644 --- a/apps/api/src/app/account/account.controller.ts +++ b/apps/api/src/app/account/account.controller.ts @@ -74,15 +74,12 @@ export class AccountController { ); } - return this.accountService.deleteAccount( - { - id_userId: { - id, - userId: this.request.user.id - } - }, - this.request.user.id - ); + return this.accountService.deleteAccount({ + id_userId: { + id, + userId: this.request.user.id + } + }); } @Get() diff --git a/apps/api/src/app/account/account.service.ts b/apps/api/src/app/account/account.service.ts index 37876dde0..096caba48 100644 --- a/apps/api/src/app/account/account.service.ts +++ b/apps/api/src/app/account/account.service.ts @@ -108,8 +108,7 @@ export class AccountService { } public async deleteAccount( - where: Prisma.AccountWhereUniqueInput, - aUserId: string + where: Prisma.AccountWhereUniqueInput ): Promise { const account = await this.prismaService.account.delete({ where @@ -170,11 +169,7 @@ export class AccountService { where.isExcluded = false; } - const { - ACCOUNT: filtersByAccount, - ASSET_CLASS: filtersByAssetClass, - TAG: filtersByTag - } = groupBy(filters, ({ type }) => { + const { ACCOUNT: filtersByAccount } = groupBy(filters, ({ type }) => { return type; }); diff --git a/apps/api/src/app/admin/update-bulk-market-data.dto.ts b/apps/api/src/app/admin/update-bulk-market-data.dto.ts index 5177263a6..da0da1272 100644 --- a/apps/api/src/app/admin/update-bulk-market-data.dto.ts +++ b/apps/api/src/app/admin/update-bulk-market-data.dto.ts @@ -1,5 +1,5 @@ import { Type } from 'class-transformer'; -import { ArrayNotEmpty, IsArray, isNotEmptyObject } from 'class-validator'; +import { ArrayNotEmpty, IsArray } from 'class-validator'; import { UpdateMarketDataDto } from './update-market-data.dto'; diff --git a/apps/api/src/app/auth/google.strategy.ts b/apps/api/src/app/auth/google.strategy.ts index 4d024603b..ea6772680 100644 --- a/apps/api/src/app/auth/google.strategy.ts +++ b/apps/api/src/app/auth/google.strategy.ts @@ -29,8 +29,7 @@ export class GoogleStrategy extends PassportStrategy(Strategy, 'google') { token: string, refreshToken: string, profile: Profile, - done: Function, - done2: Function + done: Function ) { try { const jwt = await this.authService.validateOAuthLogin({ diff --git a/apps/api/src/app/portfolio/calculator/mwr/portfolio-calculator.ts b/apps/api/src/app/portfolio/calculator/mwr/portfolio-calculator.ts index eb49b7cdb..e54f63422 100644 --- a/apps/api/src/app/portfolio/calculator/mwr/portfolio-calculator.ts +++ b/apps/api/src/app/portfolio/calculator/mwr/portfolio-calculator.ts @@ -3,24 +3,14 @@ import { AssetProfileIdentifier, SymbolMetrics } from '@ghostfolio/common/interfaces'; -import { PortfolioSnapshot, TimelinePosition } from '@ghostfolio/common/models'; +import { PortfolioSnapshot } from '@ghostfolio/common/models'; export class MWRPortfolioCalculator extends PortfolioCalculator { - protected calculateOverallPerformance( - positions: TimelinePosition[] - ): PortfolioSnapshot { + protected calculateOverallPerformance(): PortfolioSnapshot { throw new Error('Method not implemented.'); } - protected getSymbolMetrics({ - dataSource, - end, - exchangeRates, - marketSymbolMap, - start, - step = 1, - symbol - }: { + protected getSymbolMetrics({}: { end: Date; exchangeRates: { [dateString: string]: number }; marketSymbolMap: { diff --git a/apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.spec.ts b/apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.spec.ts index d8431cd83..99bee2c21 100644 --- a/apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.spec.ts +++ b/apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.spec.ts @@ -1,42 +1,3 @@ -import { PortfolioCalculatorFactory } from '@ghostfolio/api/app/portfolio/calculator/portfolio-calculator.factory'; -import { CurrentRateService } from '@ghostfolio/api/app/portfolio/current-rate.service'; -import { RedisCacheService } from '@ghostfolio/api/app/redis-cache/redis-cache.service'; -import { ConfigurationService } from '@ghostfolio/api/services/configuration/configuration.service'; -import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data/exchange-rate-data.service'; -import { PortfolioSnapshotService } from '@ghostfolio/api/services/queues/portfolio-snapshot/portfolio-snapshot.service'; - describe('PortfolioCalculator', () => { - let configurationService: ConfigurationService; - let currentRateService: CurrentRateService; - let exchangeRateDataService: ExchangeRateDataService; - let portfolioCalculatorFactory: PortfolioCalculatorFactory; - let portfolioSnapshotService: PortfolioSnapshotService; - let redisCacheService: RedisCacheService; - - beforeEach(() => { - configurationService = new ConfigurationService(); - - currentRateService = new CurrentRateService(null, null, null, null); - - exchangeRateDataService = new ExchangeRateDataService( - null, - null, - null, - null - ); - - portfolioSnapshotService = new PortfolioSnapshotService(null); - - redisCacheService = new RedisCacheService(null, null); - - portfolioCalculatorFactory = new PortfolioCalculatorFactory( - configurationService, - currentRateService, - exchangeRateDataService, - portfolioSnapshotService, - redisCacheService - ); - }); - test.skip('Skip empty test', () => 1); }); diff --git a/apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.ts b/apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.ts index b26b6fac1..b66bc0d53 100644 --- a/apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.ts +++ b/apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.ts @@ -12,13 +12,7 @@ import { DateRange } from '@ghostfolio/common/types'; import { Logger } from '@nestjs/common'; import { Big } from 'big.js'; -import { - addDays, - addMilliseconds, - differenceInDays, - format, - isBefore -} from 'date-fns'; +import { addMilliseconds, differenceInDays, format, isBefore } from 'date-fns'; import { cloneDeep, first, last, sortBy } from 'lodash'; export class TWRPortfolioCalculator extends PortfolioCalculator { diff --git a/apps/api/src/app/portfolio/current-rate.service.spec.ts b/apps/api/src/app/portfolio/current-rate.service.spec.ts index c86dde448..d0e61c8ce 100644 --- a/apps/api/src/app/portfolio/current-rate.service.spec.ts +++ b/apps/api/src/app/portfolio/current-rate.service.spec.ts @@ -79,7 +79,7 @@ jest.mock('@ghostfolio/api/services/property/property.service', () => { return { PropertyService: jest.fn().mockImplementation(() => { return { - getByKey: (key: string) => Promise.resolve({}) + getByKey: () => Promise.resolve({}) }; }) }; diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts index e79853e5c..89eeb666d 100644 --- a/apps/api/src/app/portfolio/portfolio.service.ts +++ b/apps/api/src/app/portfolio/portfolio.service.ts @@ -1053,8 +1053,7 @@ export class PortfolioService { dateRange = 'max', filters, impersonationId, - userId, - withExcludedAccounts = false + userId }: { dateRange?: DateRange; filters?: Filter[]; @@ -1308,7 +1307,7 @@ export class PortfolioService { } }; - for (const [symbol, position] of Object.entries(holdings)) { + for (const [, position] of Object.entries(holdings)) { const value = position.valueInBaseCurrency; if (position.assetClass !== AssetClass.LIQUIDITY) { diff --git a/apps/api/src/app/redis-cache/redis-cache.service.mock.ts b/apps/api/src/app/redis-cache/redis-cache.service.mock.ts index 2779308bd..feb669ab0 100644 --- a/apps/api/src/app/redis-cache/redis-cache.service.mock.ts +++ b/apps/api/src/app/redis-cache/redis-cache.service.mock.ts @@ -1,7 +1,5 @@ import { Filter } from '@ghostfolio/common/interfaces'; -import { Milliseconds } from 'cache-manager'; - export const RedisCacheServiceMock = { cache: new Map(), get: (key: string): Promise => { @@ -20,7 +18,7 @@ export const RedisCacheServiceMock = { return `portfolio-snapshot-${userId}${filtersHash > 0 ? `-${filtersHash}` : ''}`; }, - set: (key: string, value: string, ttl?: Milliseconds): Promise => { + set: (key: string, value: string): Promise => { RedisCacheServiceMock.cache.set(key, value); return Promise.resolve(value); diff --git a/apps/api/src/app/user/update-user-setting.dto.ts b/apps/api/src/app/user/update-user-setting.dto.ts index b4d3edb77..6ea6d7427 100644 --- a/apps/api/src/app/user/update-user-setting.dto.ts +++ b/apps/api/src/app/user/update-user-setting.dto.ts @@ -1,5 +1,4 @@ import { IsCurrencyCode } from '@ghostfolio/api/validators/is-currency-code'; -import { PortfolioReportRule } from '@ghostfolio/common/interfaces'; import type { ColorScheme, DateRange, diff --git a/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts b/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts index c59701438..819b8bd7b 100644 --- a/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts +++ b/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts @@ -18,7 +18,7 @@ export class EmergencyFundSetup extends Rule { this.emergencyFund = emergencyFund; } - public evaluate(ruleSettings: Settings) { + public evaluate() { if (!this.emergencyFund) { return { evaluation: 'No emergency fund has been set up', diff --git a/apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts b/apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts index 4e93bc757..016584949 100644 --- a/apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts +++ b/apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts @@ -33,7 +33,7 @@ export class AlphaVantageService implements DataProviderInterface { }); } - public canHandle(symbol: string) { + public canHandle() { return !!this.configurationService.get('API_KEY_ALPHA_VANTAGE'); } diff --git a/apps/api/src/services/data-provider/coingecko/coingecko.service.ts b/apps/api/src/services/data-provider/coingecko/coingecko.service.ts index 067a6fbf9..d420c51fd 100644 --- a/apps/api/src/services/data-provider/coingecko/coingecko.service.ts +++ b/apps/api/src/services/data-provider/coingecko/coingecko.service.ts @@ -48,7 +48,7 @@ export class CoinGeckoService implements DataProviderInterface { } } - public canHandle(symbol: string) { + public canHandle() { return true; } diff --git a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts index 35fa9604a..1b1335b7e 100644 --- a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts +++ b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts @@ -83,7 +83,6 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface { } public async enhance({ - requestTimeout = this.configurationService.get('REQUEST_TIMEOUT'), response, symbol }: { diff --git a/apps/api/src/services/data-provider/eod-historical-data/eod-historical-data.service.ts b/apps/api/src/services/data-provider/eod-historical-data/eod-historical-data.service.ts index 8b2a1828b..cc23344a3 100644 --- a/apps/api/src/services/data-provider/eod-historical-data/eod-historical-data.service.ts +++ b/apps/api/src/services/data-provider/eod-historical-data/eod-historical-data.service.ts @@ -43,7 +43,7 @@ export class EodHistoricalDataService implements DataProviderInterface { this.apiKey = this.configurationService.get('API_KEY_EOD_HISTORICAL_DATA'); } - public canHandle(symbol: string) { + public canHandle() { return true; } @@ -163,7 +163,7 @@ export class EodHistoricalDataService implements DataProviderInterface { ).json(); return response.reduce( - (result, { close, date }, index, array) => { + (result, { close, date }) => { if (isNumber(close)) { result[this.convertFromEodSymbol(symbol)][date] = { marketPrice: close diff --git a/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts b/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts index cf9c5ef9b..7d5b38479 100644 --- a/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts +++ b/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts @@ -33,7 +33,7 @@ export class FinancialModelingPrepService implements DataProviderInterface { ); } - public canHandle(symbol: string) { + public canHandle() { return true; } diff --git a/apps/api/src/services/data-provider/google-sheets/google-sheets.service.ts b/apps/api/src/services/data-provider/google-sheets/google-sheets.service.ts index c8ff87719..966069f22 100644 --- a/apps/api/src/services/data-provider/google-sheets/google-sheets.service.ts +++ b/apps/api/src/services/data-provider/google-sheets/google-sheets.service.ts @@ -29,7 +29,7 @@ export class GoogleSheetsService implements DataProviderInterface { private readonly symbolProfileService: SymbolProfileService ) {} - public canHandle(symbol: string) { + public canHandle() { return true; } diff --git a/apps/api/src/services/data-provider/manual/manual.service.ts b/apps/api/src/services/data-provider/manual/manual.service.ts index 02e50a145..030ab8ea2 100644 --- a/apps/api/src/services/data-provider/manual/manual.service.ts +++ b/apps/api/src/services/data-provider/manual/manual.service.ts @@ -39,7 +39,7 @@ export class ManualService implements DataProviderInterface { private readonly symbolProfileService: SymbolProfileService ) {} - public canHandle(symbol: string) { + public canHandle() { return true; } @@ -86,12 +86,8 @@ export class ManualService implements DataProviderInterface { const [symbolProfile] = await this.symbolProfileService.getSymbolProfiles( [{ symbol, dataSource: this.getName() }] ); - const { - defaultMarketPrice, - headers = {}, - selector, - url - } = symbolProfile?.scraperConfiguration ?? {}; + const { defaultMarketPrice, selector, url } = + symbolProfile?.scraperConfiguration ?? {}; if (defaultMarketPrice) { const historical: { diff --git a/apps/api/src/services/data-provider/rapid-api/rapid-api.service.ts b/apps/api/src/services/data-provider/rapid-api/rapid-api.service.ts index 7e866552e..e47e96d88 100644 --- a/apps/api/src/services/data-provider/rapid-api/rapid-api.service.ts +++ b/apps/api/src/services/data-provider/rapid-api/rapid-api.service.ts @@ -26,7 +26,7 @@ export class RapidApiService implements DataProviderInterface { private readonly configurationService: ConfigurationService ) {} - public canHandle(symbol: string) { + public canHandle() { return !!this.configurationService.get('API_KEY_RAPID_API'); } diff --git a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts index a8f7d261e..2d67c646c 100644 --- a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts +++ b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts @@ -34,7 +34,7 @@ export class YahooFinanceService implements DataProviderInterface { private readonly yahooFinanceDataEnhancerService: YahooFinanceDataEnhancerService ) {} - public canHandle(symbol: string) { + public canHandle() { return true; } diff --git a/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.mock.ts b/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.mock.ts index 59f5144d8..8f5d1c28a 100644 --- a/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.mock.ts +++ b/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.mock.ts @@ -1,10 +1,5 @@ export const ExchangeRateDataServiceMock = { - getExchangeRatesByCurrency: ({ - currencies, - endDate, - startDate, - targetCurrency - }): Promise => { + getExchangeRatesByCurrency: ({ targetCurrency }): Promise => { if (targetCurrency === 'CHF') { return Promise.resolve({ CHFCHF: { diff --git a/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts b/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts index 8d7526906..59fdc5855 100644 --- a/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts +++ b/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts @@ -5,8 +5,6 @@ import { IPortfolioSnapshotQueueJob } from './interfaces/portfolio-snapshot-queu export const PortfolioSnapshotServiceMock = { addJobToQueue({ - data, - name, opts }: { data: IPortfolioSnapshotQueueJob; diff --git a/apps/api/src/validators/is-currency-code.ts b/apps/api/src/validators/is-currency-code.ts index 8e8530552..34a82c481 100644 --- a/apps/api/src/validators/is-currency-code.ts +++ b/apps/api/src/validators/is-currency-code.ts @@ -4,8 +4,7 @@ import { registerDecorator, ValidationOptions, ValidatorConstraint, - ValidatorConstraintInterface, - ValidationArguments + ValidatorConstraintInterface } from 'class-validator'; import { isISO4217CurrencyCode } from 'class-validator'; @@ -25,7 +24,7 @@ export function IsCurrencyCode(validationOptions?: ValidationOptions) { export class IsExtendedCurrencyConstraint implements ValidatorConstraintInterface { - public defaultMessage(args: ValidationArguments) { + public defaultMessage() { return '$value must be a valid ISO4217 currency code'; } diff --git a/apps/client/src/app/adapter/custom-date-adapter.ts b/apps/client/src/app/adapter/custom-date-adapter.ts index 724ea7211..a1326b823 100644 --- a/apps/client/src/app/adapter/custom-date-adapter.ts +++ b/apps/client/src/app/adapter/custom-date-adapter.ts @@ -15,7 +15,7 @@ export class CustomDateAdapter extends NativeDateAdapter { /** * Formats a date as a string */ - public format(aDate: Date, aParseFormat: string): string { + public format(aDate: Date): string { return format(aDate, getDateFormatString(this.locale)); } diff --git a/apps/client/src/app/components/admin-market-data/admin-market-data.service.ts b/apps/client/src/app/components/admin-market-data/admin-market-data.service.ts index b1d7154e9..9695dc2a2 100644 --- a/apps/client/src/app/components/admin-market-data/admin-market-data.service.ts +++ b/apps/client/src/app/components/admin-market-data/admin-market-data.service.ts @@ -12,7 +12,7 @@ import { } from '@ghostfolio/common/interfaces'; import { Injectable } from '@angular/core'; -import { EMPTY, catchError, finalize, forkJoin, takeUntil } from 'rxjs'; +import { EMPTY, catchError, finalize, forkJoin } from 'rxjs'; @Injectable() export class AdminMarketDataService { diff --git a/apps/client/src/app/components/home-overview/home-overview.component.ts b/apps/client/src/app/components/home-overview/home-overview.component.ts index a32041fce..cd6495a31 100644 --- a/apps/client/src/app/components/home-overview/home-overview.component.ts +++ b/apps/client/src/app/components/home-overview/home-overview.component.ts @@ -11,7 +11,6 @@ import { User } from '@ghostfolio/common/interfaces'; import { hasPermission, permissions } from '@ghostfolio/common/permissions'; -import { DateRange } from '@ghostfolio/common/types'; import { ChangeDetectorRef, Component, OnDestroy, OnInit } from '@angular/core'; import { DeviceDetectorService } from 'ngx-device-detector'; diff --git a/apps/client/src/app/core/notification/notification.service.ts b/apps/client/src/app/core/notification/notification.service.ts index 2e7d9de6c..189da67f5 100644 --- a/apps/client/src/app/core/notification/notification.service.ts +++ b/apps/client/src/app/core/notification/notification.service.ts @@ -33,7 +33,7 @@ export class NotificationService { title: aParams.title }); - return dialog.afterClosed().subscribe((result) => { + return dialog.afterClosed().subscribe(() => { if (isFunction(aParams.discardFn)) { aParams.discardFn(); } diff --git a/apps/client/src/app/pages/faq/faq-page.component.ts b/apps/client/src/app/pages/faq/faq-page.component.ts index 0bbe1c904..1e0d508ae 100644 --- a/apps/client/src/app/pages/faq/faq-page.component.ts +++ b/apps/client/src/app/pages/faq/faq-page.component.ts @@ -1,5 +1,5 @@ import { DataService } from '@ghostfolio/client/services/data.service'; -import { TabConfiguration, User } from '@ghostfolio/common/interfaces'; +import { TabConfiguration } from '@ghostfolio/common/interfaces'; import { hasPermission, permissions } from '@ghostfolio/common/permissions'; import { Component, OnDestroy, OnInit } from '@angular/core'; diff --git a/libs/ui/src/lib/assistant/assistant.component.ts b/libs/ui/src/lib/assistant/assistant.component.ts index 1da5e682e..c60e93d88 100644 --- a/libs/ui/src/lib/assistant/assistant.component.ts +++ b/libs/ui/src/lib/assistant/assistant.component.ts @@ -36,7 +36,6 @@ import { MatMenuTrigger } from '@angular/material/menu'; import { MatSelectModule } from '@angular/material/select'; import { RouterModule } from '@angular/router'; import { Account, AssetClass } from '@prisma/client'; -import { eachYearOfInterval, format } from 'date-fns'; import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader'; import { EMPTY, Observable, Subject, lastValueFrom } from 'rxjs'; import { diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts index 1f44cf405..257fa2013 100644 --- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts +++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts @@ -18,7 +18,6 @@ import { Input, OnChanges, OnDestroy, - OnInit, Output, ViewChild } from '@angular/core'; diff --git a/libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.ts b/libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.ts index ad11c54f3..d3a28dffe 100644 --- a/libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.ts +++ b/libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.ts @@ -270,7 +270,7 @@ export class GfPortfolioProportionChartComponent } ]; - let labels = chartDataSorted.map(([symbol, { name }]) => { + let labels = chartDataSorted.map(([, { name }]) => { return name; }); diff --git a/libs/ui/src/lib/top-holdings/top-holdings.component.ts b/libs/ui/src/lib/top-holdings/top-holdings.component.ts index 38ef3524d..9c4a22cfb 100644 --- a/libs/ui/src/lib/top-holdings/top-holdings.component.ts +++ b/libs/ui/src/lib/top-holdings/top-holdings.component.ts @@ -10,7 +10,6 @@ import { Input, OnChanges, OnDestroy, - OnInit, ViewChild } from '@angular/core'; import { MatButtonModule } from '@angular/material/button';