From 308d3b64b1dab5203f5d6922bd6b4333f7c535ab Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 19 Oct 2024 18:54:49 +0200 Subject: [PATCH] Feature/Remove empty constructors (#3958) * Remove empty constructors --- apps/api/src/app/portfolio/rules.service.ts | 2 -- .../redact-values-in-response.interceptor.ts | 2 -- apps/api/src/services/api/api.service.ts | 2 -- .../api/src/services/cryptocurrency/cryptocurrency.service.ts | 2 -- .../asset-profile-icon/asset-profile-icon.component.ts | 2 -- .../app/components/dialog-footer/dialog-footer.component.ts | 2 -- .../app/components/dialog-header/dialog-header.component.ts | 2 -- .../fear-and-greed-index/fear-and-greed-index.component.ts | 2 -- .../portfolio-summary/portfolio-summary.component.ts | 2 -- apps/client/src/app/components/toggle/toggle.component.ts | 2 -- apps/client/src/app/core/language.service.ts | 4 +--- .../src/app/pages/about/changelog/changelog-page.component.ts | 2 -- .../src/app/pages/about/license/license-page.component.ts | 2 -- .../app/pages/about/oss-friends/oss-friends-page.component.ts | 2 -- .../about/privacy-policy/privacy-policy-page.component.ts | 2 -- .../app/pages/faq/self-hosting/self-hosting-page.component.ts | 2 -- apps/client/src/app/pages/i18n/i18n-page.component.ts | 2 -- apps/client/src/app/pages/markets/markets-page.component.ts | 2 -- .../personal-finance-tools-page.component.ts | 2 -- apps/client/src/app/pipes/symbol/symbol.pipe.ts | 2 -- apps/client/src/app/services/ics/ics.service.ts | 2 -- apps/client/src/app/services/impersonation-storage.service.ts | 2 -- apps/client/src/app/services/settings-storage.service.ts | 2 -- libs/ui/src/lib/activity-type/activity-type.component.ts | 2 -- .../data-provider-credits/data-provider-credits.component.ts | 2 -- libs/ui/src/lib/fire-calculator/fire-calculator.service.ts | 2 -- libs/ui/src/lib/holdings-table/holdings-table.component.ts | 2 -- libs/ui/src/lib/logo/logo.component.ts | 2 -- .../no-transactions-info/no-transactions-info.component.ts | 2 -- .../src/lib/premium-indicator/premium-indicator.component.ts | 2 -- libs/ui/src/lib/trend-indicator/trend-indicator.component.ts | 2 -- libs/ui/src/lib/value/value.component.ts | 2 -- 32 files changed, 1 insertion(+), 65 deletions(-) diff --git a/apps/api/src/app/portfolio/rules.service.ts b/apps/api/src/app/portfolio/rules.service.ts index 5f0aa64d5..48d1658aa 100644 --- a/apps/api/src/app/portfolio/rules.service.ts +++ b/apps/api/src/app/portfolio/rules.service.ts @@ -9,8 +9,6 @@ import { Injectable } from '@nestjs/common'; @Injectable() export class RulesService { - public constructor() {} - public async evaluate( aRules: Rule[], aUserSettings: UserSettings diff --git a/apps/api/src/interceptors/redact-values-in-response/redact-values-in-response.interceptor.ts b/apps/api/src/interceptors/redact-values-in-response/redact-values-in-response.interceptor.ts index cae4f22ed..83b66b370 100644 --- a/apps/api/src/interceptors/redact-values-in-response/redact-values-in-response.interceptor.ts +++ b/apps/api/src/interceptors/redact-values-in-response/redact-values-in-response.interceptor.ts @@ -19,8 +19,6 @@ import { map } from 'rxjs/operators'; export class RedactValuesInResponseInterceptor implements NestInterceptor { - public constructor() {} - public intercept( context: ExecutionContext, next: CallHandler diff --git a/apps/api/src/services/api/api.service.ts b/apps/api/src/services/api/api.service.ts index 5bcc6bb1d..8ff438ef1 100644 --- a/apps/api/src/services/api/api.service.ts +++ b/apps/api/src/services/api/api.service.ts @@ -4,8 +4,6 @@ import { Injectable } from '@nestjs/common'; @Injectable() export class ApiService { - public constructor() {} - public buildFiltersFromQueryParams({ filterByAccounts, filterByAssetClasses, diff --git a/apps/api/src/services/cryptocurrency/cryptocurrency.service.ts b/apps/api/src/services/cryptocurrency/cryptocurrency.service.ts index 53feb8cc9..db5cf0876 100644 --- a/apps/api/src/services/cryptocurrency/cryptocurrency.service.ts +++ b/apps/api/src/services/cryptocurrency/cryptocurrency.service.ts @@ -7,8 +7,6 @@ const customCryptocurrencies = require('../../assets/cryptocurrencies/custom.jso export class CryptocurrencyService { private combinedCryptocurrencies: string[]; - public constructor() {} - public isCryptocurrency(aSymbol = '') { const cryptocurrencySymbol = aSymbol.substring(0, aSymbol.length - 3); return this.getCryptocurrencies().includes(cryptocurrencySymbol); diff --git a/apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts b/apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts index 4d96ef83f..108c39b04 100644 --- a/apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts +++ b/apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts @@ -26,8 +26,6 @@ export class GfAssetProfileIconComponent implements OnChanges { public src: string; - public constructor() {} - public ngOnChanges() { if (this.dataSource && this.symbol) { this.src = `../api/v1/logo/${this.dataSource}/${this.symbol}`; diff --git a/apps/client/src/app/components/dialog-footer/dialog-footer.component.ts b/apps/client/src/app/components/dialog-footer/dialog-footer.component.ts index 404d0bda4..a7150b7f1 100644 --- a/apps/client/src/app/components/dialog-footer/dialog-footer.component.ts +++ b/apps/client/src/app/components/dialog-footer/dialog-footer.component.ts @@ -19,8 +19,6 @@ export class DialogFooterComponent implements OnInit { @Output() closeButtonClicked = new EventEmitter(); - public constructor() {} - public ngOnInit() {} public onClickCloseButton() { diff --git a/apps/client/src/app/components/dialog-header/dialog-header.component.ts b/apps/client/src/app/components/dialog-header/dialog-header.component.ts index b577e7004..f93dec460 100644 --- a/apps/client/src/app/components/dialog-header/dialog-header.component.ts +++ b/apps/client/src/app/components/dialog-header/dialog-header.component.ts @@ -21,8 +21,6 @@ export class DialogHeaderComponent implements OnInit { @Output() closeButtonClicked = new EventEmitter(); - public constructor() {} - public ngOnInit() {} public onClickCloseButton() { diff --git a/apps/client/src/app/components/fear-and-greed-index/fear-and-greed-index.component.ts b/apps/client/src/app/components/fear-and-greed-index/fear-and-greed-index.component.ts index d562e7ba2..fac0e4b98 100644 --- a/apps/client/src/app/components/fear-and-greed-index/fear-and-greed-index.component.ts +++ b/apps/client/src/app/components/fear-and-greed-index/fear-and-greed-index.component.ts @@ -21,8 +21,6 @@ export class FearAndGreedIndexComponent implements OnChanges, OnInit { public fearAndGreedIndexEmoji: string; public fearAndGreedIndexText: string; - public constructor() {} - public ngOnInit() {} public ngOnChanges() { diff --git a/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts b/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts index b99cc77dd..0cf9d0474 100644 --- a/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts +++ b/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.ts @@ -35,8 +35,6 @@ export class PortfolioSummaryComponent implements OnChanges, OnInit { ); public timeInMarket: string; - public constructor() {} - public ngOnInit() {} public ngOnChanges() { diff --git a/apps/client/src/app/components/toggle/toggle.component.ts b/apps/client/src/app/components/toggle/toggle.component.ts index fe41ec77e..2d177b870 100644 --- a/apps/client/src/app/components/toggle/toggle.component.ts +++ b/apps/client/src/app/components/toggle/toggle.component.ts @@ -34,8 +34,6 @@ export class ToggleComponent implements OnChanges, OnInit { public optionFormControl = new FormControl(undefined); - public constructor() {} - public ngOnInit() {} public ngOnChanges() { diff --git a/apps/client/src/app/core/language.service.ts b/apps/client/src/app/core/language.service.ts index 212d97cc3..ebd0e21dc 100644 --- a/apps/client/src/app/core/language.service.ts +++ b/apps/client/src/app/core/language.service.ts @@ -1,6 +1,4 @@ import { Injectable } from '@angular/core'; @Injectable() -export class LanguageService { - public constructor() {} -} +export class LanguageService {} diff --git a/apps/client/src/app/pages/about/changelog/changelog-page.component.ts b/apps/client/src/app/pages/about/changelog/changelog-page.component.ts index 0de907b6a..3acec3c3e 100644 --- a/apps/client/src/app/pages/about/changelog/changelog-page.component.ts +++ b/apps/client/src/app/pages/about/changelog/changelog-page.component.ts @@ -9,8 +9,6 @@ import { Subject } from 'rxjs'; export class ChangelogPageComponent implements OnDestroy { private unsubscribeSubject = new Subject(); - public constructor() {} - public ngOnDestroy() { this.unsubscribeSubject.next(); this.unsubscribeSubject.complete(); diff --git a/apps/client/src/app/pages/about/license/license-page.component.ts b/apps/client/src/app/pages/about/license/license-page.component.ts index 3eadaa4de..b9b74322b 100644 --- a/apps/client/src/app/pages/about/license/license-page.component.ts +++ b/apps/client/src/app/pages/about/license/license-page.component.ts @@ -9,8 +9,6 @@ import { Subject } from 'rxjs'; export class LicensePageComponent implements OnDestroy { private unsubscribeSubject = new Subject(); - public constructor() {} - public ngOnDestroy() { this.unsubscribeSubject.next(); this.unsubscribeSubject.complete(); diff --git a/apps/client/src/app/pages/about/oss-friends/oss-friends-page.component.ts b/apps/client/src/app/pages/about/oss-friends/oss-friends-page.component.ts index f0a2e70a3..fefda7abd 100644 --- a/apps/client/src/app/pages/about/oss-friends/oss-friends-page.component.ts +++ b/apps/client/src/app/pages/about/oss-friends/oss-friends-page.component.ts @@ -13,8 +13,6 @@ export class OpenSourceSoftwareFriendsPageComponent implements OnDestroy { private unsubscribeSubject = new Subject(); - public constructor() {} - public ngOnDestroy() { this.unsubscribeSubject.next(); this.unsubscribeSubject.complete(); diff --git a/apps/client/src/app/pages/about/privacy-policy/privacy-policy-page.component.ts b/apps/client/src/app/pages/about/privacy-policy/privacy-policy-page.component.ts index 9ebddfab3..117234fc4 100644 --- a/apps/client/src/app/pages/about/privacy-policy/privacy-policy-page.component.ts +++ b/apps/client/src/app/pages/about/privacy-policy/privacy-policy-page.component.ts @@ -9,8 +9,6 @@ import { Subject } from 'rxjs'; export class PrivacyPolicyPageComponent implements OnDestroy { private unsubscribeSubject = new Subject(); - public constructor() {} - public ngOnDestroy() { this.unsubscribeSubject.next(); this.unsubscribeSubject.complete(); diff --git a/apps/client/src/app/pages/faq/self-hosting/self-hosting-page.component.ts b/apps/client/src/app/pages/faq/self-hosting/self-hosting-page.component.ts index b454020e1..936ec9e19 100644 --- a/apps/client/src/app/pages/faq/self-hosting/self-hosting-page.component.ts +++ b/apps/client/src/app/pages/faq/self-hosting/self-hosting-page.component.ts @@ -10,8 +10,6 @@ import { Subject } from 'rxjs'; export class SelfHostingPageComponent implements OnDestroy { private unsubscribeSubject = new Subject(); - public constructor() {} - public ngOnInit() {} public ngOnDestroy() { diff --git a/apps/client/src/app/pages/i18n/i18n-page.component.ts b/apps/client/src/app/pages/i18n/i18n-page.component.ts index 9718ac328..d2c880b20 100644 --- a/apps/client/src/app/pages/i18n/i18n-page.component.ts +++ b/apps/client/src/app/pages/i18n/i18n-page.component.ts @@ -11,8 +11,6 @@ import { Subject } from 'rxjs'; export class GfI18nPageComponent implements OnInit { private unsubscribeSubject = new Subject(); - public constructor() {} - public ngOnInit() {} public ngOnDestroy() { diff --git a/apps/client/src/app/pages/markets/markets-page.component.ts b/apps/client/src/app/pages/markets/markets-page.component.ts index 10aa09092..b79a8e446 100644 --- a/apps/client/src/app/pages/markets/markets-page.component.ts +++ b/apps/client/src/app/pages/markets/markets-page.component.ts @@ -10,8 +10,6 @@ import { Subject } from 'rxjs'; export class MarketsPageComponent implements OnDestroy, OnInit { private unsubscribeSubject = new Subject(); - public constructor() {} - public ngOnInit() {} public ngOnDestroy() { diff --git a/apps/client/src/app/pages/resources/personal-finance-tools/personal-finance-tools-page.component.ts b/apps/client/src/app/pages/resources/personal-finance-tools/personal-finance-tools-page.component.ts index 6dfbe8a88..cadc62563 100644 --- a/apps/client/src/app/pages/resources/personal-finance-tools/personal-finance-tools-page.component.ts +++ b/apps/client/src/app/pages/resources/personal-finance-tools/personal-finance-tools-page.component.ts @@ -19,8 +19,6 @@ export class PersonalFinanceToolsPageComponent implements OnDestroy { private unsubscribeSubject = new Subject(); - public constructor() {} - public ngOnDestroy() { this.unsubscribeSubject.next(); this.unsubscribeSubject.complete(); diff --git a/apps/client/src/app/pipes/symbol/symbol.pipe.ts b/apps/client/src/app/pipes/symbol/symbol.pipe.ts index 3a709b2bc..7e77339f6 100644 --- a/apps/client/src/app/pipes/symbol/symbol.pipe.ts +++ b/apps/client/src/app/pipes/symbol/symbol.pipe.ts @@ -4,8 +4,6 @@ import { Pipe, PipeTransform } from '@angular/core'; @Pipe({ name: 'gfSymbol' }) export class SymbolPipe implements PipeTransform { - public constructor() {} - public transform(aSymbol: string) { return prettifySymbol(aSymbol); } diff --git a/apps/client/src/app/services/ics/ics.service.ts b/apps/client/src/app/services/ics/ics.service.ts index c426902e7..b94b2dee3 100644 --- a/apps/client/src/app/services/ics/ics.service.ts +++ b/apps/client/src/app/services/ics/ics.service.ts @@ -12,8 +12,6 @@ export class IcsService { private readonly ICS_DATE_FORMAT = 'yyyyMMdd'; private readonly ICS_LINE_BREAK = '\r\n'; - public constructor() {} - public transformActivitiesToIcsContent( aActivities: Export['activities'] ): string { diff --git a/apps/client/src/app/services/impersonation-storage.service.ts b/apps/client/src/app/services/impersonation-storage.service.ts index 2423e76fd..fccbc8570 100644 --- a/apps/client/src/app/services/impersonation-storage.service.ts +++ b/apps/client/src/app/services/impersonation-storage.service.ts @@ -11,8 +11,6 @@ export class ImpersonationStorageService { this.getId() ); - public constructor() {} - public getId(): string { return window.localStorage.getItem(IMPERSONATION_KEY); } diff --git a/apps/client/src/app/services/settings-storage.service.ts b/apps/client/src/app/services/settings-storage.service.ts index 9aa5ece18..add224fd8 100644 --- a/apps/client/src/app/services/settings-storage.service.ts +++ b/apps/client/src/app/services/settings-storage.service.ts @@ -8,8 +8,6 @@ export const KEY_TOKEN = 'auth-token'; providedIn: 'root' }) export class SettingsStorageService { - public constructor() {} - public getSetting(aKey: string): string { return window.localStorage.getItem(aKey); } diff --git a/libs/ui/src/lib/activity-type/activity-type.component.ts b/libs/ui/src/lib/activity-type/activity-type.component.ts index 1554794b3..95b24b4ba 100644 --- a/libs/ui/src/lib/activity-type/activity-type.component.ts +++ b/libs/ui/src/lib/activity-type/activity-type.component.ts @@ -24,8 +24,6 @@ export class GfActivityTypeComponent implements OnChanges { public activityTypeLabel: string; - public constructor() {} - public ngOnChanges() { this.activityTypeLabel = translate(this.activityType); } diff --git a/libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts b/libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts index bfab714f9..5afab3b3f 100644 --- a/libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts +++ b/libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts @@ -19,6 +19,4 @@ import { }) export class GfDataProviderCreditsComponent { @Input() dataProviderInfos: DataProviderInfo[]; - - public constructor() {} } diff --git a/libs/ui/src/lib/fire-calculator/fire-calculator.service.ts b/libs/ui/src/lib/fire-calculator/fire-calculator.service.ts index 8a5e3afb9..848a9efa4 100644 --- a/libs/ui/src/lib/fire-calculator/fire-calculator.service.ts +++ b/libs/ui/src/lib/fire-calculator/fire-calculator.service.ts @@ -5,8 +5,6 @@ import { Big } from 'big.js'; export class FireCalculatorService { private readonly COMPOUND_PERIOD = 12; - public constructor() {} - public calculateCompoundInterest({ P, periodInMonths, diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts index 257fa2013..b140827e9 100644 --- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts +++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts @@ -76,8 +76,6 @@ export class GfHoldingsTableComponent implements OnChanges, OnDestroy { private unsubscribeSubject = new Subject(); - public constructor() {} - public ngOnChanges() { this.displayedColumns = ['icon', 'nameWithSymbol', 'dateOfFirstActivity']; diff --git a/libs/ui/src/lib/logo/logo.component.ts b/libs/ui/src/lib/logo/logo.component.ts index d9edd546e..216dfbe3a 100644 --- a/libs/ui/src/lib/logo/logo.component.ts +++ b/libs/ui/src/lib/logo/logo.component.ts @@ -20,6 +20,4 @@ export class GfLogoComponent { @HostBinding('class') @Input() size: 'large' | 'medium' = 'medium'; @Input() label: string; @Input() showLabel = true; - - public constructor() {} } diff --git a/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts b/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts index 7fc8830a8..adde1ef49 100644 --- a/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts +++ b/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts @@ -21,6 +21,4 @@ import { GfLogoComponent } from '../logo'; }) export class GfNoTransactionsInfoComponent { @HostBinding('class.has-border') @Input() hasBorder = true; - - public constructor() {} } diff --git a/libs/ui/src/lib/premium-indicator/premium-indicator.component.ts b/libs/ui/src/lib/premium-indicator/premium-indicator.component.ts index ff2b158b5..f3350f447 100644 --- a/libs/ui/src/lib/premium-indicator/premium-indicator.component.ts +++ b/libs/ui/src/lib/premium-indicator/premium-indicator.component.ts @@ -18,6 +18,4 @@ import { RouterModule } from '@angular/router'; }) export class GfPremiumIndicatorComponent { @Input() enableLink = true; - - public constructor() {} } diff --git a/libs/ui/src/lib/trend-indicator/trend-indicator.component.ts b/libs/ui/src/lib/trend-indicator/trend-indicator.component.ts index dcf32ab37..9f550add3 100644 --- a/libs/ui/src/lib/trend-indicator/trend-indicator.component.ts +++ b/libs/ui/src/lib/trend-indicator/trend-indicator.component.ts @@ -24,6 +24,4 @@ export class GfTrendIndicatorComponent { @Input() marketState: MarketState = 'open'; @Input() size: 'large' | 'medium' | 'small' = 'small'; @Input() value = 0; - - public constructor() {} } diff --git a/libs/ui/src/lib/value/value.component.ts b/libs/ui/src/lib/value/value.component.ts index 47730d466..43415e87a 100644 --- a/libs/ui/src/lib/value/value.component.ts +++ b/libs/ui/src/lib/value/value.component.ts @@ -41,8 +41,6 @@ export class GfValueComponent implements OnChanges { public isString = false; public useAbsoluteValue = false; - public constructor() {} - public ngOnChanges() { this.initializeVariables();