From 48ba8f936b0cff5bf527f1505df81558cd1ef102 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Fri, 8 Sep 2023 20:23:22 +0200 Subject: [PATCH] Feature/deactivate internet identity for account registration (#2293) * Deactivate Internet Identity * Update changelog --- CHANGELOG.md | 1 + apps/api/src/app/auth/auth.service.ts | 2 +- apps/client/src/app/pages/register/register-page.component.ts | 4 +--- apps/client/src/app/pages/register/register-page.html | 1 + 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b491138ac..6276d39bf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Improved the validation in the activities import +- Deactivated _Internet Identity_ as a social login provider for the account registration - Improved the language localization for German (`de`) - Refreshed the cryptocurrencies list - Changed the version in the `docker-compose` files from `3.7` to `3.9` diff --git a/apps/api/src/app/auth/auth.service.ts b/apps/api/src/app/auth/auth.service.ts index 2f31e722b..c7270f8c3 100644 --- a/apps/api/src/app/auth/auth.service.ts +++ b/apps/api/src/app/auth/auth.service.ts @@ -55,7 +55,7 @@ export class AuthService { const isUserSignupEnabled = await this.propertyService.isUserSignupEnabled(); - if (!isUserSignupEnabled) { + if (!isUserSignupEnabled || true) { throw new Error('Sign up forbidden'); } diff --git a/apps/client/src/app/pages/register/register-page.component.ts b/apps/client/src/app/pages/register/register-page.component.ts index ad8fc1df4..6a68c8ac0 100644 --- a/apps/client/src/app/pages/register/register-page.component.ts +++ b/apps/client/src/app/pages/register/register-page.component.ts @@ -4,7 +4,6 @@ import { Router } from '@angular/router'; import { DataService } from '@ghostfolio/client/services/data.service'; import { InternetIdentityService } from '@ghostfolio/client/services/internet-identity.service'; import { TokenStorageService } from '@ghostfolio/client/services/token-storage.service'; -import { UserService } from '@ghostfolio/client/services/user/user.service'; import { InfoItem, LineChartItem } from '@ghostfolio/common/interfaces'; import { hasPermission, permissions } from '@ghostfolio/common/permissions'; import { Role } from '@prisma/client'; @@ -36,8 +35,7 @@ export class RegisterPageComponent implements OnDestroy, OnInit { private dialog: MatDialog, private internetIdentityService: InternetIdentityService, private router: Router, - private tokenStorageService: TokenStorageService, - private userService: UserService + private tokenStorageService: TokenStorageService ) { this.info = this.dataService.fetchInfo(); diff --git a/apps/client/src/app/pages/register/register-page.html b/apps/client/src/app/pages/register/register-page.html index 47e761235..0d13a7f75 100644 --- a/apps/client/src/app/pages/register/register-page.html +++ b/apps/client/src/app/pages/register/register-page.html @@ -28,6 +28,7 @@
or