From 5db984ffef13118b219ad2638196f6caa68ab1af Mon Sep 17 00:00:00 2001
From: Aldrin <53973174+Dhoni77@users.noreply.github.com>
Date: Thu, 12 Oct 2023 13:51:00 +0530
Subject: [PATCH] Add date column to benchmark component (#2466)

* Add date column to benchmark component
---
 .../lib/benchmark/benchmark.component.html    | 27 +++++++++++++++----
 .../src/lib/benchmark/benchmark.component.ts  |  2 +-
 2 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/libs/ui/src/lib/benchmark/benchmark.component.html b/libs/ui/src/lib/benchmark/benchmark.component.html
index e395553ec..33cf72389 100644
--- a/libs/ui/src/lib/benchmark/benchmark.component.html
+++ b/libs/ui/src/lib/benchmark/benchmark.component.html
@@ -6,14 +6,33 @@
     </td>
   </ng-container>
 
+  <ng-container matColumnDef="date">
+    <th
+      *matHeaderCellDef
+      class="d-none d-lg-table-cell px-2 text-right"
+      mat-header-cell
+    >
+      <ng-container i18n>Last All Time High</ng-container>
+    </th>
+    <td *matCellDef="let element" class="d-none d-lg-table-cell px-2" mat-cell>
+      <div class="d-flex justify-content-end">
+        <gf-value
+          [isDate]="true"
+          [locale]="locale"
+          [value]="element?.performances?.allTimeHigh?.date"
+        ></gf-value>
+      </div>
+    </td>
+  </ng-container>
+
   <ng-container matColumnDef="change">
-    <th *matHeaderCellDef class="text-right" mat-header-cell>
+    <th *matHeaderCellDef class="px-2 text-right" mat-header-cell>
       <span class="d-none d-sm-block text-nowrap" i18n
         >Change from All Time High</span
       >
       <span class="d-block d-sm-none text-nowrap" i18n>from ATH</span>
     </th>
-    <td *matCellDef="let element" class="text-right" mat-cell>
+    <td *matCellDef="let element" class="px-2 text-right" mat-cell>
       <gf-value
         class="d-inline-block justify-content-end"
         size="medium"
@@ -25,9 +44,7 @@
           'text-success':
             element?.performances?.allTimeHigh?.performancePercent > 0
         }"
-        [value]="
-          element?.performances?.allTimeHigh?.performancePercent ?? undefined
-        "
+        [value]="element?.performances?.allTimeHigh?.performancePercent"
       ></gf-value>
     </td>
   </ng-container>
diff --git a/libs/ui/src/lib/benchmark/benchmark.component.ts b/libs/ui/src/lib/benchmark/benchmark.component.ts
index a5c117c24..b9f1dd25b 100644
--- a/libs/ui/src/lib/benchmark/benchmark.component.ts
+++ b/libs/ui/src/lib/benchmark/benchmark.component.ts
@@ -18,7 +18,7 @@ export class BenchmarkComponent implements OnChanges {
   @Input() benchmarks: Benchmark[];
   @Input() locale: string;
 
-  public displayedColumns = ['name', 'change', 'marketCondition'];
+  public displayedColumns = ['name', 'date', 'change', 'marketCondition'];
   public resolveMarketCondition = resolveMarketCondition;
 
   public constructor() {}