From 70f2f01f8f78286c96d2abbbc019f21dd33c5b07 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Thu, 7 Nov 2024 20:05:01 +0100
Subject: [PATCH] Bugfix/fix algebraic sign in label of treemap chart (#4030)

* Fix algebraic sign

* Update changelog
---
 CHANGELOG.md                                      |  1 +
 .../lib/treemap-chart/treemap-chart.component.ts  | 15 ++++++++++++---
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2a94eaf10..97ceff3f9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Fixed an issue with the algebraic sign in the chart of the holdings tab on the home page (experimental)
 - Improved the exception handling in the user authorization service
 - Disabled the caching of the benchmarks in the markets overview if sharing the _Fear & Greed Index_ (market mood) is enabled
 
diff --git a/libs/ui/src/lib/treemap-chart/treemap-chart.component.ts b/libs/ui/src/lib/treemap-chart/treemap-chart.component.ts
index 1acc2c925..9a8594ada 100644
--- a/libs/ui/src/lib/treemap-chart/treemap-chart.component.ts
+++ b/libs/ui/src/lib/treemap-chart/treemap-chart.component.ts
@@ -261,12 +261,21 @@ export class GfTreemapChartComponent
             display: true,
             font: [{ size: 16 }, { lineHeight: 1.5, size: 14 }],
             formatter: (ctx) => {
-              const netPerformancePercentWithCurrencyEffect =
-                ctx.raw._data.netPerformancePercentWithCurrencyEffect;
+              // Round to 4 decimal places
+              let netPerformancePercentWithCurrencyEffect =
+                Math.round(
+                  ctx.raw._data.netPerformancePercentWithCurrencyEffect * 10000
+                ) / 10000;
+
+              if (Math.abs(netPerformancePercentWithCurrencyEffect) === 0) {
+                netPerformancePercentWithCurrencyEffect = Math.abs(
+                  netPerformancePercentWithCurrencyEffect
+                );
+              }
 
               return [
                 ctx.raw._data.symbol,
-                `${netPerformancePercentWithCurrencyEffect > 0 ? '+' : ''}${(ctx.raw._data.netPerformancePercentWithCurrencyEffect * 100).toFixed(2)}%`
+                `${netPerformancePercentWithCurrencyEffect > 0 ? '+' : ''}${(netPerformancePercentWithCurrencyEffect * 100).toFixed(2)}%`
               ];
             },
             hoverColor: undefined,