Feature/improve allocations page (#1813)

* Improve loading state

* Update changelog
pull/1814/head
Thomas Kaul 1 year ago committed by GitHub
parent e5b5a9e7e9
commit 7b39b32293
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Improved the loading state of the value component on the allocations page
- Improved the value component by always showing the label (also while loading)
- Improved the language localization for German (`de`)

@ -198,6 +198,8 @@ export class AllocationsPageComponent implements OnDestroy, OnInit {
this.changeDetectorRef.markForCheck();
}
});
this.initialize();
}
public initialize() {
@ -217,15 +219,15 @@ export class AllocationsPageComponent implements OnDestroy, OnInit {
this.markets = {
developedMarkets: {
name: 'developedMarkets',
value: 0
value: undefined
},
emergingMarkets: {
name: 'emergingMarkets',
value: 0
value: undefined
},
otherMarkets: {
name: 'otherMarkets',
value: 0
value: undefined
}
};
this.positions = {};
@ -281,6 +283,16 @@ export class AllocationsPageComponent implements OnDestroy, OnInit {
// Prepare analysis data by continents, countries and sectors except for cash
if (position.countries.length > 0) {
if (!this.markets.developedMarkets.value) {
this.markets.developedMarkets.value = 0;
}
if (!this.markets.emergingMarkets.value) {
this.markets.emergingMarkets.value = 0;
}
if (!this.markets.otherMarkets.value) {
this.markets.otherMarkets.value = 0;
}
this.markets.developedMarkets.value +=
position.markets.developedMarkets * position.value;
this.markets.emergingMarkets.value +=

Loading…
Cancel
Save