From 8486c02575d76813b34a9f20a52693b848ed450c Mon Sep 17 00:00:00 2001 From: Leon Stoldt <31759512+LeonStoldt@users.noreply.github.com> Date: Mon, 23 Jan 2023 08:28:19 +0100 Subject: [PATCH] Update Node to version 18.x (#1595) * Update Node to version 18.x * Add .nvmrc * Update changelog Co-authored-by: Thomas <4159106+dtslvr@users.noreply.github.com> --- .github/workflows/build-code.yml | 2 +- .nvmrc | 1 + CHANGELOG.md | 6 ++++++ Dockerfile | 4 ++-- README.md | 2 +- 5 files changed, 11 insertions(+), 4 deletions(-) create mode 100644 .nvmrc diff --git a/.github/workflows/build-code.yml b/.github/workflows/build-code.yml index c1e950ba7..262729f29 100644 --- a/.github/workflows/build-code.yml +++ b/.github/workflows/build-code.yml @@ -10,7 +10,7 @@ jobs: strategy: matrix: node_version: - - 16 + - 18 steps: - name: Checkout code uses: actions/checkout@v3 diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 000000000..3f430af82 --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +v18 diff --git a/CHANGELOG.md b/CHANGELOG.md index 0cf21a7df..e314c023e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased + +### Changed + +- Upgraded `Node.js` from version `16` to `18` (`Dockerfile`) + ## 1.229.0 - 2023-01-21 ### Added diff --git a/Dockerfile b/Dockerfile index 5bc79b61a..33ef2d95f 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM --platform=$BUILDPLATFORM node:16-slim as builder +FROM --platform=$BUILDPLATFORM node:18-slim as builder # Build application and add additional files WORKDIR /ghostfolio @@ -50,7 +50,7 @@ COPY package.json /ghostfolio/dist/apps/api RUN yarn database:generate-typings # Image to run, copy everything needed from builder -FROM node:16-slim +FROM node:18-slim RUN apt update && apt install -y \ openssl \ && rm -rf /var/lib/apt/lists/* diff --git a/README.md b/README.md index fea70c4b7..08c758a5d 100644 --- a/README.md +++ b/README.md @@ -148,7 +148,7 @@ Please follow the instructions of the Ghostfolio [Unraid Community App](https:// ### Prerequisites - [Docker](https://www.docker.com/products/docker-desktop) -- [Node.js](https://nodejs.org/en/download) (version 16+) +- [Node.js](https://nodejs.org/en/download) (version 18+) - [Yarn](https://yarnpkg.com/en/docs/install) - A local copy of this Git repository (clone)